jpountz commented on code in PR #12197: URL: https://github.com/apache/lucene/pull/12197#discussion_r1131214184
########## lucene/core/src/java/org/apache/lucene/search/Query.java: ########## @@ -45,6 +46,13 @@ */ public abstract class Query { + static final VirtualMethod<Query> oldMethod = + new VirtualMethod<>(Query.class, "rewrite", IndexReader.class); + static final VirtualMethod<Query> newMethod = + new VirtualMethod<>(Query.class, "rewrite", IndexSearcher.class); + final boolean isDeprecatedMethodOverridden = Review Comment: Nit: make the variable name more specific? ```suggestion final boolean isDeprecatedRewriteMethodOverridden = ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org