gsmiller commented on PR #12194: URL: https://github.com/apache/lucene/pull/12194#issuecomment-1463006136
Fun! Thanks for picking this up @zacharymorn. What about updating `FixedBitSet#or(disi)` to use this? That's used when rewriting `MultiTermQuery` instances, and I would think we'd see a performance improvement to prefix3 and wildcard benchmark tasks. I guess the thinking there would be to "flip" an entire long to -1L at once if a run of 64 docs is included in a dense DISI sent to the `or`. This idea will probably have diminishing returns after #12055, since we now prioritize only building the more sparse iterators into the bitset upfront, but it could still help. If you really want to look for impact, try switching `RegexpQuery` and `PrefixQuery` to use `CONSTANT_SCORE_REWRITE` instead of `CONSTANT_SCORE_BLENDED_REWRITE` (in there constructors). That should highlight an impact in the benchmark. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
