shubhamvishu commented on PR #12183: URL: https://github.com/apache/lucene/pull/12183#issuecomment-1463213951
> If there is something that **might** benefit from being made concurrent, it may be `TermStates.build` because it does I/O via terms dictionary lookups. A benefit of making the change there is that it would automatically benefit `TermQuery`, `BlendedTermQuery`, etc. But the rest of the rewrite logic of these queries looks so cheap to me that I don't think we'd benefit from making it concurrent. I'm curious to get others' opinions as to whether this `TermStates.build` method is one we should consider making concurrent. For clarity, this could have been done before adding concurrent rewrites, as `TermQuery` calls this method in `createWeight` which has taken an `IndexSearcher` for a long time if not forever. @jpountz That sounds like a really good idea to me. Thanks for pointing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
