luyuncheng commented on PR #11987:
URL: https://github.com/apache/lucene/pull/11987#issuecomment-1334866892
> Yes, before we work around all that stuff here, I'd also suggest to remove
those ThreadLocals.
@uschindler I think this issue just have a GC path of ThreadLocals. BUT,
for i
rmuir merged PR #11974:
URL: https://github.com/apache/lucene/pull/11974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir closed issue #11973: ShapeDocValues wrong serialization
URL: https://github.com/apache/lucene/issues/11973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
rmuir commented on PR #11974:
URL: https://github.com/apache/lucene/pull/11974#issuecomment-1334646881
@nknize thank you for looking.
one other related suggestion i have for this code in the future would be to
change code such as this:
```
header |= 0x01;
```
to somet
rmuir commented on issue #11963:
URL: https://github.com/apache/lucene/issues/11963#issuecomment-1334640898
@benwtrent go do your other issue first if you prefer. sorry for the trouble.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rmuir commented on code in PR #11860:
URL: https://github.com/apache/lucene/pull/11860#discussion_r1037699596
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/ExpandingVectorValues.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Fou
nknize commented on PR #11974:
URL: https://github.com/apache/lucene/pull/11974#issuecomment-1334422558
Yeah, nice catch @rmuir!! Thanks for enabling the logical assignment
error-prone check. I had no idea that was disabled!
> I feel like some sort of testcase should have been faili
benwtrent commented on issue #11963:
URL: https://github.com/apache/lucene/issues/11963#issuecomment-1334127223
@jpountz
> which I don't like much for only two types that need to be supported?
I do think we will add more types in the future. Specifically `binary` which
can use
luyuncheng commented on PR #11987:
URL: https://github.com/apache/lucene/pull/11987#issuecomment-1333932432
> thanks for running. somehow i think bulk merge didnt get disabled. without
bulk merge optimization, indexing time should be significantly higher, the
benchmark should be very very s
rmuir commented on PR #11974:
URL: https://github.com/apache/lucene/pull/11974#issuecomment-1333827718
@nknize any thoughts? sorry i haven't had time to dig into the guts of this,
but would be good to get this check enabled
--
This is an automated message from the Apache Git Service.
To r
rmuir merged PR #11971:
URL: https://github.com/apache/lucene/pull/11971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir commented on PR #11971:
URL: https://github.com/apache/lucene/pull/11971#issuecomment-1333792349
no feedback for a few days, i'm going to merge this as it disables stuff
that's really not controversial, as it is providing no value. as far as which
of the other checks are enabled, we c
rmuir commented on PR #11987:
URL: https://github.com/apache/lucene/pull/11987#issuecomment-1333788113
thanks for running. somehow i think bulk merge didnt get disabled. without
bulk merge optimization, indexing time should be significantly higher, the
benchmark should be very very slow.
thecoop closed pull request #11982: Change ByteBuffersDataInput and
ByteBuffersIndexInput to use absolute addressing
URL: https://github.com/apache/lucene/pull/11982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
thecoop commented on PR #11982:
URL: https://github.com/apache/lucene/pull/11982#issuecomment-1333760940
I've separated out the refactoring into #11992, so that can be reviewed as-is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
thecoop opened a new pull request, #11992:
URL: https://github.com/apache/lucene/pull/11992
Add some tests around reading values in ByteBuffersDataInput
The refactorings are from #11982
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
luyuncheng commented on PR #11987:
URL: https://github.com/apache/lucene/pull/11987#issuecomment-1333730146
> We could run the StoredFieldsBenchmark before and after the change with
-Dorg.apache.lucene.codecs.lucene90.compressing.Lucene90CompressingStoredFieldsWriter.enableBulkMerge=false
t
romseygeek merged PR #11990:
URL: https://github.com/apache/lucene/pull/11990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
dweiss commented on code in PR #11990:
URL: https://github.com/apache/lucene/pull/11990#discussion_r1036988933
##
lucene/highlighter/src/java/org/apache/lucene/search/matchhighlight/PassageSelector.java:
##
@@ -89,8 +89,9 @@ public List pickBest(
}
// Best passages s
renthus opened a new issue, #11991:
URL: https://github.com/apache/lucene/issues/11991
### Description
Luke project: Lucene Toolbox Project v9.4.1I'm
trying to export files from Regex:BR_CAR_PLATE, for example, but it generates
an error due to the character <:> and we can't change th
romseygeek commented on code in PR #11990:
URL: https://github.com/apache/lucene/pull/11990#discussion_r1036896059
##
lucene/highlighter/src/java/org/apache/lucene/search/matchhighlight/PassageSelector.java:
##
@@ -89,8 +89,9 @@ public List pickBest(
}
// Best passag
21 matches
Mail list logo
