rmuir commented on PR #11974: URL: https://github.com/apache/lucene/pull/11974#issuecomment-1334646881
@nknize thank you for looking. one other related suggestion i have for this code in the future would be to change code such as this: ``` header |= 0x01; ``` to something like this: ``` // named constants grouped together which kinda documents the "format" so it is a bit easier // these names are just examples and might not be the best ones :) static final int HAS_LEFT_SUBTREE = 1 << 0; static final int HAS_RIGHT_SUBTREE = 1 << 1; ... header |= HAS_LEFT_SUBTREE; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
