romseygeek commented on code in PR #11990:
URL: https://github.com/apache/lucene/pull/11990#discussion_r1036896059
##########
lucene/highlighter/src/java/org/apache/lucene/search/matchhighlight/PassageSelector.java:
##########
@@ -89,8 +89,9 @@ public List<Passage> pickBest(
}
// Best passages so far.
+ int pqSize = Math.max(markers.size(), maxPassages);
Review Comment:
> min(markers.size(), maxPassages * 3)
Another option might be to just have a minimum size of 16, given that this
is only really a problem when you're asking for two or three passages. Once
you get above 10 passages then one or two less becomes less of an issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
