shaie commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1159376910
> It feels overly complicated to introduce `FacetSetRange<...>` and then
require the different `FacetSet` implementations to implement these methods to
deal with inclusive/exclusive boundaries
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-10557:
-
Description:
A few (not the majority) Apache projects already use the GitHub issue instead
of
shaie commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1159374588
> My only suggestion here might be to rename `LongRange` to just `Range`
Yeah `LongRange` now feels like there are missing `Int/Float/DoubleRange`
which is not the case. But maybe in ord
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-10557:
-
Description:
A few (not the majority) Apache projects already use the GitHub issue instead
of
[
https://issues.apache.org/jira/browse/LUCENE-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555844#comment-17555844
]
Tomoko Uchida commented on LUCENE-10622:
A fair warning - the migration will be
[
https://issues.apache.org/jira/browse/LUCENE-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555839#comment-17555839
]
Tomoko Uchida commented on LUCENE-10622:
For experiments, I'd choose "difficult
[
https://issues.apache.org/jira/browse/LUCENE-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555819#comment-17555819
]
Tomoko Uchida commented on LUCENE-10622:
I can create a Personal Access Token
[
https://issues.apache.org/jira/browse/LUCENE-10618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555815#comment-17555815
]
fang hou commented on LUCENE-10618:
---
should be resolved after this pr https://github.
[
https://issues.apache.org/jira/browse/LUCENE-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555803#comment-17555803
]
Tomoko Uchida commented on LUCENE-10622:
Can we have (read-only) access keys to
Tomoko Uchida created LUCENE-10622:
--
Summary: Prepare complete migration script to GitHub issue from
Jira (best effort)
Key: LUCENE-10622
URL: https://issues.apache.org/jira/browse/LUCENE-10622
Proje
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-10557:
---
Description:
A few (not the majority) Apache projects already use the GitHub issue instead
Yuti-G commented on PR #914:
URL: https://github.com/apache/lucene/pull/914#issuecomment-1159161102
Thanks @gsmiller for spending time reviewing my PR and leaving the great
feedback! I addressed all of the comments except for the one that requires
casting `List` to `int[]` for `ordinals` t
Yuti-G commented on code in PR #914:
URL: https://github.com/apache/lucene/pull/914#discussion_r900427716
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java:
##
@@ -163,6 +164,76 @@ public Number getSpecificValue(String dim, String... path)
throws
Yuti-G commented on code in PR #914:
URL: https://github.com/apache/lucene/pull/914#discussion_r900427716
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java:
##
@@ -163,6 +164,76 @@ public Number getSpecificValue(String dim, String... path)
throws
Yuti-G commented on code in PR #914:
URL: https://github.com/apache/lucene/pull/914#discussion_r900427946
##
lucene/facet/src/java/org/apache/lucene/facet/sortedset/AbstractSortedSetDocValueFacetCounts.java:
##
@@ -72,6 +72,40 @@ public FacetResult getTopChildren(int topN, Strin
Yuti-G commented on code in PR #914:
URL: https://github.com/apache/lucene/pull/914#discussion_r900427716
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java:
##
@@ -163,6 +164,76 @@ public Number getSpecificValue(String dim, String... path)
throws
[
https://issues.apache.org/jira/browse/LUCENE-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555722#comment-17555722
]
ASF subversion and git services commented on LUCENE-10603:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555714#comment-17555714
]
ASF subversion and git services commented on LUCENE-10603:
--
Co
gsmiller commented on PR #954:
URL: https://github.com/apache/lucene/pull/954#issuecomment-1159099868
@jpountz no problem. I wasn't in any rush with this, and since you'd had a
look, I just wanted to make sure you didn't have additional feedback. Thanks!
--
This is an automated message fr
gsmiller merged PR #954:
URL: https://github.com/apache/lucene/pull/954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache
gsmiller commented on code in PR #922:
URL: https://github.com/apache/lucene/pull/922#discussion_r900382196
##
lucene/CHANGES.txt:
##
@@ -67,6 +67,8 @@ Other
* LUCENE-10493: Factor out Viterbi algorithm in Kuromoji and Nori to
analysis-common. (Tomoko Uchida)
+* GITHUB#922
gsmiller commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1159091616
@shaie
> I struggled back-and-forth between introducing a public final long[]
comparableLongs on the abstract FacetSet to the getComparableLongs() method.
+1 to the approach you w
[
https://issues.apache.org/jira/browse/LUCENE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555683#comment-17555683
]
Adrien Grand commented on LUCENE-8806:
--
Sorry [~denimorim] I'm not getting your que
[
https://issues.apache.org/jira/browse/LUCENE-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555673#comment-17555673
]
ASF subversion and git services commented on LUCENE-10078:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555672#comment-17555672
]
ASF subversion and git services commented on LUCENE-10078:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10617.
---
Fix Version/s: 9.3
Resolution: Fixed
This one looks addressed.
> Investigate recent
javanna commented on PR #959:
URL: https://github.com/apache/lucene/pull/959#issuecomment-1159003847
thanks all for the feedback. Please keep me in the loop if you see things go
wrong with this change, I am happy to make further adjustments.
--
This is an automated message from the Apache
jpountz merged PR #959:
URL: https://github.com/apache/lucene/pull/959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.
jpountz commented on PR #959:
URL: https://github.com/apache/lucene/pull/959#issuecomment-1158980744
> The one thing I think (?) can change is the estimated total hit count if
BMW kicked in. That can change even if you search the same segments, serially,
but in a different order, I think.
jpountz commented on PR #907:
URL: https://github.com/apache/lucene/pull/907#issuecomment-1158977379
Thanks @shahrs87, could you now try to remove all instances of `if (terms ==
Terms.EMPTY)`? Hopefully existing logic should work with Terms instances
regardless of whether they are empty or
[
https://issues.apache.org/jira/browse/LUCENE-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555646#comment-17555646
]
Adrien Grand commented on LUCENE-10619:
---
This looks like an interesting idea!
>
jpountz commented on code in PR #965:
URL: https://github.com/apache/lucene/pull/965#discussion_r900181624
##
lucene/CHANGES.txt:
##
@@ -86,6 +86,8 @@ Improvements
* LUCENE-10585: Facet module code cleanup (copy/paste scrubbing,
simplification and some very minor
optimizati
jpountz commented on PR #730:
URL: https://github.com/apache/lucene/pull/730#issuecomment-1158932157
I worry that such a change would be adding little overhead all the time only
to help in some rare cases, it's not clear to me that it would be a good
trade-off. I'd be interested in more dat
jpountz commented on PR #964:
URL: https://github.com/apache/lucene/pull/964#issuecomment-1158911923
Thanks for looking @romseygeek. To make sure this new API would effectively
have more than one use-case, I migrated `TopScoreDocCollector` and
`TopFieldCollector` to it too. The immediate be
[
https://issues.apache.org/jira/browse/LUCENE-10583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1789#comment-1789
]
Thomas Hoffmann commented on LUCENE-10583:
--
Hello Vigya,
adding the warning t
ldkjdk commented on PR #730:
URL: https://github.com/apache/lucene/pull/730#issuecomment-1158691084
yes, for a search case
BooleanQuery.Builder bQuery = new BooleanQuery.Builder();
TermQuery contents= new TermQuery(new Term("contents", "hello"));
bQuery.add(contents, BooleanClaus
36 matches
Mail list logo
