Yuti-G commented on PR #914: URL: https://github.com/apache/lucene/pull/914#issuecomment-1159161102
Thanks @gsmiller for spending time reviewing my PR and leaving the great feedback! I addressed all of the comments except for the one that requires casting `List<Integer>` to `int[]` for `ordinals` to call `getBulkPath` in the IntTaxonomy and FloatTaxonomy. Please let me know if there is a better way to do it. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
