dweiss commented on PR #817:
URL: https://github.com/apache/lucene/pull/817#issuecomment-1104721448
Please feel free to merge - I'll provide a patch for spotless and then we
can clean it up, once upgrading.
--
This is an automated message from the Apache Git Service.
To respond to the mes
dweiss commented on PR #817:
URL: https://github.com/apache/lucene/pull/817#issuecomment-1104720998
Yeah - the docs are riddled with these examples. I found it quite
astonishing that they've deprecated such an important bit of functionality (not
just this method but any build callback hooks
wjp719 commented on PR #786:
URL: https://github.com/apache/lucene/pull/786#issuecomment-1104631511
@rmuir @jpountz Hi, this pr is ready to be merged, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
[
https://issues.apache.org/jira/browse/LUCENE-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani updated LUCENE-10527:
--
Attachment: (was: hnsw_plot.png)
> Use bigger maxConn for last layer in HNSW
> --
[
https://issues.apache.org/jira/browse/LUCENE-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani updated LUCENE-10527:
--
Description:
Recently I was rereading the HNSW paper
([https://arxiv.org/pdf/1603.09
[
https://issues.apache.org/jira/browse/LUCENE-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani updated LUCENE-10527:
--
Description:
Recently I was rereading the HNSW paper
([https://arxiv.org/pdf/1603.09
Yuti-G commented on PR #778:
URL: https://github.com/apache/lucene/pull/778#issuecomment-1104512792
Thanks @zhaih !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
Julie Tibshirani created LUCENE-10527:
-
Summary: Use bigger maxConn for last layer in HNSW
Key: LUCENE-10527
URL: https://issues.apache.org/jira/browse/LUCENE-10527
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525315#comment-17525315
]
ASF subversion and git services commented on LUCENE-10495:
--
Co
zhaih merged PR #825:
URL: https://github.com/apache/lucene/pull/825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.or
mayya-sharipova commented on PR #792:
URL: https://github.com/apache/lucene/pull/792#issuecomment-1104454465
@LuXugang Thank you for your extra test results. It seems to me that 100k
documents is rather small data set, we usually run a test on a dataset of 1M
docs (which could be more usefu
[
https://issues.apache.org/jira/browse/LUCENE-10526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-10526.
--
Fix Version/s: 9.2
Resolution: Fixed
> add single method to mockfile to wrap a Path
>
[
https://issues.apache.org/jira/browse/LUCENE-10526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525281#comment-17525281
]
ASF subversion and git services commented on LUCENE-10526:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525275#comment-17525275
]
ASF subversion and git services commented on LUCENE-10526:
--
Co
rmuir merged PR #822:
URL: https://github.com/apache/lucene/pull/822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.or
rmuir commented on PR #822:
URL: https://github.com/apache/lucene/pull/822#issuecomment-1104430915
Thanks for reviewing, and good luck improving the act-like-Windows!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
mayya-sharipova commented on code in PR #792:
URL: https://github.com/apache/lucene/pull/792#discussion_r854526400
##
lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsWriter.java:
##
@@ -207,15 +210,41 @@ private void writeMeta(
// write docIDs
rmuir commented on PR #817:
URL: https://github.com/apache/lucene/pull/817#issuecomment-1104420132
> I also discovered that afterTask is deprecated and scheduled to be removed
in the future - something to be aware of.
Perhaps when they update their example in the documentation, then I
Yuti-G opened a new pull request, #825:
URL: https://github.com/apache/lucene/pull/825
Backport of #778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
[
https://issues.apache.org/jira/browse/LUCENE-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525247#comment-17525247
]
ASF subversion and git services commented on LUCENE-10495:
--
Co
zhaih merged PR #778:
URL: https://github.com/apache/lucene/pull/778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.or
[
https://issues.apache.org/jira/browse/LUCENE-8580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525244#comment-17525244
]
Vigya Sharma commented on LUCENE-8580:
--
I'm thinking of tackling this one data stru
rmuir commented on PR #822:
URL: https://github.com/apache/lucene/pull/822#issuecomment-1104369976
@gautamworah96 care to take another look? I think fixing the tiny nit was
helpful to our tests. now it is easier for tests to wrap a path with one of
these mock filesystems explicitly, as they
[
https://issues.apache.org/jira/browse/LUCENE-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525214#comment-17525214
]
Gautam Worah commented on LUCENE-10524:
---
I have a slight personal preference towa
rmuir commented on code in PR #822:
URL: https://github.com/apache/lucene/pull/822#discussion_r854435033
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/FilterFileSystemProvider.java:
##
@@ -116,7 +116,11 @@ public Path getPath(URI uri) {
if (fileSystem =
dweiss commented on PR #817:
URL: https://github.com/apache/lucene/pull/817#issuecomment-1104245803
This is what the patched output looks like, btw.
--
This is an automated
gautamworah96 commented on code in PR #822:
URL: https://github.com/apache/lucene/pull/822#discussion_r854391999
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/FilterFileSystemProvider.java:
##
@@ -116,7 +116,11 @@ public Path getPath(URI uri) {
if (file
dweiss commented on PR #817:
URL: https://github.com/apache/lucene/pull/817#issuecomment-1104244458
[spotless-msg.txt](https://github.com/apache/lucene/files/8523965/spotless-msg.txt)
This patch implements the idea I mentioned - create an additional build
failure/ message if any of t
dweiss commented on PR #817:
URL: https://github.com/apache/lucene/pull/817#issuecomment-1104169873
I created an issue in spotless to perhaps customize the message right where
it's emitted - in the SpotlessCheck task. diffplug/spotless#1175
--
This is an automated message from the Apache
dweiss commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1104097188
Yeah - I think we should do it as a separate issue. It'll be clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
rmuir commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1104096183
i'm fine with starting the properties file here, but the problem is not
exactly new. really fixing all the stuff like smoketester, eclipse linter
config, etc etc is gonna be some amount of wor
dweiss commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1104092938
There's the emitted message there - I've just pushed a commit to your branch
that does the same thing as the bash does. I think it's fine. We can probably
add a test to check whether those sc
rmuir commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1104092136
OK now there is ... but you created the monster :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rmuir commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1104088255
There's no version numbers in the .bat script. Hence no need for it to be
able to suck in .properties file?
--
This is an automated message from the Apache Git Service.
To respond to the mes
dweiss commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1104081213
I'll take a look if I can modify the windows scripts the same way - it
should be doable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
dweiss commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1104077352
Maybe I misunderstood something - this comment:
> and it could be read from this bash script with source
I don't think you can do fancy stuff like this from cmd. Maybe from
power
jpountz merged PR #823:
URL: https://github.com/apache/lucene/pull/823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.
nknize commented on code in PR #809:
URL: https://github.com/apache/lucene/pull/809#discussion_r854258259
##
lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java:
##
@@ -257,10 +257,13 @@ public WithinRelation withinLine(
boolean ab,
double bX,
double b
rmuir merged PR #818:
URL: https://github.com/apache/lucene/pull/818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.or
[
https://issues.apache.org/jira/browse/LUCENE-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-10054:
--
Labels: vector-based-search (was: )
> Handle hierarchy in HNSW graph
> -
[
https://issues.apache.org/jira/browse/LUCENE-10183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-10183:
--
Labels: vector-based-search (was: )
> KnnVectorsWriter#writeField should tak
[
https://issues.apache.org/jira/browse/LUCENE-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-10309:
--
Labels: vector-based-search (was: )
> Minimum KnnVector codec support in Luk
[
https://issues.apache.org/jira/browse/LUCENE-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-10351:
--
Labels: vector-based-search (was: )
> Correct knn search failure with all d
[
https://issues.apache.org/jira/browse/LUCENE-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-10375:
--
Labels: vector-based-search (was: )
> Speed up HNSW merge by writing combine
[
https://issues.apache.org/jira/browse/LUCENE-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-10382:
--
Labels: vector-based-search (was: )
> Allow KnnVectorQuery to operate over a
[
https://issues.apache.org/jira/browse/LUCENE-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-10391:
--
Labels: vector-based-search (was: )
> Reuse data structures across HnswGraph
[
https://issues.apache.org/jira/browse/LUCENE-10408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-10408:
--
Labels: vector-based-search (was: )
> Better dense encoding of doc Ids in Lu
[
https://issues.apache.org/jira/browse/LUCENE-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-10421:
--
Labels: vector-based-search (was: )
> Non-deterministic results from KnnVect
[
https://issues.apache.org/jira/browse/LUCENE-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-10453:
--
Labels: vector-based-search (was: )
> Speed up VectorUtil#squareDistance
> -
[
https://issues.apache.org/jira/browse/LUCENE-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525043#comment-17525043
]
ASF subversion and git services commented on LUCENE-10153:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525044#comment-17525044
]
ASF subversion and git services commented on LUCENE-10153:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-9322:
-
Labels: vector-based-search (was: )
> Discussing a unified vectors format API
>
[
https://issues.apache.org/jira/browse/LUCENE-9837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-9837:
-
Labels: vector-based-search (was: )
> try to improve performance of VectorUtil.
rmuir commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1104016177
> Windows will be a problem, as it always is, argh.
why is windows a problem? this PR works perfectly fine on windows. I didnt
touch the .bat file because, unlike the .sh file, it has no
[
https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-9855:
-
Labels: vector-based-search (was: )
> Reconsider names for ANN related format a
[
https://issues.apache.org/jira/browse/LUCENE-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-9905:
-
Labels: vector-based-search (was: )
> Revise approach to specifying NN algorith
[
https://issues.apache.org/jira/browse/LUCENE-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-9908:
-
Labels: vector-based-search (was: )
> Move VectorValues#search to VectorReader
[
https://issues.apache.org/jira/browse/LUCENE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-10016:
--
Labels: vector-based-search (was: )
> VectorReader.search needs rethought, o
[
https://issues.apache.org/jira/browse/LUCENE-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-10015:
--
Labels: vector-based-search (was: )
> Remove VectorValues.SimilarityFunction
[
https://issues.apache.org/jira/browse/LUCENE-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-10040:
--
Labels: vector-based-search (was: )
> Handle deletions in nearest vector sea
dweiss commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1104010860
Windows will be a problem, as it always is, argh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-10063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-10063:
--
Labels: vector-based-search (was: )
> SimpleTextKnnVectorsReader.search need
[
https://issues.apache.org/jira/browse/LUCENE-10142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-10142:
--
Labels: vector-based-search (was: )
> use a better RNG for Hnsw vectors
> --
iverase commented on PR #809:
URL: https://github.com/apache/lucene/pull/809#issuecomment-1104008701
Thanks for the review @nknize!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
[
https://issues.apache.org/jira/browse/LUCENE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-10130:
--
Labels: vector-based-search (was: )
> HnswGraph could make use of a SparseFi
[
https://issues.apache.org/jira/browse/LUCENE-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-10146:
--
Labels: vector-based-search (was: )
> Add VectorSimilarityFunction.COSINE
>
[
https://issues.apache.org/jira/browse/LUCENE-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera resolved LUCENE-10514.
---
Fix Version/s: 9.2
Assignee: Ignacio Vera
Resolution: Fixed
> Some Componen
[
https://issues.apache.org/jira/browse/LUCENE-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525032#comment-17525032
]
ASF subversion and git services commented on LUCENE-10514:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-10178:
--
Labels: vector-based-search (was: )
> Add toString for inspecting Lucene90Hn
[
https://issues.apache.org/jira/browse/LUCENE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-9004:
-
Labels: vector-based-search (was: )
> Approximate nearest vector search
> -
[
https://issues.apache.org/jira/browse/LUCENE-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated LUCENE-10228:
--
Labels: vector-based-search (was: )
> PerFieldKnnVectorsFormat can write to
[
https://issues.apache.org/jira/browse/LUCENE-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525029#comment-17525029
]
ASF subversion and git services commented on LUCENE-10514:
--
Co
iverase merged PR #809:
URL: https://github.com/apache/lucene/pull/809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.
iverase commented on code in PR #809:
URL: https://github.com/apache/lucene/pull/809#discussion_r854207988
##
lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java:
##
@@ -257,10 +257,13 @@ public WithinRelation withinLine(
boolean ab,
double bX,
double
nknize commented on code in PR #809:
URL: https://github.com/apache/lucene/pull/809#discussion_r854196239
##
lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java:
##
@@ -257,10 +257,13 @@ public WithinRelation withinLine(
boolean ab,
double bX,
double b
iverase opened a new pull request, #824:
URL: https://github.com/apache/lucene/pull/824
In https://github.com/apache/lucene/pull/804 we fixes some edge cases when
building rectangles where min longitude and max longitude were very close
together. This introduced now problems when the min/ma
iverase commented on code in PR #809:
URL: https://github.com/apache/lucene/pull/809#discussion_r854187793
##
lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java:
##
@@ -257,10 +257,13 @@ public WithinRelation withinLine(
boolean ab,
double bX,
double
nknize commented on code in PR #809:
URL: https://github.com/apache/lucene/pull/809#discussion_r854177310
##
lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java:
##
@@ -257,10 +257,13 @@ public WithinRelation withinLine(
boolean ab,
double bX,
double b
rmuir commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1103914462
> +1 to a single source of source/target Java version(s). A simple key-value
format may be easily used from the outside world of java/gradle - github
actions scripts or the smoke tester, and s
iverase commented on PR #809:
URL: https://github.com/apache/lucene/pull/809#issuecomment-1103866748
I run the performance test and no significant change on performance:
```
Index time (sec)||Force merge time (sec)||Index size (GB)||Reader heap (MB)||
||Dev||Base||Diff ||Dev ||B
iverase commented on code in PR #809:
URL: https://github.com/apache/lucene/pull/809#discussion_r854066472
##
lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java:
##
@@ -257,10 +257,13 @@ public WithinRelation withinLine(
boolean ab,
double bX,
double
[
https://issues.apache.org/jira/browse/LUCENE-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524856#comment-17524856
]
Adrien Grand commented on LUCENE-10421:
---
Query latency of vector queries became m
82 matches
Mail list logo
