spike-liu edited a comment on pull request #681:
URL: https://github.com/apache/lucene/pull/681#issuecomment-1041211089
> why do we have to make all these internal classes public to do this? I
don't think this is a good tradeoff.
Thanks for your review, Robert. Just like Dawid mentio
spike-liu commented on a change in pull request #681:
URL: https://github.com/apache/lucene/pull/681#discussion_r807641222
##
File path: gradle/java/javac.gradle
##
@@ -52,12 +51,12 @@ allprojects {
"-Xlint:overrides",
// TODO: some tests seem to have bad clas
spike-liu commented on pull request #681:
URL: https://github.com/apache/lucene/pull/681#issuecomment-1041211089
> why do we have to make all these internal classes public to do this? I
don't think this is a good tradeoff.
Thanks for your review, Robert. Just like David mentioned, si
mayya-sharipova commented on a change in pull request #656:
URL: https://github.com/apache/lucene/pull/656#discussion_r807638868
##
File path: build.gradle
##
@@ -183,3 +183,5 @@ apply from: file('gradle/hacks/turbocharge-jvm-opts.gradle')
apply from: file('gradle/hacks/dummy-
[
https://issues.apache.org/jira/browse/LUCENE-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493037#comment-17493037
]
ASF subversion and git services commented on LUCENE-10378:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera reassigned LUCENE-10378:
-
Assignee: (was: Ignacio Vera)
> Implement Weight#count on PointRangeQuery
> --
[
https://issues.apache.org/jira/browse/LUCENE-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera reassigned LUCENE-10378:
-
Assignee: Ignacio Vera
> Implement Weight#count on PointRangeQuery
> -
[
https://issues.apache.org/jira/browse/LUCENE-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera resolved LUCENE-10378.
---
Fix Version/s: 9.1
Assignee: Ignacio Vera
Resolution: Fixed
> Implement Wei
iverase merged pull request #684:
URL: https://github.com/apache/lucene/pull/684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
gautamworah96 edited a comment on pull request #658:
URL: https://github.com/apache/lucene/pull/658#issuecomment-1041175108
@iverase I see you already opened a backport PR. Thanks! I'll approve that
as well
--
This is an automated message from the Apache Git Service.
To respond to the me
gautamworah96 commented on pull request #658:
URL: https://github.com/apache/lucene/pull/658#issuecomment-1041175108
I see you already opened a backport PR. Thanks! I'll approve that as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
iverase opened a new pull request #684:
URL: https://github.com/apache/lucene/pull/684
Implement Weight#count on PointRangeQuery. Also fixed a small style
inconsistency that I noticed
Issue: https://issues.apache.org/jira/browse/LUCENE-10378
--
This is an automated message from th
[
https://issues.apache.org/jira/browse/LUCENE-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493021#comment-17493021
]
ASF subversion and git services commented on LUCENE-10378:
--
Co
iverase merged pull request #658:
URL: https://github.com/apache/lucene/pull/658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
spike-liu commented on a change in pull request #678:
URL: https://github.com/apache/lucene/pull/678#discussion_r807570862
##
File path: lucene/core/src/java/org/apache/lucene/index/Terms.java
##
@@ -124,6 +124,69 @@ protected BytesRef nextSeekTerm(BytesRef term) throws
IOExce
spike-liu commented on a change in pull request #678:
URL: https://github.com/apache/lucene/pull/678#discussion_r807563855
##
File path: lucene/core/src/java/org/apache/lucene/index/Terms.java
##
@@ -124,6 +124,69 @@ protected BytesRef nextSeekTerm(BytesRef term) throws
IOExce
spike-liu commented on a change in pull request #678:
URL: https://github.com/apache/lucene/pull/678#discussion_r807561536
##
File path: lucene/core/src/java/org/apache/lucene/search/TermInSetQuery.java
##
@@ -244,8 +244,8 @@ public Weight createWeight(IndexSearcher searcher,
spike-liu commented on a change in pull request #678:
URL: https://github.com/apache/lucene/pull/678#discussion_r807561320
##
File path:
lucene/queries/src/java/org/apache/lucene/queries/function/IndexReaderFunctions.java
##
@@ -212,10 +212,10 @@ private TermFreqDoubleValuesSo
spike-liu commented on a change in pull request #678:
URL: https://github.com/apache/lucene/pull/678#discussion_r807561090
##
File path: lucene/core/src/java/org/apache/lucene/document/FeatureQuery.java
##
@@ -111,12 +111,9 @@ public Explanation explain(LeafReaderContext contex
spike-liu commented on a change in pull request #678:
URL: https://github.com/apache/lucene/pull/678#discussion_r807560361
##
File path: lucene/core/src/java/org/apache/lucene/index/Terms.java
##
@@ -124,6 +124,69 @@ protected BytesRef nextSeekTerm(BytesRef term) throws
IOExce
madrob opened a new pull request #2641:
URL: https://github.com/apache/lucene-solr/pull/2641
Internode communication secured by PKI Authentication has changed formats.
Difference from 9x is that on 8x we will still default to send v1 and accept
v1,v2
--
This is an automated messag
jtibshirani commented on pull request #656:
URL: https://github.com/apache/lucene/pull/656#issuecomment-1040900652
Thanks for the review! I'll wait for the others to take a look too. I'm
working on adding kNN with filtering to luceneutil.
--
This is an automated message from the Apache G
jtibshirani commented on a change in pull request #656:
URL: https://github.com/apache/lucene/pull/656#discussion_r807399758
##
File path: lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsReader.java
##
@@ -58,6 +60,12 @@ protected KnnVectorsReader() {}
* true k clos
[
https://issues.apache.org/jira/browse/LUCENE-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492890#comment-17492890
]
Greg Miller commented on LUCENE-10398:
--
OK, after looking over the PR, I'm back to
gsmiller commented on a change in pull request #678:
URL: https://github.com/apache/lucene/pull/678#discussion_r807375030
##
File path: lucene/core/src/java/org/apache/lucene/index/Terms.java
##
@@ -124,6 +124,69 @@ protected BytesRef nextSeekTerm(BytesRef term) throws
IOExcep
[
https://issues.apache.org/jira/browse/LUCENE-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492885#comment-17492885
]
Julie Tibshirani commented on LUCENE-10391:
---
I've been keeping an eye on nigh
[
https://issues.apache.org/jira/browse/LUCENE-10371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Zhai resolved LUCENE-10371.
---
Resolution: Fixed
> Make IndexRearranger able to arrange segment into a determined order
>
zhaih merged pull request #683:
URL: https://github.com/apache/lucene/pull/683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
[
https://issues.apache.org/jira/browse/LUCENE-10371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492881#comment-17492881
]
ASF subversion and git services commented on LUCENE-10371:
--
Co
gsmiller commented on a change in pull request #678:
URL: https://github.com/apache/lucene/pull/678#discussion_r807228024
##
File path: lucene/core/src/java/org/apache/lucene/index/Terms.java
##
@@ -124,6 +124,69 @@ protected BytesRef nextSeekTerm(BytesRef term) throws
IOExcep
jtibshirani commented on a change in pull request #677:
URL: https://github.com/apache/lucene/pull/677#discussion_r807297322
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestDocValuesFieldExistsQuery.java
##
@@ -38,6 +39,100 @@
public class TestDocValuesField
dantuzi closed pull request #682:
URL: https://github.com/apache/lucene/pull/682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
msokolov commented on a change in pull request #656:
URL: https://github.com/apache/lucene/pull/656#discussion_r806991813
##
File path: lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java
##
@@ -70,18 +121,125 @@ public Query rewrite(IndexReader reader) throws
IO
zhaih opened a new pull request #683:
URL: https://github.com/apache/lucene/pull/683
Backporting #630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
iverase commented on pull request #658:
URL: https://github.com/apache/lucene/pull/658#issuecomment-1040625361
I will push this tomorrow if it is ok with you @gautamworah96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
gautamworah96 commented on pull request #658:
URL: https://github.com/apache/lucene/pull/658#issuecomment-1040653243
Yes. I was wondering why you had kept it open :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
zhaih merged pull request #630:
URL: https://github.com/apache/lucene/pull/630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
dweiss commented on pull request #681:
URL: https://github.com/apache/lucene/pull/681#issuecomment-1040099139
I would leave -Xlint:exports entirely out of the patch - this is not easily
fixable; the module API is broken in that it exposes types that are not public
but making them public is
uschindler commented on pull request #173:
URL: https://github.com/apache/lucene/pull/173#issuecomment-1039342764
This PR is no longer maintained!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dweiss commented on a change in pull request #681:
URL: https://github.com/apache/lucene/pull/681#discussion_r806675876
##
File path: gradle/java/javac.gradle
##
@@ -52,12 +51,12 @@ allprojects {
"-Xlint:overrides",
// TODO: some tests seem to have bad classpa
rmuir commented on pull request #681:
URL: https://github.com/apache/lucene/pull/681#issuecomment-1040079874
why do we have to make all these internal classes public to do this? I don't
think this is a good tradeoff.
--
This is an automated message from the Apache Git Service.
To respond
jtibshirani commented on pull request #656:
URL: https://github.com/apache/lucene/pull/656#issuecomment-1039714498
@msokolov @jpountz @mayya-sharipova this is ready for another look. Notable
changes:
* When computing the filter results, only include documents that actually
contain a vec
uschindler commented on pull request #673:
URL: https://github.com/apache/lucene/pull/673#issuecomment-1039214098
Followup PR: #680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/LUCENE-10371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492814#comment-17492814
]
ASF subversion and git services commented on LUCENE-10371:
--
Co
romseygeek commented on a change in pull request #679:
URL: https://github.com/apache/lucene/pull/679#discussion_r806633322
##
File path:
lucene/monitor/src/java/org/apache/lucene/monitor/MonitorConfiguration.java
##
@@ -35,8 +34,9 @@
private long purgeFrequency = 5;
pri
[
https://issues.apache.org/jira/browse/LUCENE-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492803#comment-17492803
]
Greg Miller commented on LUCENE-10398:
--
Just noticed there's a PR already for this
jtibshirani commented on a change in pull request #649:
URL: https://github.com/apache/lucene/pull/649#discussion_r806160008
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsWriter.java
##
@@ -206,14 +203,22 @@ private void writeMeta(
uschindler closed pull request #173:
URL: https://github.com/apache/lucene/pull/173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
mogui commented on a change in pull request #679:
URL: https://github.com/apache/lucene/pull/679#discussion_r806709538
##
File path: lucene/monitor/src/java/org/apache/lucene/monitor/QueryIndex.java
##
@@ -87,8 +81,20 @@
final Map termFilters = new
HashMap<>();
QueryIn
uschindler merged pull request #680:
URL: https://github.com/apache/lucene/pull/680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
iverase commented on pull request #658:
URL: https://github.com/apache/lucene/pull/658#issuecomment-1040625361
I will push this tomorrow if it is ok with you @gautamworah96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
[
https://issues.apache.org/jira/browse/LUCENE-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492755#comment-17492755
]
Greg Miller commented on LUCENE-10398:
--
Ok great [~spike.liu]! As I thought about
mogui commented on a change in pull request #679:
URL: https://github.com/apache/lucene/pull/679#discussion_r807105140
##
File path: lucene/monitor/src/java/org/apache/lucene/monitor/QueryIndex.java
##
@@ -87,8 +81,20 @@
final Map termFilters = new
HashMap<>();
QueryIn
mogui commented on a change in pull request #679:
URL: https://github.com/apache/lucene/pull/679#discussion_r807030169
##
File path: lucene/monitor/src/java/org/apache/lucene/monitor/QueryIndex.java
##
@@ -87,8 +81,20 @@
final Map termFilters = new
HashMap<>();
QueryIn
mogui commented on a change in pull request #679:
URL: https://github.com/apache/lucene/pull/679#discussion_r807030169
##
File path: lucene/monitor/src/java/org/apache/lucene/monitor/QueryIndex.java
##
@@ -87,8 +81,20 @@
final Map termFilters = new
HashMap<>();
QueryIn
msokolov commented on a change in pull request #656:
URL: https://github.com/apache/lucene/pull/656#discussion_r806991813
##
File path: lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java
##
@@ -70,18 +121,125 @@ public Query rewrite(IndexReader reader) throws
IO
dantuzi closed pull request #682:
URL: https://github.com/apache/lucene/pull/682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
dantuzi opened a new pull request #682:
URL: https://github.com/apache/lucene/pull/682
Fake pull request created to test the action
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
mogui commented on a change in pull request #679:
URL: https://github.com/apache/lucene/pull/679#discussion_r806723684
##
File path: lucene/monitor/src/java/org/apache/lucene/monitor/QueryIndex.java
##
@@ -87,8 +81,20 @@
final Map termFilters = new
HashMap<>();
QueryIn
romseygeek commented on a change in pull request #679:
URL: https://github.com/apache/lucene/pull/679#discussion_r806711683
##
File path: lucene/monitor/src/java/org/apache/lucene/monitor/QueryIndex.java
##
@@ -87,8 +81,20 @@
final Map termFilters = new
HashMap<>();
Qu
mogui commented on a change in pull request #679:
URL: https://github.com/apache/lucene/pull/679#discussion_r806709538
##
File path: lucene/monitor/src/java/org/apache/lucene/monitor/QueryIndex.java
##
@@ -87,8 +81,20 @@
final Map termFilters = new
HashMap<>();
QueryIn
romseygeek commented on a change in pull request #679:
URL: https://github.com/apache/lucene/pull/679#discussion_r806633322
##
File path:
lucene/monitor/src/java/org/apache/lucene/monitor/MonitorConfiguration.java
##
@@ -35,8 +34,9 @@
private long purgeFrequency = 5;
pri
dweiss commented on a change in pull request #681:
URL: https://github.com/apache/lucene/pull/681#discussion_r806675876
##
File path: gradle/java/javac.gradle
##
@@ -52,12 +51,12 @@ allprojects {
"-Xlint:overrides",
// TODO: some tests seem to have bad classpa
dweiss commented on pull request #681:
URL: https://github.com/apache/lucene/pull/681#issuecomment-1040099139
I would leave -Xlint:exports entirely out of the patch - this is not easily
fixable; the module API is broken in that it exposes types that are not public
but making them public is
[
https://issues.apache.org/jira/browse/LUCENE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492499#comment-17492499
]
Dawid Weiss commented on LUCENE-10322:
--
Please do, if you like. I don't know how c
rmuir commented on pull request #681:
URL: https://github.com/apache/lucene/pull/681#issuecomment-1040079874
why do we have to make all these internal classes public to do this? I don't
think this is a good tradeoff.
--
This is an automated message from the Apache Git Service.
To respond
spike-liu opened a new pull request #681:
URL: https://github.com/apache/lucene/pull/681
https://issues.apache.org/jira/browse/LUCENE-10322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
[
https://issues.apache.org/jira/browse/LUCENE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492453#comment-17492453
]
spike liu commented on LUCENE-10322:
I would like to take care of this.
> Enable -
68 matches
Mail list logo
