romseygeek commented on a change in pull request #679:
URL: https://github.com/apache/lucene/pull/679#discussion_r806711683
##########
File path: lucene/monitor/src/java/org/apache/lucene/monitor/QueryIndex.java
##########
@@ -87,8 +81,20 @@
final Map<IndexReader.CacheKey, QueryTermFilter> termFilters = new
HashMap<>();
QueryIndex(MonitorConfiguration config, Presearcher presearcher) throws
IOException {
Review comment:
> Keeping the readonly flag in MonitorConfiguration and instantiating
the correct on in Monitor, should be enough?
I think so. Maybe add it as a second parameter to `setDirectoryProvider` as
it only really makes sense in combination with a custom Directory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]