[GitHub] [lucene] spike-liu commented on pull request #681: LUCENE-10322: Enable -Xlint:path and -Xlint:-exports

[GitBox]

spike-liu commented on pull request #681:
URL: https://github.com/apache/lucene/pull/681#issuecomment-1041211089


   > why do we have to make all these internal classes public to do this? I 
don't think this is a good tradeoff.
   
   Thanks for your review, Robert. Just like David mentioned, simply making 
them public is really not a good solution.  + 1 example for your reference:
   
   - `public class ByteBufferIndexInput` uses `private class ByteBufferGuard` 
as a parameter of method;
   <img width="472" alt="image" 
src="https://user-images.githubusercontent.com/9884987/154220157-d4f664d0-6f67-4809-8c38-3633aa073b31.png";>
   
   - `org.apache.lucene.search.suggest.document.NRTSuggester` uses 
`ByteBufferIndexInput` like below:
   
   <img width="891" alt="image" 
src="https://user-images.githubusercontent.com/9884987/154218470-77e7fb39-dddb-4987-8a85-68887bb43987.png";>
   
   Hence it violates the existing rule of java module system, which seems a bit 
hard to comply in our case right now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org