spike-liu commented on a change in pull request #678: URL: https://github.com/apache/lucene/pull/678#discussion_r807561536
########## File path: lucene/core/src/java/org/apache/lucene/search/TermInSetQuery.java ########## @@ -244,8 +244,8 @@ public Weight createWeight(IndexSearcher searcher, ScoreMode scoreMode, float bo @Override public Matches matches(LeafReaderContext context, int doc) throws IOException { - Terms terms = context.reader().terms(field); - if (terms == null || terms.hasPositions() == false) { + Terms terms = Terms.terms(context.reader(), field); + if (!terms.hasPositions()) { Review comment: fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org