uschindler commented on pull request #487:
URL: https://github.com/apache/lucene/pull/487#issuecomment-982373860
> I don't think we want to repeat the manual tests for the luke start
scripts every release or receive bug reports from users right after publishing
the artifacts. If we need th
zacharymorn commented on a change in pull request #456:
URL: https://github.com/apache/lucene/pull/456#discussion_r759008594
##
File path: lucene/CHANGES.txt
##
@@ -57,7 +57,9 @@ Optimizations
Bug Fixes
-
-(No changes)
+
+* LUCENE-10236: Update field-wei
zacharymorn commented on a change in pull request #418:
URL: https://github.com/apache/lucene/pull/418#discussion_r759006970
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java
##
@@ -441,6 +491,273 @@ public boolean isCacheable(LeafR
dweiss commented on pull request #487:
URL: https://github.com/apache/lucene/pull/487#issuecomment-982361203
@uschindler Let me know when you think it's ready and I'll merge/ backport.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dweiss commented on pull request #487:
URL: https://github.com/apache/lucene/pull/487#issuecomment-982360434
> I'd like to seek a way to integrate a sanity check for it into our smoke
test or CI.
I know how to do it - I am doing it elsewhere. I just need to get to this
part. Track t
dweiss commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758999719
##
File path: gradle/java/jar-manifest.gradle
##
@@ -78,4 +87,30 @@ subprojects {
})
}
}
-}
\ No newline at end of file
+}
+
+c
mocobeta commented on pull request #487:
URL: https://github.com/apache/lucene/pull/487#issuecomment-982356054
> the powershell scripts have much stricter isolation/ security checks and
they would have to be signed. I'm not sure how this works but my experience on
github actions infrastruc
uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758994113
##
File path: gradle/java/jar-manifest.gradle
##
@@ -78,4 +87,30 @@ subprojects {
})
}
}
-}
\ No newline at end of file
+}
dweiss commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758973336
##
File path: gradle/java/jar-manifest.gradle
##
@@ -78,4 +87,30 @@ subprojects {
})
}
}
-}
\ No newline at end of file
+}
+
+c
dweiss commented on pull request #487:
URL: https://github.com/apache/lucene/pull/487#issuecomment-982330410
@mocobeta the powershell scripts have much stricter isolation/ security
checks and they would have to be signed. I'm not sure how this works but my
experience on github actions infr
mocobeta edited a comment on pull request #487:
URL: https://github.com/apache/lucene/pull/487#issuecomment-982256615
I checked `luke.sh` and `luke.cmd` works for me, just in case.
+1.
From my experiences, launch scripts are the ones of the most fragile and
often overlooked parts
mocobeta edited a comment on pull request #487:
URL: https://github.com/apache/lucene/pull/487#issuecomment-982256615
I checked `luke.sh` and `luke.cmd` works for me, just in case.
+1.
From my experiences, launch scripts are the ones of the most fragile and
often overlooked parts
mocobeta commented on pull request #487:
URL: https://github.com/apache/lucene/pull/487#issuecomment-982256615
I checked `luke.sh` and `luke.bat` works for me, just in case.
+1.
From my experiences, launch scripts are the ones of the most fragile and
often overlooked parts in soft
[
https://issues.apache.org/jira/browse/LUCENE-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller resolved LUCENE-10258.
--
Resolution: Won't Fix
> DoubleValuesSource#fromScorer() should leverage ScoreCachingWrappingS
[
https://issues.apache.org/jira/browse/LUCENE-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450833#comment-17450833
]
Greg Miller commented on LUCENE-10258:
--
I added a small javadoc comment as a resul
[
https://issues.apache.org/jira/browse/LUCENE-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450834#comment-17450834
]
ASF subversion and git services commented on LUCENE-10258:
--
Co
gsmiller merged pull request #492:
URL: https://github.com/apache/lucene/pull/492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
[
https://issues.apache.org/jira/browse/LUCENE-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450807#comment-17450807
]
ASF subversion and git services commented on LUCENE-10258:
--
Co
gsmiller merged pull request #490:
URL: https://github.com/apache/lucene/pull/490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
rmuir opened a new pull request #491:
URL: https://github.com/apache/lucene/pull/491
The idea here is to do an 80/20 pass on MIGRATE.md to make it more readable,
searchable, less ambiguous.
* Separate sections for 9.0 and 9.1
* Remove abbreviations for artifact, package, class nam
[
https://issues.apache.org/jira/browse/LUCENE-10270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-10270:
-
Fix Version/s: 9.1
> Improve MIGRATE.md
> --
>
> Key: LUCENE-10
Robert Muir created LUCENE-10270:
Summary: Improve MIGRATE.md
Key: LUCENE-10270
URL: https://issues.apache.org/jira/browse/LUCENE-10270
Project: Lucene - Core
Issue Type: Task
Rep
mocobeta commented on pull request #487:
URL: https://github.com/apache/lucene/pull/487#issuecomment-982134969
> Also I added a note that the module names should not be considered
"stable".
For what it's worth, I don't think this notice is needed. I've seen many
small/large project
rmuir commented on a change in pull request #485:
URL: https://github.com/apache/lucene/pull/485#discussion_r758820290
##
File path: lucene/core/src/java/org/apache/lucene/search/AutomatonQuery.java
##
@@ -65,7 +63,7 @@
* @param automaton Automaton to run, terms that are ac
zhaih commented on a change in pull request #485:
URL: https://github.com/apache/lucene/pull/485#discussion_r758815445
##
File path: lucene/core/src/java/org/apache/lucene/search/AutomatonQuery.java
##
@@ -65,7 +63,7 @@
* @param automaton Automaton to run, terms that are ac
zhaih commented on pull request #225:
URL: https://github.com/apache/lucene/pull/225#issuecomment-982125853
Thanks @rmuir, I'll run a benchmark to ensure this PR does not introduce
regression recently.
I like the approach you proposed in #485, it would be nice if we can get rid
of `
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450762#comment-17450762
]
Uwe Schindler commented on LUCENE-10255:
Thanks [~sor] for confirmation.
We no
rmuir merged pull request #489:
URL: https://github.com/apache/lucene/pull/489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
uschindler commented on pull request #489:
URL: https://github.com/apache/lucene/pull/489#issuecomment-982083351
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
uschindler commented on pull request #489:
URL: https://github.com/apache/lucene/pull/489#issuecomment-982080248
I created the same PR but did not yet commit it.
Looks identical here, I just reformatted the long line with the extensions.
+1 to commit.
--
This is an automated
rmuir opened a new pull request #489:
URL: https://github.com/apache/lucene/pull/489
https://github.com/apache/lucene/pull/488 added table of analyzer artifacts
changes.
Unfortunately it looks like crap in generated HTML unless we bring in the
tables extension.
Before:
uschindler commented on pull request #488:
URL: https://github.com/apache/lucene/pull/488#issuecomment-982072123
Hi Robert,
I built the documentation with "gradlew documentation" and noticed that
tables were not enabled in the markdown converter. It now looks not very well.
If you
rmuir merged pull request #488:
URL: https://github.com/apache/lucene/pull/488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
uschindler commented on pull request #488:
URL: https://github.com/apache/lucene/pull/488#issuecomment-982064591
This was just meant as a replacement for this text: "and are now consistent
with repository module 'analysis'". This does not sound like a acceptable
explanation to an annoyed u
rmuir commented on pull request #488:
URL: https://github.com/apache/lucene/pull/488#issuecomment-982061761
> A separate note: The new name is also more conforming what the modules
relay do: They are not only "analyzers", those are compoents for "analysis" of
text while indexing/searching
uschindler commented on pull request #488:
URL: https://github.com/apache/lucene/pull/488#issuecomment-982058390
Originally I made the MIGRATE.md a markdown file to have all formatting
possibilities. The unordered list was just a "quick conversion" from the old
format introduced in Lucene
rmuir commented on pull request #488:
URL: https://github.com/apache/lucene/pull/488#issuecomment-982055841
Sorry for all the commits, I wanted to try to make this easy to read and
prominent, and linked from the README too for more visibility.
I realize the `MIGRATE.md` is an unstru
uschindler commented on pull request #487:
URL: https://github.com/apache/lucene/pull/487#issuecomment-982055622
I added a change to the CHANGES.txt file to explain that the automatic
module names are a preparation for full module system support. This should be
added, because we have not
uschindler commented on pull request #488:
URL: https://github.com/apache/lucene/pull/488#issuecomment-982048976
Table looks much better now. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
uschindler commented on pull request #488:
URL: https://github.com/apache/lucene/pull/488#issuecomment-982046022
A separate note: The new name is also more conforming what the modules relay
do: They are not only "analyzers", those are compoents for "analysis" of text
while indexing/searchi
rmuir opened a new pull request #488:
URL: https://github.com/apache/lucene/pull/488
Move this to the very top of MIGRATE, the user needs to first be able to
pull in the artifacts, before doing anything else like trying to compile, deal
with renamed classes, etc.
Add a table of each
dweiss commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758746111
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']
uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758744591
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.versi
dweiss commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758742625
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']
rmuir commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758737615
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']}
uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758733113
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.versi
dweiss commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758732884
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']
uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758729874
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.versi
rmuir commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758728664
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']}
uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758723981
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.versi
rmuir commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758723885
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']}
rmuir commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758721225
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']}
uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758718326
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.versi
uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758717236
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.versi
uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758715684
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.versi
uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758715684
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.versi
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450707#comment-17450707
]
Christian Stein commented on LUCENE-10255:
--
FWIW, I agree with Uwe on the nami
dweiss commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758700461
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']
uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758697734
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.versi
dweiss commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758691210
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']
dweiss commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758689212
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']
madrob merged pull request #2615:
URL: https://github.com/apache/lucene-solr/pull/2615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsu
jtibshirani commented on a change in pull request #416:
URL: https://github.com/apache/lucene/pull/416#discussion_r758678766
##
File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java
##
@@ -56,31 +59,50 @@
public final class HnswGraph extends KnnGraphValues
dweiss commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758670507
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450690#comment-17450690
]
Dawid Weiss commented on LUCENE-10255:
--
I accept your arguments, even if I disagre
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450680#comment-17450680
]
Uwe Schindler edited comment on LUCENE-10255 at 11/29/21, 7:02 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450680#comment-17450680
]
Uwe Schindler commented on LUCENE-10255:
bq. Sorry for the silly question, but
uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758637522
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.versi
[
https://issues.apache.org/jira/browse/LUCENE-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-10234:
-
Description: This is the first step to make Lucene a proper fit for the
java module system. -I
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450647#comment-17450647
]
Dawid Weiss edited comment on LUCENE-10255 at 11/29/21, 6:15 PM:
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450647#comment-17450647
]
Dawid Weiss commented on LUCENE-10255:
--
It'll be a different prefix in module-info
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450639#comment-17450639
]
Robert Muir commented on LUCENE-10255:
--
my comment was a genuine question, as I do
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450635#comment-17450635
]
Dawid Weiss commented on LUCENE-10255:
--
I already typed "-m lucene.luke" what seem
[
https://issues.apache.org/jira/browse/LUCENE-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss reopened LUCENE-10234:
--
Uwe seems to be really devoted to changing the automatic module name to
full-prefix convention,
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450630#comment-17450630
]
Robert Muir commented on LUCENE-10255:
--
{quote}
Sorry but I remain unconvinced tha
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450628#comment-17450628
]
Dawid Weiss commented on LUCENE-10255:
--
https://issues.apache.org/jira/browse/LUCE
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450627#comment-17450627
]
Uwe Schindler commented on LUCENE-10255:
bq. This was done with an announcement
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450625#comment-17450625
]
Uwe Schindler commented on LUCENE-10255:
bq. I just figured out that you alread
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450624#comment-17450624
]
Dawid Weiss commented on LUCENE-10255:
--
Uwe... This was done with an announcement
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450620#comment-17450620
]
Uwe Schindler edited comment on LUCENE-10255 at 11/29/21, 5:41 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450620#comment-17450620
]
Uwe Schindler commented on LUCENE-10255:
Apache TIKA also uses module names acc
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450613#comment-17450613
]
Dawid Weiss commented on LUCENE-10255:
--
Mistakes of the youth... I remain unconvin
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450607#comment-17450607
]
Uwe Schindler edited comment on LUCENE-10255 at 11/29/21, 5:14 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450607#comment-17450607
]
Uwe Schindler commented on LUCENE-10255:
>From the list posted before there is
rmuir commented on pull request #477:
URL: https://github.com/apache/lucene/pull/477#issuecomment-981837493
and btw i'm not suggesting we do all this crap underneath this PR, the
current PR looks fine to me (the optimization it uses is safe)
--
This is an automated message from the Apach
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450604#comment-17450604
]
Dawid Weiss commented on LUCENE-10255:
--
Sure, Uwe. I think I expressed my personal
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450597#comment-17450597
]
Uwe Schindler commented on LUCENE-10255:
We can disagree, for sure, but I'd lik
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450583#comment-17450583
]
Uwe Schindler edited comment on LUCENE-10255 at 11/29/21, 4:59 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450583#comment-17450583
]
Uwe Schindler edited comment on LUCENE-10255 at 11/29/21, 4:50 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450589#comment-17450589
]
Dawid Weiss commented on LUCENE-10255:
--
You don't understand me, Uwe. I agree on m
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450583#comment-17450583
]
Uwe Schindler commented on LUCENE-10255:
Hi,
please have an overview on Maven c
rmuir commented on pull request #477:
URL: https://github.com/apache/lucene/pull/477#issuecomment-981811821
> One disadvantage of renaming it is that it really does require norms to
work; it might be a bit surprising to have a 'TokensExistsQuery' that you run
against a field with norms dis
romseygeek commented on pull request #477:
URL: https://github.com/apache/lucene/pull/477#issuecomment-981775748
One disadvantage of renaming it is that it really does require norms to
work; it might be a bit surprising to have a 'TokensExistsQuery' that you run
against a field with norms
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450554#comment-17450554
]
Dawid Weiss commented on LUCENE-10255:
--
Sorry but I remain unconvinced that typing
iverase commented on a change in pull request #486:
URL: https://github.com/apache/lucene/pull/486#discussion_r758504244
##
File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java
##
@@ -323,10 +355,18 @@ default void grow(int count) {}
*/
public final v
iverase opened a new pull request #486:
URL: https://github.com/apache/lucene/pull/486
Introduces two functional interfaces, `DocValuesVisitor` and `DocIdsVisitor`
that are used in the PointTree API instead of using the IntersectVisitor. The
IntersectVisitor is now extending those interfac
rmuir commented on pull request #477:
URL: https://github.com/apache/lucene/pull/477#issuecomment-981765930
personally, i really feel if someone wants "empty string" to be considered
"indexed" for cases like this, they should use KeywordTokenizer/StringField,
and actually index that empty
rmuir commented on pull request #477:
URL: https://github.com/apache/lucene/pull/477#issuecomment-981761039
> For a `TokensExistsQuery`, is the idea that the query part would work the
same as norms, we just filter out docs with a norm of 0?
yeah, at first at least. sounds like we nee
romseygeek commented on pull request #477:
URL: https://github.com/apache/lucene/pull/477#issuecomment-981755138
For a `TokensExistsQuery`, is the idea that the query part would work the
same as norms, we just filter out docs with a norm of 0?
--
This is an automated message from the Apa
rmuir commented on pull request #477:
URL: https://github.com/apache/lucene/pull/477#issuecomment-981738439
Let's fix the CHANGES now that it works with deleted documents.
I'm sad the optimization couldnt work because of a crazy corner case: which
begs the question, why does the user
1 - 100 of 125 matches
Mail list logo
