[GitHub] [lucene] jpountz commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-11-17 Thread GitBox
jpountz commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r751974577 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java ## @@ -328,31 +288,97 @@ public Relation compare(byte[] minPackedValue, byte[] maxP

[GitHub] [lucene] jpountz commented on a change in pull request #442: LUCENE-10122 Use NumericDocValue to store taxonomy parent array

2021-11-17 Thread GitBox
jpountz commented on a change in pull request #442: URL: https://github.com/apache/lucene/pull/442#discussion_r751969762 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java ## @@ -130,6 +125,46 @@ private void initParents(Ind

[GitHub] [lucene] dweiss commented on a change in pull request #452: LUCENE-10239: upgrade jflex (1.7.0 -> 1.8.2)

2021-11-17 Thread GitBox
dweiss commented on a change in pull request #452: URL: https://github.com/apache/lucene/pull/452#discussion_r751944910 ## File path: dev-tools/missing-doclet/src/main/java/org/apache/lucene/missingdoclet/MissingDoclet.java ## @@ -331,7 +331,6 @@ private boolean hasInheritedJa

[jira] [Created] (LUCENE-10243) increase unicode versions of tokenizers to unicode 12.1

2021-11-17 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10243: Summary: increase unicode versions of tokenizers to unicode 12.1 Key: LUCENE-10243 URL: https://issues.apache.org/jira/browse/LUCENE-10243 Project: Lucene - Core

[GitHub] [lucene] zacharymorn commented on a change in pull request #444: LUCENE-10236: Updated field-weight used in CombinedFieldQuery scoring calculation, and added a test

2021-11-17 Thread GitBox
zacharymorn commented on a change in pull request #444: URL: https://github.com/apache/lucene/pull/444#discussion_r751910253 ## File path: lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestCombinedFieldQuery.java ## @@ -165,6 +169,117 @@ public void testSameScore()

[GitHub] [lucene] rmuir commented on a change in pull request #452: LUCENE-10239: upgrade jflex (1.7.0 -> 1.8.2)

2021-11-17 Thread GitBox
rmuir commented on a change in pull request #452: URL: https://github.com/apache/lucene/pull/452#discussion_r751800229 ## File path: gradle/generation/jflex.gradle ## @@ -270,6 +270,17 @@ class JFlexTask extends DefaultTask { ] } +// fix invalid SuppressWarnin

[GitHub] [lucene] rmuir commented on a change in pull request #452: LUCENE-10239: upgrade jflex (1.7.0 -> 1.8.2)

2021-11-17 Thread GitBox
rmuir commented on a change in pull request #452: URL: https://github.com/apache/lucene/pull/452#discussion_r751799701 ## File path: dev-tools/missing-doclet/src/main/java/org/apache/lucene/missingdoclet/MissingDoclet.java ## @@ -331,7 +331,6 @@ private boolean hasInheritedJav

[GitHub] [lucene] rmuir commented on pull request #452: LUCENE-10239: upgrade jflex (1.7.0 -> 1.8.2)

2021-11-17 Thread GitBox
rmuir commented on pull request #452: URL: https://github.com/apache/lucene/pull/452#issuecomment-972384034 I thought to try to do a large refactoring here and quickly backed off, I think let's just upgrade to the latest jflex as a standalone change. The trickiest parts (and ones ne

[GitHub] [lucene] rmuir opened a new pull request #452: LUCENE-10239: upgrade jflex (1.7.0 -> 1.8.2)

2021-11-17 Thread GitBox
rmuir opened a new pull request #452: URL: https://github.com/apache/lucene/pull/452 Upgrade jflex. Change doesn't alter the behavior of any of the analyzers (unicode version or grammar refactorings), just the minimal to get new tooling working. -- This is an automated mes

[jira] [Commented] (LUCENE-10239) upgrade jflex (1.7.0 -> 1.8.2)

2021-11-17 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445559#comment-17445559 ] Robert Muir commented on LUCENE-10239: -- I'd like to do a "minimal" upgrade for thi

[jira] [Commented] (LUCENE-10122) Explore using NumericDocValue to store taxonomy parent array

2021-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445556#comment-17445556 ] ASF subversion and git services commented on LUCENE-10122: -- Co

[GitHub] [lucene] mikemccand merged pull request #451: LUCENE-10122 Use NumericDocValue to store taxonomy parent array

2021-11-17 Thread GitBox
mikemccand merged pull request #451: URL: https://github.com/apache/lucene/pull/451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [lucene] zhaih commented on pull request #451: LUCENE-10122 Use NumericDocValue to store taxonomy parent array

2021-11-17 Thread GitBox
zhaih commented on pull request #451: URL: https://github.com/apache/lucene/pull/451#issuecomment-972357861 Thanks Mike for the quick review, seems I forgot to remove one method that is unused (previously for back-compat) and spotless caught that :) I just removed that. -- This is an au

[GitHub] [lucene] zhaih opened a new pull request #451: LUCENE-10122 Use NumericDocValue to store taxonomy parent array

2021-11-17 Thread GitBox
zhaih opened a new pull request #451: URL: https://github.com/apache/lucene/pull/451 # Note This is the Lucene 10 version of https://github.com/apache/lucene/pull/442, it removes the back-compatibility part of that PR # Checklist Please review the following and check all th

[jira] [Commented] (LUCENE-10122) Explore using NumericDocValue to store taxonomy parent array

2021-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445540#comment-17445540 ] ASF subversion and git services commented on LUCENE-10122: -- Co

[GitHub] [lucene] mikemccand merged pull request #442: LUCENE-10122 Use NumericDocValue to store taxonomy parent array

2021-11-17 Thread GitBox
mikemccand merged pull request #442: URL: https://github.com/apache/lucene/pull/442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [lucene] mikemccand commented on a change in pull request #442: LUCENE-10122 Use NumericDocValue to store taxonomy parent array

2021-11-17 Thread GitBox
mikemccand commented on a change in pull request #442: URL: https://github.com/apache/lucene/pull/442#discussion_r751706449 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java ## @@ -130,15 +125,49 @@ private void initParents

[GitHub] [lucene] mayya-sharipova commented on pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-11-17 Thread GitBox
mayya-sharipova commented on pull request #416: URL: https://github.com/apache/lucene/pull/416#issuecomment-972170715 @jtibshirani Thanks for your extensive review. I've tried to address some comments, and some comments I think we still need to discuss > does it have an impact on ind

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-11-17 Thread GitBox
mayya-sharipova commented on a change in pull request #416: URL: https://github.com/apache/lucene/pull/416#discussion_r751687763 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java ## @@ -56,31 +59,50 @@ public final class HnswGraph extends KnnGraphVa

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-11-17 Thread GitBox
mayya-sharipova commented on a change in pull request #416: URL: https://github.com/apache/lucene/pull/416#discussion_r751673717 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java ## @@ -99,32 +121,72 @@ public static NeighborQueue search( Bits

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-11-17 Thread GitBox
mayya-sharipova commented on a change in pull request #416: URL: https://github.com/apache/lucene/pull/416#discussion_r751672547 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java ## @@ -56,31 +59,50 @@ public final class HnswGraph extends KnnGraphVa

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-11-17 Thread GitBox
mayya-sharipova commented on a change in pull request #416: URL: https://github.com/apache/lucene/pull/416#discussion_r751671791 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsFormat.java ## @@ -69,10 +99,12 @@ static final String

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-11-17 Thread GitBox
mayya-sharipova commented on a change in pull request #416: URL: https://github.com/apache/lucene/pull/416#discussion_r751671158 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java ## @@ -205,6 +215,43 @@ private FieldEntry readF

[jira] [Commented] (LUCENE-10238) Update icu4j to 70.1

2021-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445504#comment-17445504 ] ASF subversion and git services commented on LUCENE-10238: -- Co

[jira] [Commented] (LUCENE-10240) gradle regenerate fails on java 17

2021-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445505#comment-17445505 ] ASF subversion and git services commented on LUCENE-10240: -- Co

[jira] [Commented] (LUCENE-10085) Implement Weight#count on DocValuesFieldExistsQuery

2021-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445501#comment-17445501 ] ASF subversion and git services commented on LUCENE-10085: -- Co

[jira] [Commented] (LUCENE-10069) HNSW can miss results with very large k

2021-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445500#comment-17445500 ] ASF subversion and git services commented on LUCENE-10069: -- Co

[jira] [Commented] (LUCENE-10225) Improve IntroSelector with 3-way partitioning

2021-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445503#comment-17445503 ] ASF subversion and git services commented on LUCENE-10225: -- Co

[jira] [Commented] (LUCENE-10234) Add automatic module name to JAR manifests.

2021-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445502#comment-17445502 ] ASF subversion and git services commented on LUCENE-10234: -- Co

[jira] [Commented] (LUCENE-10242) The TopScoreDocCollector::createSharedManager should use ScoreDoc instead of FieldDoc

2021-11-17 Thread Andriy Redko (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445480#comment-17445480 ] Andriy Redko commented on LUCENE-10242: --- https://github.com/apache/lucene/pull/45

[GitHub] [lucene] reta opened a new pull request #450: LUCENE-10242: The TopScoreDocCollector::createSharedManager should use ScoreDoc instead of FieldDoc

2021-11-17 Thread GitBox
reta opened a new pull request #450: URL: https://github.com/apache/lucene/pull/450 Signed-off-by: Andriy Redko # Description The `TopScoreDocCollector::createSharedManager` should use `ScoreDoc` instead of `FieldDoc` as a type of `after` argument. The `FieldDoc` is really n

[jira] [Created] (LUCENE-10242) The TopScoreDocCollector::createSharedManager should use ScoreDoc instead of FieldDoc

2021-11-17 Thread Andriy Redko (Jira)
Andriy Redko created LUCENE-10242: - Summary: The TopScoreDocCollector::createSharedManager should use ScoreDoc instead of FieldDoc Key: LUCENE-10242 URL: https://issues.apache.org/jira/browse/LUCENE-10242

[GitHub] [lucene] pquentin commented on a change in pull request #445: LUCENE-10085: Implement Weight#count on DocValuesFieldExistsQuery

2021-11-17 Thread GitBox
pquentin commented on a change in pull request #445: URL: https://github.com/apache/lucene/pull/445#discussion_r751606710 ## File path: lucene/core/src/test/org/apache/lucene/search/TestDocValuesFieldExistsQuery.java ## @@ -206,6 +210,50 @@ public void testFieldExistsButNoDocs

[GitHub] [lucene] pquentin commented on a change in pull request #445: LUCENE-10085: Implement Weight#count on DocValuesFieldExistsQuery

2021-11-17 Thread GitBox
pquentin commented on a change in pull request #445: URL: https://github.com/apache/lucene/pull/445#discussion_r751606710 ## File path: lucene/core/src/test/org/apache/lucene/search/TestDocValuesFieldExistsQuery.java ## @@ -206,6 +210,50 @@ public void testFieldExistsButNoDocs

[GitHub] [lucene] pquentin commented on a change in pull request #445: LUCENE-10085: Implement Weight#count on DocValuesFieldExistsQuery

2021-11-17 Thread GitBox
pquentin commented on a change in pull request #445: URL: https://github.com/apache/lucene/pull/445#discussion_r751606167 ## File path: lucene/core/src/test/org/apache/lucene/search/TestDocValuesFieldExistsQuery.java ## @@ -206,6 +210,52 @@ public void testFieldExistsButNoDocs

[GitHub] [lucene] zhaih commented on a change in pull request #442: LUCENE-10122 Use NumericDocValue to store taxonomy parent array

2021-11-17 Thread GitBox
zhaih commented on a change in pull request #442: URL: https://github.com/apache/lucene/pull/442#discussion_r751545923 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyWriter.java ## @@ -466,18 +476,22 @@ protected final void ensu

[GitHub] [lucene] zhaih commented on a change in pull request #442: LUCENE-10122 Use NumericDocValue to store taxonomy parent array

2021-11-17 Thread GitBox
zhaih commented on a change in pull request #442: URL: https://github.com/apache/lucene/pull/442#discussion_r751544194 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyWriter.java ## @@ -92,15 +93,18 @@ private final Directory

[GitHub] [lucene] rmuir commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
rmuir commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751504639 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/OrdinalMappingLeafReader.java ## @@ -107,6 +113,64 @@ public BytesRef binaryValue() {

[GitHub] [lucene] jpountz commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
jpountz commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751483461 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java ## @@ -69,31 +69,34 @@ public FastTaxonomyFacetCounts(

[GitHub] [lucene] jpountz commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
jpountz commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751482085 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java ## @@ -69,31 +69,34 @@ public FastTaxonomyFacetCounts(

[jira] [Resolved] (LUCENE-10240) gradle regenerate fails on java 17

2021-11-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10240. -- Fix Version/s: 9.1 Resolution: Fixed > gradle regenerate fails on java 17 > --

[jira] [Commented] (LUCENE-10240) gradle regenerate fails on java 17

2021-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445403#comment-17445403 ] ASF subversion and git services commented on LUCENE-10240: -- Co

[GitHub] [lucene] gsmiller commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
gsmiller commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751476550 ## File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java ## @@ -81,4 +82,17 @@ public long cost() { } }; } + + /** + *

[jira] [Commented] (LUCENE-10240) gradle regenerate fails on java 17

2021-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445402#comment-17445402 ] ASF subversion and git services commented on LUCENE-10240: -- Co

[GitHub] [lucene] dweiss merged pull request #449: LUCENE-10240: gradle regenerate fails on java 17

2021-11-17 Thread GitBox
dweiss merged pull request #449: URL: https://github.com/apache/lucene/pull/449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [lucene] dweiss commented on pull request #449: LUCENE-10240: gradle regenerate fails on java 17

2021-11-17 Thread GitBox
dweiss commented on pull request #449: URL: https://github.com/apache/lucene/pull/449#issuecomment-971804749 Yeah. I don't completely understand the cause either - I just thought not forcing groovy to create an anonymous implementation of the interface passed to andThen would dodge the pro

[GitHub] [lucene] gsmiller commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
gsmiller commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751475270 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/OrdinalMappingLeafReader.java ## @@ -107,6 +113,64 @@ public BytesRef binaryValue() {

[GitHub] [lucene] gsmiller commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
gsmiller commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751465599 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacetLabels.java ## @@ -62,7 +62,16 @@ public TaxonomyFacetLabels(TaxonomyRead

[GitHub] [lucene] gsmiller commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
gsmiller commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751469402 ## File path: lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestBackwardsCompatibility.java ## @@ -50,43 +74,192 @@ // Then move the

[GitHub] [lucene] gsmiller commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
gsmiller commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751468971 ## File path: lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestBackwardsCompatibility.java ## @@ -138,4 +331,51 @@ private Path getInde

[GitHub] [lucene] gsmiller commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
gsmiller commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751467541 ## File path: lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestBackCompatSortedNumericDocValues.java ## @@ -0,0 +1,136 @@ +/* + * Licensed to the

[GitHub] [lucene] gsmiller commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
gsmiller commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751467194 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacetLabels.java ## @@ -168,24 +234,61 @@ public FacetLabel nextFacetLabel(int

[GitHub] [lucene] gsmiller commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
gsmiller commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751465599 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacetLabels.java ## @@ -62,7 +62,16 @@ public TaxonomyFacetLabels(TaxonomyRead

[GitHub] [lucene] gsmiller commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
gsmiller commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751464048 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/OrdinalMappingLeafReader.java ## @@ -107,6 +113,64 @@ public BytesRef binaryValue() {

[GitHub] [lucene] gsmiller commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
gsmiller commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751462508 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/OrdinalMappingLeafReader.java ## @@ -107,6 +113,64 @@ public BytesRef binaryValue() {

[GitHub] [lucene] jtibshirani commented on a change in pull request #444: LUCENE-10236: Updated field-weight used in CombinedFieldQuery scoring calculation, and added a test

2021-11-17 Thread GitBox
jtibshirani commented on a change in pull request #444: URL: https://github.com/apache/lucene/pull/444#discussion_r751461104 ## File path: lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestCombinedFieldQuery.java ## @@ -165,6 +169,117 @@ public void testSameScore()

[jira] [Commented] (LUCENE-10238) Update icu4j to 70.1

2021-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445381#comment-17445381 ] ASF subversion and git services commented on LUCENE-10238: -- Co

[jira] [Resolved] (LUCENE-10238) Update icu4j to 70.1

2021-11-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10238. -- Fix Version/s: 9.1 Resolution: Fixed > Update icu4j to 70.1 > > >

[GitHub] [lucene] gsmiller commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
gsmiller commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751456634 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java ## @@ -69,31 +69,34 @@ public FastTaxonomyFacetCounts(

[jira] [Commented] (LUCENE-10238) Update icu4j to 70.1

2021-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445378#comment-17445378 ] ASF subversion and git services commented on LUCENE-10238: -- Co

[GitHub] [lucene] dweiss merged pull request #447: LUCENE-10238: Update icu4j to 70.1.

2021-11-17 Thread GitBox
dweiss merged pull request #447: URL: https://github.com/apache/lucene/pull/447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [lucene] gsmiller commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
gsmiller commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751455429 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java ## @@ -69,31 +69,34 @@ public FastTaxonomyFacetCounts(

[GitHub] [lucene] gsmiller commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
gsmiller commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751453619 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/BackCompatSortedNumericDocValues.java ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apa

[GitHub] [lucene] gsmiller commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
gsmiller commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751453417 ## File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java ## @@ -409,9 +410,26 @@ private void processFacetFields( indexDrillDo

[GitHub] [lucene] dweiss opened a new pull request #449: LUCENE-10240: gradle regenerate fails on java 17

2021-11-17 Thread GitBox
dweiss opened a new pull request #449: URL: https://github.com/apache/lucene/pull/449 This should do the trick. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [lucene] gsmiller commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
gsmiller commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751451039 ## File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java ## @@ -409,9 +410,26 @@ private void processFacetFields( indexDrillDo

[GitHub] [lucene] rmuir commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
rmuir commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751437818 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/OrdinalMappingLeafReader.java ## @@ -107,6 +113,64 @@ public BytesRef binaryValue() {

[GitHub] [lucene] rmuir commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
rmuir commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751435736 ## File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java ## @@ -409,9 +410,26 @@ private void processFacetFields( indexDrillDownT

[GitHub] [lucene] jpountz commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
jpountz commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751413961 ## File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java ## @@ -81,4 +82,17 @@ public long cost() { } }; } + + /** + * D

[jira] [Commented] (LUCENE-10241) Update OpenNLP to 1.9.4

2021-11-17 Thread Jeff Zemerick (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445336#comment-17445336 ] Jeff Zemerick commented on LUCENE-10241: First time contributor to Lucene -- pl

[GitHub] [lucene] mikemccand commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
mikemccand commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751373424 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/OrdinalMappingLeafReader.java ## @@ -107,6 +113,64 @@ public BytesRef binaryValue()

[GitHub] [lucene] jzonthemtn opened a new pull request #448: LUCENE-10241: Updating OpenNLP to 1.9.4.

2021-11-17 Thread GitBox
jzonthemtn opened a new pull request #448: URL: https://github.com/apache/lucene/pull/448 # Description Updating OpenNLP dependency to 1.9.4. # Solution Updated OpenNLP dependency version. # Tests Tests passed. # Checklist Please r

[jira] [Updated] (LUCENE-10233) Store docIds as bitset when leafCardinality = 1 to speed up addAll

2021-11-17 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Guo updated LUCENE-10233: -- Attachment: (was: image-2021-11-17-22-43-13-693.png) > Store docIds as bitset when leafCardinalit

[GitHub] [lucene] magibney commented on a change in pull request #380: LUCENE-10171 - Fix dictionary-based OpenNLPLemmatizerFilterFactory caching issue

2021-11-17 Thread GitBox
magibney commented on a change in pull request #380: URL: https://github.com/apache/lucene/pull/380#discussion_r751397674 ## File path: lucene/analysis/opennlp/src/java/org/apache/lucene/analysis/opennlp/tools/OpenNLPOpsFactory.java ## @@ -169,11 +169,14 @@ public static Strin

[jira] [Commented] (LUCENE-10240) gradle regenerate fails on java 17

2021-11-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445309#comment-17445309 ] Dawid Weiss commented on LUCENE-10240: -- Absolutely. This seems unrelated. > gradl

[GitHub] [lucene] gsmiller commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
gsmiller commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751370043 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/BackCompatSortedNumericDocValues.java ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apa

[jira] [Commented] (LUCENE-10240) gradle regenerate fails on java 17

2021-11-17 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445303#comment-17445303 ] Robert Muir commented on LUCENE-10240: -- Thanks for tracking down the groovy bug.

[GitHub] [lucene] gsmiller commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
gsmiller commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751365695 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/DocValuesOrdinalsReader.java ## @@ -41,13 +48,21 @@ public DocValuesOrdinalsReader(Str

[GitHub] [lucene] gsmiller commented on a change in pull request #442: LUCENE-10122 Use NumericDocValue to store taxonomy parent array

2021-11-17 Thread GitBox
gsmiller commented on a change in pull request #442: URL: https://github.com/apache/lucene/pull/442#discussion_r751355800 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java ## @@ -130,15 +125,49 @@ private void initParents(I

[GitHub] [lucene] jpountz commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
jpountz commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751361476 ## File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java ## @@ -81,4 +82,17 @@ public long cost() { } }; } + + /** + * D

[GitHub] [lucene] jpountz commented on a change in pull request #443: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals

2021-11-17 Thread GitBox
jpountz commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751006192 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/BackCompatSortedNumericDocValues.java ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apac

[GitHub] [lucene] dweiss commented on pull request #447: LUCENE-10238: Update icu4j to 70.1.

2021-11-17 Thread GitBox
dweiss commented on pull request #447: URL: https://github.com/apache/lucene/pull/447#issuecomment-971690639 Darn. Thanks for fixing changes.txt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene] dweiss commented on pull request #433: LUCENE-10230 make demo builds easier to execute

2021-11-17 Thread GitBox
dweiss commented on pull request #433: URL: https://github.com/apache/lucene/pull/433#issuecomment-971689826 I think some of these "demo" classes come from different modules - this is legacy and highly unstructured... But feel free to provide a patch, sure. I was thinking about it myself.

[jira] [Commented] (LUCENE-10240) gradle regenerate fails on java 17

2021-11-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445292#comment-17445292 ] Dawid Weiss commented on LUCENE-10240: -- Seems like this is the problem: https://is

[GitHub] [lucene] mikemccand commented on a change in pull request #442: LUCENE-10122 Use NumericDocValue to store taxonomy parent array

2021-11-17 Thread GitBox
mikemccand commented on a change in pull request #442: URL: https://github.com/apache/lucene/pull/442#discussion_r751350351 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java ## @@ -130,40 +125,82 @@ private void initParents

[jira] [Created] (LUCENE-10241) Update OpenNLP to 1.9.4

2021-11-17 Thread Jeff Zemerick (Jira)
Jeff Zemerick created LUCENE-10241: -- Summary: Update OpenNLP to 1.9.4 Key: LUCENE-10241 URL: https://issues.apache.org/jira/browse/LUCENE-10241 Project: Lucene - Core Issue Type: Task

[GitHub] [lucene] mikemccand commented on a change in pull request #442: LUCENE-10122 Use NumericDocValue to store taxonomy parent array

2021-11-17 Thread GitBox
mikemccand commented on a change in pull request #442: URL: https://github.com/apache/lucene/pull/442#discussion_r751348311 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java ## @@ -130,15 +125,49 @@ private void initParents

[jira] [Commented] (LUCENE-10240) gradle regenerate fails on java 17

2021-11-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445286#comment-17445286 ] Dawid Weiss commented on LUCENE-10240: -- That external groovy dependency can be upd

[GitHub] [lucene] gsmiller commented on pull request #264: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals (instead of custom binary format)

2021-11-17 Thread GitBox
gsmiller commented on pull request #264: URL: https://github.com/apache/lucene/pull/264#issuecomment-971678277 I've removed all back-compat support now from this PR since we're trying to include this change in 9.0 (see #443). So this PR now reflects my proposed end-state in main. I still s

[GitHub] [lucene] gsmiller commented on a change in pull request #264: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals (instead of custom binary format)

2021-11-17 Thread GitBox
gsmiller commented on a change in pull request #264: URL: https://github.com/apache/lucene/pull/264#discussion_r751339846 ## File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java ## @@ -81,4 +84,19 @@ public long cost() { } }; } + + /** + *

[GitHub] [lucene] gsmiller commented on a change in pull request #264: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals (instead of custom binary format)

2021-11-17 Thread GitBox
gsmiller commented on a change in pull request #264: URL: https://github.com/apache/lucene/pull/264#discussion_r751338671 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/DocValuesOrdinalsReader.java ## @@ -41,12 +40,7 @@ public DocValuesOrdinalsReader(Stri

[GitHub] [lucene] codaitya commented on pull request #446: LUCENE-10237 : Add MergeOnCommitTieredMergePolicy to sandbox

2021-11-17 Thread GitBox
codaitya commented on pull request #446: URL: https://github.com/apache/lucene/pull/446#issuecomment-971673541 > Let's rename to `MergeOnFlushTieredMergePolicy` since it technically merges on flushes, not commits? > > I haven't taken a deep look at the code, but is it specific to `T

[jira] [Commented] (LUCENE-10240) gradle regenerate fails on java 17

2021-11-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445265#comment-17445265 ] Dawid Weiss commented on LUCENE-10240: -- Weird. I'll take a look. > gradle regener

[jira] [Assigned] (LUCENE-10240) gradle regenerate fails on java 17

2021-11-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reassigned LUCENE-10240: Assignee: Dawid Weiss > gradle regenerate fails on java 17 > ---

[GitHub] [lucene] hendrikmuhs commented on pull request #433: LUCENE-10230 make demo builds easier to execute

2021-11-17 Thread GitBox
hendrikmuhs commented on pull request #433: URL: https://github.com/apache/lucene/pull/433#issuecomment-971656429 @dweiss Thanks for the feedback. I agree about avoiding gradle magic. The module suggestion is great and helped me finding a better solution for me (I want to run thing

[jira] [Commented] (LUCENE-10233) Store docIds as bitset when leafCardinality = 1 to speed up addAll

2021-11-17 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445262#comment-17445262 ] Feng Guo commented on LUCENE-10233: --- This is the flame graph of keeping running this

[jira] (LUCENE-10233) Store docIds as bitset when leafCardinality = 1 to speed up addAll

2021-11-17 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10233 ] Feng Guo deleted comment on LUCENE-10233: --- was (Author: gf2121): This is the flame graph of keeping running this script, it seems a lot of time took to new a SparseFixedBitSet, which allocate

[jira] [Updated] (LUCENE-10233) Store docIds as bitset when leafCardinality = 1 to speed up addAll

2021-11-17 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Guo updated LUCENE-10233: -- Attachment: image-2021-11-17-22-43-13-693.png > Store docIds as bitset when leafCardinality = 1 to sp

[jira] [Commented] (LUCENE-10240) gradle regenerate fails on java 17

2021-11-17 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445253#comment-17445253 ] Robert Muir commented on LUCENE-10240: -- Bumping the groovy version fixes the issue

[jira] [Comment Edited] (LUCENE-10233) Store docIds as bitset when leafCardinality = 1 to speed up addAll

2021-11-17 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445143#comment-17445143 ] Feng Guo edited comment on LUCENE-10233 at 11/17/21, 2:28 PM: ---

  1   2   >