zhaih commented on a change in pull request #225:
URL: https://github.com/apache/lucene/pull/225#discussion_r724698226
##
File path:
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene40/blocktree/FieldReader.java
##
@@ -187,6 +187,14 @@ public TermsEnum i
zhaih commented on a change in pull request #225:
URL: https://github.com/apache/lucene/pull/225#discussion_r724698226
##
File path:
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene40/blocktree/FieldReader.java
##
@@ -187,6 +187,14 @@ public TermsEnum i
zhaih commented on a change in pull request #225:
URL: https://github.com/apache/lucene/pull/225#discussion_r724697716
##
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/memory/DirectPostingsFormat.java
##
@@ -962,15 +964,22 @@ public ImpactsEnum impacts(int flags)
zhaih commented on a change in pull request #225:
URL: https://github.com/apache/lucene/pull/225#discussion_r724695583
##
File path:
lucene/core/src/test/org/apache/lucene/util/automaton/TestNFARunAutomaton.java
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foun
zhaih commented on a change in pull request #225:
URL: https://github.com/apache/lucene/pull/225#discussion_r724695030
##
File path: lucene/core/src/java/org/apache/lucene/search/AutomatonQuery.java
##
@@ -65,7 +66,19 @@
* @param automaton Automaton to run, terms that are a
zhaih commented on a change in pull request #225:
URL: https://github.com/apache/lucene/pull/225#discussion_r724693503
##
File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java
##
@@ -551,12 +551,22 @@ static RegExp newLeafNode(
return new RegExp(flag
[
https://issues.apache.org/jira/browse/LUCENE-5572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425928#comment-17425928
]
Trejkaz commented on LUCENE-5572:
-
Note: The answer may in fact be Java, in which case I
[
https://issues.apache.org/jira/browse/LUCENE-5572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425927#comment-17425927
]
Trejkaz edited comment on LUCENE-5572 at 10/8/21, 3:00 AM:
---
A
[
https://issues.apache.org/jira/browse/LUCENE-5572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425927#comment-17425927
]
Trejkaz commented on LUCENE-5572:
-
A GUI application running outside our context is inte
zhaih commented on a change in pull request #225:
URL: https://github.com/apache/lucene/pull/225#discussion_r724613434
##
File path:
lucene/core/src/java/org/apache/lucene/util/automaton/ByteRunnable.java
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (
zhaih commented on pull request #346:
URL: https://github.com/apache/lucene/pull/346#issuecomment-938236733
Thanks @mikemccand ! Just added the entry, I always forget that lol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jtibshirani opened a new pull request #366:
URL: https://github.com/apache/lucene/pull/366
This PR adds support for using cosine similarity with kNN vector fields.
It takes a simple approach and doesn't attempt optimizations like normalizing
the query vector in advance, or performi
rmuir commented on a change in pull request #360:
URL: https://github.com/apache/lucene/pull/360#discussion_r724042253
##
File path:
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java
##
@@ -137,6 +137,14 @@ public ByteBuffersDataOutput(
this.blockReu
dweiss commented on a change in pull request #359:
URL: https://github.com/apache/lucene/pull/359#discussion_r723962970
##
File path: gradle/publishing/defaults-maven.gradle
##
@@ -80,6 +81,20 @@ configure(subprojects.findAll { it.path in
rootProject.published }) { prj ->
jpountz commented on a change in pull request #364:
URL: https://github.com/apache/lucene/pull/364#discussion_r723849356
##
File path:
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java
##
@@ -130,12 +130,45 @@ public NumericLeafComparator(LeafRea
mayya-sharipova commented on pull request #364:
URL: https://github.com/apache/lucene/pull/364#issuecomment-938131414
@jpountz Thank you for your feedback. I've addressed your comments in
c4814f248b976ae2ae23173fc27319cb69d1c17d. This is ready for another round of
review.
> I thin
dsmiley commented on a change in pull request #362:
URL: https://github.com/apache/lucene/pull/362#discussion_r724152591
##
File path:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java
##
@@ -86,7 +86,7 @@
* {@link #getFormatter(String
msokolov commented on a change in pull request #361:
URL: https://github.com/apache/lucene/pull/361#discussion_r724204344
##
File path: lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java
##
@@ -204,6 +207,64 @@ public void testScore() throws IOException {
markrmiller edited a comment on pull request #365:
URL: https://github.com/apache/lucene/pull/365#issuecomment-937821168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
[
https://issues.apache.org/jira/browse/LUCENE-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Sokolov resolved LUCENE-10147.
--
Resolution: Fixed
> KnnVectorQuery can produce negative scores
>
markrmiller commented on pull request #365:
URL: https://github.com/apache/lucene/pull/365#issuecomment-937514463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
dweiss commented on pull request #358:
URL: https://github.com/apache/lucene/pull/358#issuecomment-937056600
Dealing with this in scripts is nightmarish... but if you do want it then
you should:
- provide the defaults (empty string) if the variable is not defined,
- modify all scripts
mayya-sharipova commented on a change in pull request #364:
URL: https://github.com/apache/lucene/pull/364#discussion_r724507356
##
File path:
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java
##
@@ -130,12 +130,45 @@ public NumericLeafComparator
jpountz commented on a change in pull request #361:
URL: https://github.com/apache/lucene/pull/361#discussion_r723852770
##
File path: lucene/core/src/java/org/apache/lucene/util/VectorUtil.java
##
@@ -115,19 +115,23 @@ public static float squareDistance(float[] v1, float[]
v2
msokolov merged pull request #361:
URL: https://github.com/apache/lucene/pull/361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
madrob commented on pull request #2579:
URL: https://github.com/apache/lucene-solr/pull/2579#issuecomment-937996409
@ventry1990 can you add an entry to solr/CHANGES including how you would
like to be credited? Thank you for your patch!
--
This is an automated message from the Apache Git
dweiss commented on a change in pull request #360:
URL: https://github.com/apache/lucene/pull/360#discussion_r723900036
##
File path:
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java
##
@@ -137,6 +137,14 @@ public ByteBuffersDataOutput(
this.blockRe
jtibshirani commented on a change in pull request #361:
URL: https://github.com/apache/lucene/pull/361#discussion_r723760893
##
File path: lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java
##
@@ -204,6 +207,64 @@ public void testScore() throws IOException {
romseygeek commented on a change in pull request #362:
URL: https://github.com/apache/lucene/pull/362#discussion_r723952192
##
File path:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java
##
@@ -86,7 +86,7 @@
* {@link #getFormatter(Str
janhoy commented on a change in pull request #359:
URL: https://github.com/apache/lucene/pull/359#discussion_r723921857
##
File path: gradle/publishing/defaults-maven.gradle
##
@@ -80,6 +81,20 @@ configure(subprojects.findAll { it.path in
rootProject.published }) { prj ->
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425820#comment-17425820
]
Jan Høydahl commented on LUCENE-9488:
-
Congrats! No stress. I think we have some dec
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425783#comment-17425783
]
Dawid Weiss commented on LUCENE-9488:
-
Took me two hours to figure out why Nexus ret
mayya-sharipova commented on pull request #364:
URL: https://github.com/apache/lucene/pull/364#issuecomment-938131414
@jpountz Thank you for your feedback. I've addressed your comments in
c4814f248b976ae2ae23173fc27319cb69d1c17d. This is ready for another round of
review.
> I thin
[
https://issues.apache.org/jira/browse/LUCENE-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cameron VandenBerg updated LUCENE-10157:
Attachment: LUCENE-10157.patch
Status: Open (was: Open)
> Add Additional
mayya-sharipova commented on a change in pull request #364:
URL: https://github.com/apache/lucene/pull/364#discussion_r724507356
##
File path:
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java
##
@@ -130,12 +130,45 @@ public NumericLeafComparator
dweiss commented on a change in pull request #359:
URL: https://github.com/apache/lucene/pull/359#discussion_r724012317
##
File path: gradle/publishing/defaults-maven.gradle
##
@@ -80,6 +81,20 @@ configure(subprojects.findAll { it.path in
rootProject.published }) { prj ->
Cameron VandenBerg created LUCENE-10157:
---
Summary: Add Additional Indri Search Engine Functionality to Lucene
Key: LUCENE-10157
URL: https://issues.apache.org/jira/browse/LUCENE-10157
Project: Lu
[
https://issues.apache.org/jira/browse/LUCENE-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425746#comment-17425746
]
Adrien Grand commented on LUCENE-10151:
---
Another question I have is how to signal
[
https://issues.apache.org/jira/browse/LUCENE-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-10151:
-
Description:
I'd like to explore adding optional "timeout" capabilities to
{{IndexSearcher}}.
[
https://issues.apache.org/jira/browse/LUCENE-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425725#comment-17425725
]
ASF subversion and git services commented on LUCENE-10147:
--
Co
msokolov merged pull request #361:
URL: https://github.com/apache/lucene/pull/361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
madrob commented on pull request #2579:
URL: https://github.com/apache/lucene-solr/pull/2579#issuecomment-937996409
@ventry1990 can you add an entry to solr/CHANGES including how you would
like to be credited? Thank you for your patch!
--
This is an automated message from the Apache Git
markrmiller edited a comment on pull request #365:
URL: https://github.com/apache/lucene/pull/365#issuecomment-937514463
No frills type output possibilities.
```
Result "org.apache.lucene.bench.search.SearchPerf.term":
1163.320 ±(99.9%) 262.404 ops/s [Average]
(min,
[
https://issues.apache.org/jira/browse/LUCENE-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425689#comment-17425689
]
Adrien Grand commented on LUCENE-10153:
---
There's a nice ~5% indexing speedup on t
[
https://issues.apache.org/jira/browse/LUCENE-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425688#comment-17425688
]
Adrien Grand commented on LUCENE-10153:
---
This seems to be responsible for another
markrmiller commented on pull request #365:
URL: https://github.com/apache/lucene/pull/365#issuecomment-937960859
The **index**, **line doc file**, and **tasks file** can be generated via
the _lucene-util_ benchmark. The only current task is a **SearchPerf** task
that roughly emulates a _s
rmuir commented on a change in pull request #360:
URL: https://github.com/apache/lucene/pull/360#discussion_r724261686
##
File path:
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java
##
@@ -137,6 +137,14 @@ public ByteBuffersDataOutput(
this.blockReu
[
https://issues.apache.org/jira/browse/LUCENE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425606#comment-17425606
]
Animesh Pandey commented on LUCENE-9431:
[~dsmiley] yes it would be https://gith
jpountz commented on a change in pull request #361:
URL: https://github.com/apache/lucene/pull/361#discussion_r724238874
##
File path: lucene/core/src/java/org/apache/lucene/util/VectorUtil.java
##
@@ -115,19 +115,23 @@ public static float squareDistance(float[] v1, float[]
v2
markrmiller edited a comment on pull request #365:
URL: https://github.com/apache/lucene/pull/365#issuecomment-937821168
### Built in Profilers
You can see which are available to you and properly configured via `
./jmh.sh -lprof`
- Linux perf c2c profiler (shared C2C/HITM anal
markrmiller edited a comment on pull request #365:
URL: https://github.com/apache/lucene/pull/365#issuecomment-937821168
### Built in Profilers
You can see which are available to you and properly configured via `
./jmh.sh -lprof`
- Linux perf c2c profiler (shared C2C/HITM anal
markrmiller commented on pull request #365:
URL: https://github.com/apache/lucene/pull/365#issuecomment-937821168
### Built in Profilers
- Linux perf c2c profiler
- DTrace profile provider + PrintAssembly Profiler (OSX)
- async-profiler profiler provider (flamegraphs, jfr output
msokolov commented on a change in pull request #361:
URL: https://github.com/apache/lucene/pull/361#discussion_r724204344
##
File path: lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java
##
@@ -204,6 +207,64 @@ public void testScore() throws IOException {
[
https://issues.apache.org/jira/browse/LUCENE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425542#comment-17425542
]
David Smiley commented on LUCENE-9431:
--
Animesh; do you have a GitHub account? The
dsmiley commented on a change in pull request #362:
URL: https://github.com/apache/lucene/pull/362#discussion_r724152591
##
File path:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java
##
@@ -86,7 +86,7 @@
* {@link #getFormatter(String
rmuir commented on a change in pull request #360:
URL: https://github.com/apache/lucene/pull/360#discussion_r724042253
##
File path:
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java
##
@@ -137,6 +137,14 @@ public ByteBuffersDataOutput(
this.blockReu
dweiss commented on a change in pull request #359:
URL: https://github.com/apache/lucene/pull/359#discussion_r724012317
##
File path: gradle/publishing/defaults-maven.gradle
##
@@ -80,6 +81,20 @@ configure(subprojects.findAll { it.path in
rootProject.published }) { prj ->
janhoy commented on a change in pull request #359:
URL: https://github.com/apache/lucene/pull/359#discussion_r724007138
##
File path: gradle/publishing/defaults-maven.gradle
##
@@ -80,6 +81,20 @@ configure(subprojects.findAll { it.path in
rootProject.published }) { prj ->
markrmiller commented on pull request #365:
URL: https://github.com/apache/lucene/pull/365#issuecomment-937613511
Now we can pull some good clean perfasm:
Result "org.apache.lucene.bench.search.SearchPerf.orHighHigh":
46.523 ±(99.9%) 2.531 ops/s [Average]
(min, a
janhoy commented on a change in pull request #359:
URL: https://github.com/apache/lucene/pull/359#discussion_r724004710
##
File path: gradle/publishing/defaults-maven.gradle
##
@@ -80,6 +81,20 @@ configure(subprojects.findAll { it.path in
rootProject.published }) { prj ->
dweiss commented on a change in pull request #359:
URL: https://github.com/apache/lucene/pull/359#discussion_r723994990
##
File path: gradle/publishing/defaults-maven.gradle
##
@@ -80,6 +81,20 @@ configure(subprojects.findAll { it.path in
rootProject.published }) { prj ->
dweiss commented on a change in pull request #359:
URL: https://github.com/apache/lucene/pull/359#discussion_r723994570
##
File path: gradle/publishing/defaults-maven.gradle
##
@@ -80,6 +81,20 @@ configure(subprojects.findAll { it.path in
rootProject.published }) { prj ->
janhoy commented on a change in pull request #359:
URL: https://github.com/apache/lucene/pull/359#discussion_r723984623
##
File path: lucene/packaging/build.gradle
##
@@ -204,13 +220,15 @@ task assembleSourceDist() {
"archive",
Review comment:
Fair
janhoy commented on a change in pull request #359:
URL: https://github.com/apache/lucene/pull/359#discussion_r723983679
##
File path: gradle/publishing/defaults-maven.gradle
##
@@ -80,6 +81,20 @@ configure(subprojects.findAll { it.path in
rootProject.published }) { prj ->
[
https://issues.apache.org/jira/browse/LUCENE-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425424#comment-17425424
]
Adrien Grand commented on LUCENE-10145:
---
And a 7% indexing speedup for LatLonShap
dweiss commented on a change in pull request #359:
URL: https://github.com/apache/lucene/pull/359#discussion_r723964613
##
File path: lucene/packaging/build.gradle
##
@@ -204,13 +220,15 @@ task assembleSourceDist() {
"archive",
Review comment:
I thi
dweiss commented on a change in pull request #359:
URL: https://github.com/apache/lucene/pull/359#discussion_r723963480
##
File path: gradle/publishing/defaults-maven.gradle
##
@@ -58,6 +58,7 @@ configure(rootProject) {
]
apacheNexusSnapshots =
"https://repository.
dweiss commented on a change in pull request #359:
URL: https://github.com/apache/lucene/pull/359#discussion_r723962970
##
File path: gradle/publishing/defaults-maven.gradle
##
@@ -80,6 +81,20 @@ configure(subprojects.findAll { it.path in
rootProject.published }) { prj ->
romseygeek commented on a change in pull request #362:
URL: https://github.com/apache/lucene/pull/362#discussion_r723952192
##
File path:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java
##
@@ -86,7 +86,7 @@
* {@link #getFormatter(Str
[
https://issues.apache.org/jira/browse/LUCENE-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10153.
---
Fix Version/s: main (9.0)
Resolution: Fixed
> More speedups for operations on byte[]
[
https://issues.apache.org/jira/browse/LUCENE-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10125.
---
Fix Version/s: main (9.0)
Resolution: Fixed
I couldn't find an easy way to improve i
janhoy commented on a change in pull request #359:
URL: https://github.com/apache/lucene/pull/359#discussion_r723921857
##
File path: gradle/publishing/defaults-maven.gradle
##
@@ -80,6 +81,20 @@ configure(subprojects.findAll { it.path in
rootProject.published }) { prj ->
markrmiller commented on pull request #365:
URL: https://github.com/apache/lucene/pull/365#issuecomment-937514463
No frills type output possibilities.
`Result "org.apache.lucene.bench.search.SearchPerf.term":
1162.921 ±(99.9%) 215.504 ops/s [Average]
(min, avg, max) = (1101.
markrmiller opened a new pull request #365:
URL: https://github.com/apache/lucene/pull/365
This is not necessarily intended to be finished or merged, though a little
more at least will be done. Might be interesting to play with. Needs some
handle bars first likely
- [ ] handle bar
dweiss commented on a change in pull request #360:
URL: https://github.com/apache/lucene/pull/360#discussion_r723900036
##
File path:
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java
##
@@ -137,6 +137,14 @@ public ByteBuffersDataOutput(
this.blockRe
75 matches
Mail list logo
