rmuir commented on a change in pull request #360:
URL: https://github.com/apache/lucene/pull/360#discussion_r724042253
##########
File path:
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java
##########
@@ -137,6 +137,14 @@ public ByteBuffersDataOutput(
this.blockReuse = Objects.requireNonNull(blockReuse, "Block reuse must not
be null.");
}
Review comment:
I had the same problem. I tend to lean towards the defaults should be
fast, but the permissible values should be ones that work correctly.
It is also not efficient to use MMapDirectory with 4-byte memory mappings:
but it works correctly and we take advantage of this in testing.
Funny history to this test in question:
https://issues.apache.org/jira/browse/LUCENE-2627
##########
File path:
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java
##########
@@ -137,6 +137,14 @@ public ByteBuffersDataOutput(
this.blockReuse = Objects.requireNonNull(blockReuse, "Block reuse must not
be null.");
}
Review comment:
I am working on an updated commit: will be later this evening. Trying to
add some javadocs here anyway and stuff like that. I think in most cases users
should use the default or simple ctors (estimated size) and not specify min/max
block sizes directly anyway: we should label this one "expert". And reserve the
right to change it in the future (for example, if we aligned our index files to
at least 8 bytes, we could then make `1 << 3` the minimum size and simplify a
ton of code: none of the primitive-type reads would ever span boundaries
anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
