dweiss commented on a change in pull request #359:
URL: https://github.com/apache/lucene/pull/359#discussion_r723964613
##########
File path: lucene/packaging/build.gradle
##########
@@ -204,13 +220,15 @@ task assembleSourceDist() {
"archive",
Review comment:
I think it should be the entire source tree. If it's messy with CI
configs, etc., so be it - it's still the full source tree. In theory you should
be able to take that and rebuild the exact same distribution. Why bother
excluding stuff?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
