dweiss commented on a change in pull request #359:
URL: https://github.com/apache/lucene/pull/359#discussion_r723962970
##########
File path: gradle/publishing/defaults-maven.gradle
##########
@@ -80,6 +81,20 @@ configure(subprojects.findAll { it.path in
rootProject.published }) { prj ->
}
}
}
+
+ maven {
+ name = "ApacheReleases"
+ url = apacheNexusReleases
+
+ credentials {
+ def nexusUserName =
rootProject.propertyOrDefault('asfNexusUsername', null)
Review comment:
Is this a special kind of permission? I tried the above and it seems I
should be able to do a release (as a project/ pmc member) yet I get HTTP 400.
Can you try with your credentials and see what happens?
##########
File path: gradle/publishing/defaults-maven.gradle
##########
@@ -58,6 +58,7 @@ configure(rootProject) {
]
apacheNexusSnapshots =
"https://repository.apache.org/content/repositories/snapshots";
+ apacheNexusReleases =
"https://repository.apache.org/service/local/staging/deploy/maven2";
Review comment:
Yeah - I'll clean this all up once I can get it to work (once I can
stage artifacts).
##########
File path: lucene/packaging/build.gradle
##########
@@ -204,13 +220,15 @@ task assembleSourceDist() {
"archive",
Review comment:
I think it should be the entire source tree. If it's messy with CI
configs, etc., so be it - it's still the full source tree. In theory you should
be able to take that and rebuild the exact same distribution. Why bother
excluding stuff?
##########
File path: gradle/publishing/defaults-maven.gradle
##########
@@ -80,6 +81,20 @@ configure(subprojects.findAll { it.path in
rootProject.published }) { prj ->
}
}
}
+
+ maven {
+ name = "ApacheReleases"
+ url = apacheNexusReleases
+
+ credentials {
+ def nexusUserName =
rootProject.propertyOrDefault('asfNexusUsername', null)
Review comment:
That's the thing - it's not the same. I can log in there as well and see
the repositories but I can't push anything from within gradle, even if the same
credentials are used. Can you try this and see what happens?
gradlew publishJarsPublicationToApacheReleasesRepository -PasfNexusUsername=
-PasfNexusPassword=
##########
File path: gradle/publishing/defaults-maven.gradle
##########
@@ -80,6 +81,20 @@ configure(subprojects.findAll { it.path in
rootProject.published }) { prj ->
}
}
}
+
+ maven {
+ name = "ApacheReleases"
+ url = apacheNexusReleases
+
+ credentials {
+ def nexusUserName =
rootProject.propertyOrDefault('asfNexusUsername', null)
Review comment:
(on the PR branch I posted)
##########
File path: gradle/publishing/defaults-maven.gradle
##########
@@ -80,6 +81,20 @@ configure(subprojects.findAll { it.path in
rootProject.published }) { prj ->
}
}
}
+
+ maven {
+ name = "ApacheReleases"
+ url = apacheNexusReleases
+
+ credentials {
+ def nexusUserName =
rootProject.propertyOrDefault('asfNexusUsername', null)
Review comment:
Sure. I'll take another look in the evening myself. Maybe try the ant
release staging. The repository "id" is really important - it's the nexus
upload URL that matters here. I'll take another look.
##########
File path: gradle/publishing/defaults-maven.gradle
##########
@@ -80,6 +81,20 @@ configure(subprojects.findAll { it.path in
rootProject.published }) { prj ->
}
}
}
+
+ maven {
+ name = "ApacheReleases"
+ url = apacheNexusReleases
+
+ credentials {
+ def nexusUserName =
rootProject.propertyOrDefault('asfNexusUsername', null)
Review comment:
Sure. I'll take another look in the evening myself. Maybe try the ant
release staging. The repository "id" is not really important - it's the nexus
upload URL that matters here. I'll take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
