[
https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405002#comment-17405002
]
weizijun commented on LUCENE-10033:
---
Hi, [~jpountz], [~gsmiller], I run luceneutil: p
[
https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
weizijun updated LUCENE-10033:
--
Attachment: benchmark
> Encode doc values in smaller blocks of values, like postings
> --
[
https://issues.apache.org/jira/browse/LUCENE-10051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xiaoshi updated LUCENE-10051:
-
Comment: was deleted
(was: This error is the same as LUCENE-10058, I fixed them separately.)
> lucene
[
https://issues.apache.org/jira/browse/LUCENE-10051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404977#comment-17404977
]
xiaoshi commented on LUCENE-10051:
--
This error is the same as LUCENE-10058, I fixed th
[
https://issues.apache.org/jira/browse/LUCENE-10051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401799#comment-17401799
]
xiaoshi edited comment on LUCENE-10051 at 8/26/21, 6:15 AM:
[
https://issues.apache.org/jira/browse/LUCENE-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404882#comment-17404882
]
Greg Miller commented on LUCENE-10062:
--
The performance improvement, as measured b
gsmiller opened a new pull request #264:
URL: https://github.com/apache/lucene/pull/264
# Description
In benchmarks, using numeric doc values to store taxonomy facet ordinals
shows almost a 400% qps improvement in browse-related taxonomy-based tasks
(instead of custom delta-encoding
zacharymorn commented on a change in pull request #128:
URL: https://github.com/apache/lucene/pull/128#discussion_r696251777
##
File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
##
@@ -3787,8 +4032,12 @@ public int doCheck(Options opts) throws IOException,
zacharymorn commented on pull request #128:
URL: https://github.com/apache/lucene/pull/128#issuecomment-906051631
> Sorry for taking so long to respond @zacharymorn! This change looks great
-- I left a bunch of minor comments. Thank you for getting the output to match
what we see today, an
zacharymorn commented on a change in pull request #128:
URL: https://github.com/apache/lucene/pull/128#discussion_r696246368
##
File path: lucene/test-framework/src/java/org/apache/lucene/util/TestUtil.java
##
@@ -321,6 +326,11 @@ public static void syncConcurrentMerges(MergeSc
zacharymorn commented on a change in pull request #128:
URL: https://github.com/apache/lucene/pull/128#discussion_r696248395
##
File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
##
@@ -843,6 +825,258 @@ public Status checkIndex(List onlySegments)
throws I
zacharymorn commented on a change in pull request #128:
URL: https://github.com/apache/lucene/pull/128#discussion_r696247199
##
File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
##
@@ -181,6 +193,9 @@
/** True if we were able to open a CodecReader o
zacharymorn commented on a change in pull request #128:
URL: https://github.com/apache/lucene/pull/128#discussion_r696247145
##
File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
##
@@ -605,209 +680,103 @@ public Status checkIndex(List onlySegments)
throws
Zach Chen created LUCENE-10071:
--
Summary: Review and refactor synchronization handling between
MockDirectoryWrapper and CheckIndex
Key: LUCENE-10071
URL: https://issues.apache.org/jira/browse/LUCENE-10071
zacharymorn commented on a change in pull request #128:
URL: https://github.com/apache/lucene/pull/128#discussion_r696246368
##
File path: lucene/test-framework/src/java/org/apache/lucene/util/TestUtil.java
##
@@ -321,6 +326,11 @@ public static void syncConcurrentMerges(MergeSc
zacharymorn commented on a change in pull request #128:
URL: https://github.com/apache/lucene/pull/128#discussion_r696243823
##
File path: lucene/core/src/test/org/apache/lucene/index/TestCheckIndex.java
##
@@ -54,4 +65,137 @@ public void testChecksumsOnlyVerbose() throws IOExc
zacharymorn commented on a change in pull request #240:
URL: https://github.com/apache/lucene/pull/240#discussion_r696243140
##
File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java
##
@@ -520,10 +458,39 @@ private DrillDownQuery getDrillDownQuery(
}
[
https://issues.apache.org/jira/browse/LUCENE-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404841#comment-17404841
]
FengFeng Cheng commented on LUCENE-9969:
Maybe the description of the problem IN
[
https://issues.apache.org/jira/browse/LUCENE-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404829#comment-17404829
]
FengFeng Cheng commented on LUCENE-9969:
I'm very sorry, my English is not good.
[
https://issues.apache.org/jira/browse/LUCENE-10070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404814#comment-17404814
]
Greg Miller commented on LUCENE-10070:
--
This should be a very easy fix and perfect
[
https://issues.apache.org/jira/browse/LUCENE-10070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404811#comment-17404811
]
Greg Miller commented on LUCENE-10070:
--
See tests in this PR for repro: https://gi
gsmiller opened a new pull request #263:
URL: https://github.com/apache/lucene/pull/263
NOCOMMIT: Just illustrating bugs identified in LUCENE-10070. If someone
wants to work on this issue, feel free to grab these tests to confirm a working
patch.
--
This is an automated message from the
Greg Miller created LUCENE-10070:
Summary: "count all" faceting functionality counts deleted docs
for multiple implementations
Key: LUCENE-10070
URL: https://issues.apache.org/jira/browse/LUCENE-10070
gautamworah96 commented on a change in pull request #179:
URL: https://github.com/apache/lucene/pull/179#discussion_r696169642
##
File path:
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestDirectoryTaxonomyReader.java
##
@@ -567,4 +567,39 @@ public void te
gautamworah96 commented on a change in pull request #179:
URL: https://github.com/apache/lucene/pull/179#discussion_r696169458
##
File path: lucene/CHANGES.txt
##
@@ -137,6 +137,9 @@ API Changes
Improvements
+* LUCENE-9476: Add new getBulkPath API to DirectoryTaxonomyReade
gautamworah96 commented on a change in pull request #179:
URL: https://github.com/apache/lucene/pull/179#discussion_r696168048
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java
##
@@ -351,12 +349,139 @@ public FacetLabe
gautamworah96 commented on a change in pull request #179:
URL: https://github.com/apache/lucene/pull/179#discussion_r696168048
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java
##
@@ -351,12 +349,139 @@ public FacetLabe
gautamworah96 commented on a change in pull request #179:
URL: https://github.com/apache/lucene/pull/179#discussion_r696167851
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java
##
@@ -351,12 +348,140 @@ public FacetLabe
[
https://issues.apache.org/jira/browse/LUCENE-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404756#comment-17404756
]
Gautam Worah commented on LUCENE-9990:
--
Thanks [~dweiss], I'll try to run some chec
jtibshirani commented on a change in pull request #262:
URL: https://github.com/apache/lucene/pull/262#discussion_r696153258
##
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextKnnVectorsReader.java
##
@@ -140,7 +147,38 @@ public VectorValues get
[
https://issues.apache.org/jira/browse/LUCENE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404722#comment-17404722
]
ASF subversion and git services commented on LUCENE-10003:
--
Co
dsmiley merged pull request #206:
URL: https://github.com/apache/lucene/pull/206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
msokolov commented on pull request #259:
URL: https://github.com/apache/lucene/pull/259#issuecomment-905848042
you make it look so easy :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
[
https://issues.apache.org/jira/browse/LUCENE-10069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404690#comment-17404690
]
Michael Sokolov edited comment on LUCENE-10069 at 8/25/21, 8:01 PM:
-
[
https://issues.apache.org/jira/browse/LUCENE-10069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404690#comment-17404690
]
Michael Sokolov edited comment on LUCENE-10069 at 8/25/21, 8:01 PM:
-
[
https://issues.apache.org/jira/browse/LUCENE-10069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404690#comment-17404690
]
Michael Sokolov commented on LUCENE-10069:
--
also, I found it is easy to reprod
[
https://issues.apache.org/jira/browse/LUCENE-10069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404687#comment-17404687
]
Michael Sokolov commented on LUCENE-10069:
--
I think that because we prune neig
[
https://issues.apache.org/jira/browse/LUCENE-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-10060:
-
Description:
We need to make sure DSQ instances don't end up in the query cache. -It's
importa
[
https://issues.apache.org/jira/browse/LUCENE-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-10060:
-
Description:
We need to make sure DSQ instances don't end up in the query cache. -It's
importa
msokolov opened a new pull request #262:
URL: https://github.com/apache/lucene/pull/262
simple linear scan brute force vector search impl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
[
https://issues.apache.org/jira/browse/LUCENE-10063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404636#comment-17404636
]
Michael Sokolov commented on LUCENE-10063:
--
Thanks for opening Adrien; I agree
rmuir commented on a change in pull request #260:
URL: https://github.com/apache/lucene/pull/260#discussion_r695948921
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java
##
@@ -780,6 +780,104 @@ public SortedDocValues getSorted(
xiaoshi2013 edited a comment on pull request #253:
URL: https://github.com/apache/lucene/pull/253#issuecomment-905706189
> Thanks @xiaoshi2013! Could you also open a backport PR against
[`branch_8x` in `lucene-solr` github
repository](https://github.com/apache/lucene-solr/tree/branch_8x)?
[
https://issues.apache.org/jira/browse/LUCENE-10058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xiaoshi updated LUCENE-10058:
-
Status: Patch Available (was: Open)
> lucene main(9.0) run ./gradlew lucene:benchmark:run error
> ---
[
https://issues.apache.org/jira/browse/LUCENE-10051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xiaoshi updated LUCENE-10051:
-
Status: Patch Available (was: Open)
> lucene branch_8x run ant run-task error
> -
xiaoshi2013 removed a comment on pull request #253:
URL: https://github.com/apache/lucene/pull/253#issuecomment-904703578
As you suggested, I have also submitted a PR for lucene_8x: LUCENE-10051,
thanks.
At 2021-08-23 22:37:45, "Michael McCandless"
xiaoshi2013 commented on pull request #253:
URL: https://github.com/apache/lucene/pull/253#issuecomment-905706189
> Thanks @xiaoshi2013! Could you also open a backport PR against
[`branch_8x` in `lucene-solr` github
repository](https://github.com/apache/lucene-solr/tree/branch_8x)? Thanks!
gsmiller commented on a change in pull request #261:
URL: https://github.com/apache/lucene/pull/261#discussion_r695918317
##
File path: lucene/CHANGES.txt
##
@@ -467,6 +467,8 @@ Bug Fixes
* LUCENE-10008: Respect ignoreCase in CommonGramsFilterFactory (Vigya Sharma)
+* LUCE
[
https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404583#comment-17404583
]
Greg Miller commented on LUCENE-10033:
--
Yeah, it's tricky [~jpountz]. I wonder how
[
https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404583#comment-17404583
]
Greg Miller edited comment on LUCENE-10033 at 8/25/21, 4:25 PM:
-
[
https://issues.apache.org/jira/browse/LUCENE-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404577#comment-17404577
]
Greg Miller commented on LUCENE-10060:
--
OK, I was wrong about my initial concern t
[
https://issues.apache.org/jira/browse/LUCENE-10052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404575#comment-17404575
]
ASF subversion and git services commented on LUCENE-10052:
--
Co
mikemccand merged pull request #258:
URL: https://github.com/apache/lucene/pull/258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
gsmiller commented on a change in pull request #240:
URL: https://github.com/apache/lucene/pull/240#discussion_r695909915
##
File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java
##
@@ -520,10 +458,39 @@ private DrillDownQuery getDrillDownQuery(
}
gsmiller opened a new pull request #261:
URL: https://github.com/apache/lucene/pull/261
# Description
We need to ensure `DrillSidewaysQuery` instances never get cached. The
process of caching the results ignores deleted docs (`null` `acceptDocs` passed
to the `BulkScorer`). This is
jpountz commented on a change in pull request #224:
URL: https://github.com/apache/lucene/pull/224#discussion_r695896655
##
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextSkipReader.java
##
@@ -147,28 +147,6 @@ protected int readSkipData(int le
wuda0112 commented on a change in pull request #224:
URL: https://github.com/apache/lucene/pull/224#discussion_r695867514
##
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextSkipReader.java
##
@@ -147,28 +147,6 @@ protected int readSkipData(int l
[
https://issues.apache.org/jira/browse/LUCENE-10059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404552#comment-17404552
]
Tomoko Uchida commented on LUCENE-10059:
I'm sorry, I'm not familiar with the p
[
https://issues.apache.org/jira/browse/LUCENE-9613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404486#comment-17404486
]
Adrien Grand commented on LUCENE-9613:
--
By removing the wrapping of NumericDocValue
[
https://issues.apache.org/jira/browse/LUCENE-10059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404476#comment-17404476
]
Michael Sokolov commented on LUCENE-10059:
--
> Should we try to have a base cla
[
https://issues.apache.org/jira/browse/LUCENE-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404450#comment-17404450
]
Dawid Weiss commented on LUCENE-10066:
--
Created a PR that upgrades spotless and ad
jpountz commented on pull request #224:
URL: https://github.com/apache/lucene/pull/224#issuecomment-905487573
This looks good to me. Since we don't need to encode these numbers
differently maybe we could have a single abstract method, e.g.
MultiLevelSkipListWriter
```java
[
https://issues.apache.org/jira/browse/LUCENE-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404428#comment-17404428
]
Michael McCandless commented on LUCENE-10067:
-
{quote}It's a good thing the
[
https://issues.apache.org/jira/browse/LUCENE-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404425#comment-17404425
]
Michael Sokolov commented on LUCENE-10067:
--
> nd thank you nightly benchmarks
[
https://issues.apache.org/jira/browse/LUCENE-9613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404419#comment-17404419
]
Adrien Grand commented on LUCENE-9613:
--
I pushed some more specialization that gave
[
https://issues.apache.org/jira/browse/LUCENE-9613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404416#comment-17404416
]
ASF subversion and git services commented on LUCENE-9613:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404417#comment-17404417
]
ASF subversion and git services commented on LUCENE-10067:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-9613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404408#comment-17404408
]
Adrien Grand commented on LUCENE-9613:
--
Since this change didn't change the on-disk
[
https://issues.apache.org/jira/browse/LUCENE-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404405#comment-17404405
]
Michael McCandless commented on LUCENE-10067:
-
Thanks [~rcmuir] – I added a
[
https://issues.apache.org/jira/browse/LUCENE-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404406#comment-17404406
]
Michael McCandless commented on LUCENE-10067:
-
And thank you nightly benchm
[
https://issues.apache.org/jira/browse/LUCENE-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404398#comment-17404398
]
Adrien Grand commented on LUCENE-10067:
---
I believe it's LUCENE-9613 too since thi
mikemccand commented on a change in pull request #128:
URL: https://github.com/apache/lucene/pull/128#discussion_r694932614
##
File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
##
@@ -450,6 +480,14 @@ public void setChecksumsOnly(boolean v) {
private
[
https://issues.apache.org/jira/browse/LUCENE-9613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404360#comment-17404360
]
Michael McCandless commented on LUCENE-9613:
I am not certain, but this chan
mikemccand opened a new pull request #258:
URL: https://github.com/apache/lucene/pull/258
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Please provide a short description of the approach take
wuda0112 edited a comment on pull request #224:
URL: https://github.com/apache/lucene/pull/224#issuecomment-905393867
> Let's give this a try.
I tried to define the methods, but i am not sure is it fit, if this
correct, i will create a new issuse, and if this is your concern issuse,
wuda0112 commented on pull request #224:
URL: https://github.com/apache/lucene/pull/224#issuecomment-905393867
> Let's give this a try.
I tried to define the methods, but i am not sure is it fit, if this
correct, i will create a new issuse, and if this is your concern issuse, could
[
https://issues.apache.org/jira/browse/LUCENE-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404309#comment-17404309
]
Geoffrey Lawson commented on LUCENE-9963:
-
Yes, I agree
> Flatten graph filter
[
https://issues.apache.org/jira/browse/LUCENE-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Geoffrey Lawson resolved LUCENE-9963.
-
Resolution: Fixed
> Flatten graph filter has errors when there are holes at beginning or
[
https://issues.apache.org/jira/browse/LUCENE-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9990.
-
Resolution: Fixed
I've applied this patch since it moves us forward and is not crucial to
anyth
[
https://issues.apache.org/jira/browse/LUCENE-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404264#comment-17404264
]
ASF subversion and git services commented on LUCENE-9990:
-
Commi
dweiss closed pull request #175:
URL: https://github.com/apache/lucene/pull/175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
[
https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404255#comment-17404255
]
Adrien Grand commented on LUCENE-10033:
---
Thanks a lot for running these tests [~g
82 matches
Mail list logo
