jtibshirani commented on a change in pull request #262:
URL: https://github.com/apache/lucene/pull/262#discussion_r696153258
##########
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextKnnVectorsReader.java
##########
@@ -140,7 +147,38 @@ public VectorValues getVectorValues(String field) throws
IOException {
@Override
public TopDocs search(String field, float[] target, int k, Bits acceptDocs)
throws IOException {
- throw new UnsupportedOperationException();
+ VectorValues values = getVectorValues(field);
Review comment:
If the field exists but vectors are not enabled, then I think we'll get
`VectorValues.EMPTY` here, and either trip on `target.length !=
values.dimension()` or return an empty `TopDocs`? It could cleaner to catch
this early and return `null` as we do for `Lucene90HnswVectorsReader`. Maybe
this would involve changing `getVectorValues` to return `null` if vectors are
not enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
