[
https://issues.apache.org/jira/browse/LUCENE-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404577#comment-17404577
]
Greg Miller commented on LUCENE-10060:
--------------------------------------
OK, I was wrong about my initial concern that the {{DrillSidewaysScorer}} would
not get invoked each time if it's cached. It turns out that
{{DrillSidewaysQuery}} doesn't implement {{equals}}, so when it goes through a
caching path, it just gets "re-cached" every time (doh!). But, the "accept
docs" issue pointed out by [~zacharymorn] is a very real problem. I was able to
repro it with a unit test reliably and posted a PR with that test and a fix.
https://github.com/apache/lucene/pull/261
> Ensure DrillSidewaysQuery instances don't get cached
> ----------------------------------------------------
>
> Key: LUCENE-10060
> URL: https://issues.apache.org/jira/browse/LUCENE-10060
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/facet
> Reporter: Greg Miller
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We need to make sure DSQ instances don't end up in the query cache. It's
> important that the {{DrillSidewaysScorer}} (bulk scorer implementation)
> actually runs during query evaluation in order to populate the "sideways"
> \{{FacetsCollector}}s with "near miss" docs. If it gets cached, this won't
> happen.
> There may also be an implication around {{acceptDocs}} getting honored as
> well. [~zacharymorn] may be able to provide more details.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
