jpountz commented on pull request #224:
URL: https://github.com/apache/lucene/pull/224#issuecomment-905487573
This looks good to me. Since we don't need to encode these numbers
differently maybe we could have a single abstract method, e.g.
MultiLevelSkipListWriter
```java
/**
* Write a small positive long on a variable number of bytes.
*
* @param l the long to write
* @param out the output to write to
*/
protected void writeVLong(long l, DataOutput out) throws IOException{
out.writeVLong(l);
}
```
MultiLevelSkipListReader
```java
/**
* Read a long written via {@link MultiLevelSkipListWriter#writeVLong}.
*
* @param in the IndexInput to read from
*/
protected long readVLong(IndexInput in) throws IOException {
return in.readVLong();
}
```
This is a small enough change to an internal class that I don't feel the
need to open a separate issue, we could do it on this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
