jpountz edited a comment on pull request #180:
URL: https://github.com/apache/lucene/pull/180#issuecomment-861482554
> +1 to fix the test
I've come up with a simple fix in
https://github.com/apache/lucene/pull/180/commits/5520c5d0aed30fdb3231f920881cd2c685153267.
Please let me know
gsmiller commented on pull request #181:
URL: https://github.com/apache/lucene/pull/181#issuecomment-861881544
@gautamworah96 thanks for the feedback! Adrien and I have been having some
conversation around whether-or-not this change makes sense over in the Jira
issue. As a result, I'm goin
gsmiller commented on a change in pull request #181:
URL: https://github.com/apache/lucene/pull/181#discussion_r652200243
##
File path: lucene/core/src/java/org/apache/lucene/search/MultiCollector.java
##
@@ -25,13 +25,39 @@
/**
* A {@link Collector} which allows running a s
jpountz commented on pull request #92:
URL: https://github.com/apache/lucene/pull/92#issuecomment-861638216
If you look at `BaseMergePolicyTestCase` and `TestTieredMergePolicy`, we
actually have tests that simulate merges in order to verify that things like
the maximum percentage of delete
jpountz commented on pull request #92:
URL: https://github.com/apache/lucene/pull/92#issuecomment-861634770
If I read this line correctly, it says that large segments (more than 50%
the maximum segment size) shouldn't be merged unless both the percentage of
deletes of the segment and the p
[
https://issues.apache.org/jira/browse/LUCENE-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-9998.
--
Fix Version/s: (was: 8.6.2)
main (9.0)
Resolution: Fixed
> The p
[
https://issues.apache.org/jira/browse/LUCENE-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363694#comment-17363694
]
ASF subversion and git services commented on LUCENE-9998:
-
Commi
jpountz merged pull request #183:
URL: https://github.com/apache/lucene/pull/183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please co
jimczi commented on a change in pull request #185:
URL: https://github.com/apache/lucene/pull/185#discussion_r651810484
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiNormsLeafSimScorer.java
##
@@ -80,9 +80,7 @@
}
private long getNormValue(
[
https://issues.apache.org/jira/browse/LUCENE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363644#comment-17363644
]
Robert Muir commented on LUCENE-10003:
--
My concern is really beyond when the tool
uschindler commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-861496169
In the next Panama iteration, there will also be a ready-to use copy method,
which has same shape as methods added for bulk copy:
https://github.com/openjdk/panama-foreign/pull/
[
https://issues.apache.org/jira/browse/LUCENE-10001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363632#comment-17363632
]
Greg Miller commented on LUCENE-10001:
--
Thanks [~jpountz]! I'll clarify a bit but
kkewwei commented on pull request #183:
URL: https://github.com/apache/lucene/pull/183#issuecomment-861494424
I have added the note, please check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
uschindler edited a comment on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-861492558
The issue is confirmed and for the readBytes() code there's already a
workaround. Long term we will improve to have this for all array types. See
discussion here: https:/
uschindler commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-861492558
The issue is confirmed and for the readBytes() code there's already a
workaround. Long term we will improve
For the float and long options: copyMemory() has some overhead
jpountz commented on pull request #180:
URL: https://github.com/apache/lucene/pull/180#issuecomment-861482554
+1 to fix the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
jpountz commented on pull request #183:
URL: https://github.com/apache/lucene/pull/183#issuecomment-861480777
Right above line 130 (`Improvements`) in `lucene/CHANGES.txt` on your
working copy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
jpountz commented on a change in pull request #185:
URL: https://github.com/apache/lucene/pull/185#discussion_r651759489
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiNormsLeafSimScorer.java
##
@@ -80,9 +80,7 @@
}
private long getNormValue
[
https://issues.apache.org/jira/browse/LUCENE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363613#comment-17363613
]
Adrien Grand commented on LUCENE-10004:
---
Order is important because it implicitly
[
https://issues.apache.org/jira/browse/LUCENE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363607#comment-17363607
]
Dawid Weiss commented on LUCENE-10003:
--
You'd need to edit github workflow config
[
https://issues.apache.org/jira/browse/LUCENE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363603#comment-17363603
]
David Smiley commented on LUCENE-10003:
---
I think it's enough for GitHub PRs to do
[
https://issues.apache.org/jira/browse/LUCENE-9935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363578#comment-17363578
]
ASF subversion and git services commented on LUCENE-9935:
-
Commi
dnhatn merged pull request #182:
URL: https://github.com/apache/lucene/pull/182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please con
dnhatn commented on pull request #182:
URL: https://github.com/apache/lucene/pull/182#issuecomment-861408329
Thanks @jpountz.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
glawson0 commented on pull request #157:
URL: https://github.com/apache/lucene/pull/157#issuecomment-861386826
>Maybe another way to improve the checking for correctness in the randomized
test (or maybe in a new randomized test) would be to randomly generate a set of
strings from a limited
[
https://issues.apache.org/jira/browse/LUCENE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363529#comment-17363529
]
kkewwei edited comment on LUCENE-10004 at 6/15/21, 10:31 AM:
[
https://issues.apache.org/jira/browse/LUCENE-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363531#comment-17363531
]
Jim Ferenczi commented on LUCENE-:
--
I opened https://github.com/apache/lucene/p
jimczi opened a new pull request #185:
URL: https://github.com/apache/lucene/pull/185
This change fixes a bug in `MultiNormsLeafSimScorer` that assumes that each
field should have a norm for every term/document.
--
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/LUCENE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363529#comment-17363529
]
kkewwei edited comment on LUCENE-10004 at 6/15/21, 10:16 AM:
[
https://issues.apache.org/jira/browse/LUCENE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363529#comment-17363529
]
kkewwei commented on LUCENE-10004:
--
There seems no need to guarantee the order of stor
kkewwei commented on pull request #183:
URL: https://github.com/apache/lucene/pull/183#issuecomment-861367299
Of course, Can you tell me where I can add the node? I can't find the place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
uschindler commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-861362120
I opened https://bugs.openjdk.java.net/browse/JDK-8268743 about the object
allocations.
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/LUCENE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363483#comment-17363483
]
Adrien Grand commented on LUCENE-10004:
---
I believe that it's actually important t
[
https://issues.apache.org/jira/browse/LUCENE-10001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363477#comment-17363477
]
Adrien Grand commented on LUCENE-10001:
---
Can you help me understand the use-case
jpountz edited a comment on pull request #184:
URL: https://github.com/apache/lucene/pull/184#issuecomment-861287012
On this simple test, memory usage for a single doc in the DWPT goes from
9.6MB to 1.4MB.
```java
import org.apache.lucene.document.Document;
import org.apache.lu
jpountz commented on pull request #184:
URL: https://github.com/apache/lucene/pull/184#issuecomment-861287012
On this very simple test, memory usage for a single doc in the DWPT goes
from 9.6MB to 1.4MB.
```java
import org.apache.lucene.document.Document;
import org.apache.luce
jpountz opened a new pull request #184:
URL: https://github.com/apache/lucene/pull/184
With this change, doc-value terms dictionaries use a shared `ByteBlockPool`
across all fields, and points, binary doc values and doc-value ordinals use
slightly smaller page sizes.
--
This is an a
kkewwei opened a new pull request #183:
URL: https://github.com/apache/lucene/pull/183
# Description
the paramater `fis` in In StoredFieldsWriter.finish() and
TermVectorsWriter.finish() is useless, and deleting it would help simplify the
API.
# Solution
Deleting it from StoredFiel
uschindler commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-861265227
I also ran the same with tiered compilation turned on and no `-Xbatch` (java
defaults). The results are much better, but still the heap allocations are done.
For long-runn
[
https://issues.apache.org/jira/browse/LUCENE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kkewwei updated LUCENE-10004:
-
Description:
In CompressingStoredFieldsWriter.merge(): if the segment meet the following
conditions:
{
40 matches
Mail list logo
