[
https://issues.apache.org/jira/browse/LUCENE-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363694#comment-17363694
]
ASF subversion and git services commented on LUCENE-9998:
---------------------------------------------------------
Commit b7b834b75681ff5be6aaa1c052d6a708f723b31d in lucene's branch
refs/heads/main from kkewwei
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=b7b834b ]
LUCENE-9998: delete useless param fis in StoredFieldsWriter.finish() and
TermVectorsWriter.finish() (#183)
> The param 'fis' in StoredFieldsWriter.finish(FieldInfos fis, int numDocs) is
> never used
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-9998
> URL: https://issues.apache.org/jira/browse/LUCENE-9998
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/codecs
> Affects Versions: 8.6.2
> Reporter: kkewwei
> Priority: Minor
> Fix For: 8.6.2
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> We can see the `FieldInfos fis` in StoredFieldsWriter.finish(FieldInfos fis,
> int numDocs) is never used.
> The class has four subclasses:
> Lucene90CompressingStoredFieldsWriter,Lucene50CompressingStoredFieldsWriter,CrankyStoredFieldsWriter,SimpleTextStoredFieldsWriter.
> the function `finish` in all four subclasses never use `fis`, if we could
> remove it from the function.
> The same situation with the function `finish` in TermVectorsWriter.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
