[ 
https://issues.apache.org/jira/browse/LUCENE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363603#comment-17363603
 ] 

David Smiley commented on LUCENE-10003:
---------------------------------------

I think it's enough for GitHub PRs to do the checks, and thus don't fail CI 
builds.  Could/should "precommit" be made to be equivalent and run error-prone? 
 I share Rob's concern of not wanting checks that only occur in nightly jobs, 
which is rather annoying to deal with for non-errors especially.  I *think* the 
intention with our error-prone config was that over time we'd improve more and 
more of the code and then we'd be able to let error-prone run more of it's 
available rules.  ~114 rules are disabled in error-prone.gradle today.

> Disallow C-style array declarations
> -----------------------------------
>
>                 Key: LUCENE-10003
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10003
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>
> The Google Java Format, that which we adhere to, disallows c-style array 
> declarations: https://google.github.io/styleguide/javaguide.html#s4.8.3-arrays
> It's also known to "Error Prone":
> https://errorprone.info/bugpattern/MixedArrayDimensions



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to