kkewwei opened a new pull request #183: URL: https://github.com/apache/lucene/pull/183
# Description the paramater `fis` in In StoredFieldsWriter.finish() and TermVectorsWriter.finish() is useless, and deleting it would help simplify the API. # Solution Deleting it from StoredFieldsWriter.finish() and TermVectorsWriter.finish(), including those subclasses # Tests Just run ./gradlew precommit ./gradlew test ./gradlew check # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
