[
https://issues.apache.org/jira/browse/LUCENE-9983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357749#comment-17357749
]
Haoyu Zhai commented on LUCENE-9983:
I just realized that we've already had several
gsmiller opened a new pull request #169:
URL: https://github.com/apache/lucene/pull/169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pl
[
https://issues.apache.org/jira/browse/LUCENE-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-9991:
Description:
As reported by [~julietibs] in LUCENE-9950, there's a randomized test failure
in {{T
[
https://issues.apache.org/jira/browse/LUCENE-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller resolved LUCENE-9991.
-
Fix Version/s: main (9.0)
Resolution: Fixed
> Fix TestStringValueFacetCounts
> --
[
https://issues.apache.org/jira/browse/LUCENE-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gautam Worah updated LUCENE-9990:
-
Description:
Gradle 7 has added support for running builds with arbitrary JVMs.
Today, Gradle 6
[
https://issues.apache.org/jira/browse/LUCENE-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gautam Worah updated LUCENE-9990:
-
Description:
Gradle 7 has added support for running builds with arbitrary JVMs.
Today, Gradle 6
[
https://issues.apache.org/jira/browse/LUCENE-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357646#comment-17357646
]
ASF subversion and git services commented on LUCENE-9991:
-
Commi
gsmiller merged pull request #168:
URL: https://github.com/apache/lucene/pull/168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
[
https://issues.apache.org/jira/browse/LUCENE-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357634#comment-17357634
]
Dawid Weiss commented on LUCENE-9990:
-
Thanks! I'll be able to look through the chan
[
https://issues.apache.org/jira/browse/LUCENE-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357610#comment-17357610
]
Greg Miller commented on LUCENE-9991:
-
PR up. It's very minor and the change is just
gsmiller opened a new pull request #168:
URL: https://github.com/apache/lucene/pull/168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pl
[
https://issues.apache.org/jira/browse/LUCENE-9950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357607#comment-17357607
]
Greg Miller commented on LUCENE-9950:
-
I think I found the issue. It's with the test
Greg Miller created LUCENE-9991:
---
Summary: Fix TestStringValueFacetCounts
Key: LUCENE-9991
URL: https://issues.apache.org/jira/browse/LUCENE-9991
Project: Lucene - Core
Issue Type: Bug
[
https://issues.apache.org/jira/browse/LUCENE-9950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357594#comment-17357594
]
Greg Miller commented on LUCENE-9950:
-
Hmm, interesting. Thanks for calling this out
[
https://issues.apache.org/jira/browse/LUCENE-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gautam Worah updated LUCENE-9990:
-
Description:
Gradle 7 has added support for running builds with arbitrary JVMs.
Today, Gradle 6
[
https://issues.apache.org/jira/browse/LUCENE-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gautam Worah updated LUCENE-9990:
-
Description:
Gradle 7 has added support for running builds with arbitrary JVMs.
Today, Gradle 6
[
https://issues.apache.org/jira/browse/LUCENE-9950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357589#comment-17357589
]
Julie Tibshirani commented on LUCENE-9950:
--
I've noticed a few failures in the
Gautam Worah created LUCENE-9990:
Summary: Tracking issue for Gradle upgrade to 7.0.2
Key: LUCENE-9990
URL: https://issues.apache.org/jira/browse/LUCENE-9990
Project: Lucene - Core
Issue Type
mikemccand commented on a change in pull request #157:
URL: https://github.com/apache/lucene/pull/157#discussion_r645647506
##
File path:
lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestFlattenGraphFilter.java
##
@@ -314,5 +323,304 @@ public void testTwoLon
jtibshirani commented on pull request #166:
URL: https://github.com/apache/lucene/pull/166#issuecomment-854940702
This is ready for a second look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jtibshirani commented on a change in pull request #166:
URL: https://github.com/apache/lucene/pull/166#discussion_r645789797
##
File path:
lucene/core/src/test/org/apache/lucene/codecs/lucene90/TestLucene90HnswVectorFormat.java
##
@@ -16,14 +16,76 @@
*/
package org.apache.l
[
https://issues.apache.org/jira/browse/LUCENE-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357521#comment-17357521
]
Dawid Weiss commented on LUCENE-9988:
-
I just wanted to say I'm happy to see this in
jtibshirani commented on a change in pull request #166:
URL: https://github.com/apache/lucene/pull/166#discussion_r645698401
##
File path:
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java
##
@@ -38,17 +38,11 @@
// expose for testing.
public static l
jtibshirani commented on a change in pull request #166:
URL: https://github.com/apache/lucene/pull/166#discussion_r645694641
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorFormat.java
##
@@ -76,14 +79,55 @@
static final int VERSION_ST
[
https://issues.apache.org/jira/browse/LUCENE-9944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357449#comment-17357449
]
Greg Miller commented on LUCENE-9944:
-
Got it, thanks [~mikemccand]. I'll look into
mikemccand commented on pull request #157:
URL: https://github.com/apache/lucene/pull/157#issuecomment-854820485
Thank you for the ascii-art explanation of neighbor versus consumed holes!
Do we also handle the neighbor-hole case when there is more than one long
path?
E.g. if t
[
https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357410#comment-17357410
]
Robert Muir commented on LUCENE-9981:
-
+1. glad this test is happy!
> CompiledAutom
[
https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357391#comment-17357391
]
Michael McCandless commented on LUCENE-9981:
{{main}} seems happy so far. D
mikemccand commented on pull request #157:
URL: https://github.com/apache/lucene/pull/157#issuecomment-854760044
Maybe another way to improve the checking for correctness in the randomized
test (or maybe in a new randomized test) would be to randomly generate a set of
strings from a limite
mikemccand commented on a change in pull request #132:
URL: https://github.com/apache/lucene/pull/132#discussion_r645598176
##
File path:
lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/TaskSequence.java
##
@@ -340,12 +340,17 @@ private int doParallelTasks()
msokolov commented on a change in pull request #166:
URL: https://github.com/apache/lucene/pull/166#discussion_r645594479
##
File path:
lucene/core/src/test/org/apache/lucene/codecs/lucene90/TestLucene90HnswVectorFormat.java
##
@@ -16,14 +16,76 @@
*/
package org.apache.luce
mikemccand commented on pull request #132:
URL: https://github.com/apache/lucene/pull/132#issuecomment-854738591
Thanks for the updates!
It looks like `gradle check` is upset -- if you run `./gradlew tidy` it will
re-format your changes and it should pass again!
--
This is an auto
[
https://issues.apache.org/jira/browse/LUCENE-9944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357369#comment-17357369
]
Michael McCandless commented on LUCENE-9944:
Also, I think 8.9.x branch is a
[
https://issues.apache.org/jira/browse/LUCENE-9944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357368#comment-17357368
]
Michael McCandless commented on LUCENE-9944:
{quote}As for a back port, I do
[
https://issues.apache.org/jira/browse/LUCENE-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357367#comment-17357367
]
Michael McCandless commented on LUCENE-9988:
Thanks [~gsmiller] and welcome
[
https://issues.apache.org/jira/browse/LUCENE-8216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357270#comment-17357270
]
Alessandro Benedetti commented on LUCENE-8216:
--
[~jim.ferenczi] thank you v
[
https://issues.apache.org/jira/browse/LUCENE-8216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357264#comment-17357264
]
Jim Ferenczi commented on LUCENE-8216:
--
> From a quick look at your code, the docum
[
https://issues.apache.org/jira/browse/LUCENE-8216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357258#comment-17357258
]
Alessandro Benedetti commented on LUCENE-8216:
--
hi [~jim.ferenczi] I am inv
balmukundblr commented on a change in pull request #132:
URL: https://github.com/apache/lucene/pull/132#discussion_r645392896
##
File path:
lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/feeds/ReutersContentSource.java
##
@@ -102,19 +103,33 @@ public void close()
tboeghk commented on pull request #1595:
URL: https://github.com/apache/lucene-solr/pull/1595#issuecomment-854428675
Super seeded by https://github.com/apache/solr/pull/159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
janhoy merged pull request #2502:
URL: https://github.com/apache/lucene-solr/pull/2502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, ple
janhoy merged pull request #165:
URL: https://github.com/apache/lucene/pull/165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please con
tboeghk closed pull request #1595:
URL: https://github.com/apache/lucene-solr/pull/1595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pl
jtibshirani merged pull request #160:
URL: https://github.com/apache/lucene/pull/160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
jtibshirani commented on a change in pull request #166:
URL: https://github.com/apache/lucene/pull/166#discussion_r644395730
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorFormat.java
##
@@ -76,14 +79,55 @@
static final int VERSION_ST
gsmiller merged pull request #167:
URL: https://github.com/apache/lucene/pull/167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
mikemccand commented on pull request #157:
URL: https://github.com/apache/lucene/pull/157#issuecomment-854277244
I love all the added test cases!
Maybe in the new random test we could use `tokenstreamToAutomaton` and then
confirm no dead states in that, using existing APIs?
--
Thi
jtibshirani commented on pull request #166:
URL: https://github.com/apache/lucene/pull/166#issuecomment-854021866
@msokolov as a heads up, I didn't have the chance to try out
`KnnGraphTester` to double-check the behavior didn't change. However the update
to `KnnGraphTester` was straightfor
janhoy commented on pull request #2502:
URL: https://github.com/apache/lucene-solr/pull/2502#issuecomment-853890546
Added a few more reviewers who have previously upgraded Jetty. I plan to
merge this to 8x soon, get some Jenkins runs and then merge to release
branch_8_9...
--
This is an
rmuir commented on a change in pull request #166:
URL: https://github.com/apache/lucene/pull/166#discussion_r645249079
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorFormat.java
##
@@ -76,14 +79,55 @@
static final int VERSION_START =
zhaih commented on pull request #163:
URL: https://github.com/apache/lucene/pull/163#issuecomment-853538280
Thank you @mikemccand @dweiss and @bruno-roustant all for reviewing this PR!
Since this PR is more of an optimization for adversarial cases so we don't want
to sacrifice performance
[
https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357132#comment-17357132
]
Praveen Nishchal commented on LUCENE-8739:
--
Zstd JNI https://github.com/luben/z
bruno-roustant commented on a change in pull request #163:
URL: https://github.com/apache/lucene/pull/163#discussion_r644575732
##
File path: lucene/core/build.gradle
##
@@ -20,6 +20,8 @@ apply plugin: 'java-library'
description = 'Lucene core library'
dependencies {
+ imp
[
https://issues.apache.org/jira/browse/LUCENE-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved LUCENE-9985.
-
Fix Version/s: 8.9
main (9.0)
Resolution: Fixed
> Upgrade Jetty to 9.4
[
https://issues.apache.org/jira/browse/LUCENE-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357127#comment-17357127
]
ASF subversion and git services commented on LUCENE-9985:
-
Commi
janhoy merged pull request #2502:
URL: https://github.com/apache/lucene-solr/pull/2502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, ple
tboeghk closed pull request #1595:
URL: https://github.com/apache/lucene-solr/pull/1595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pl
tboeghk commented on pull request #1595:
URL: https://github.com/apache/lucene-solr/pull/1595#issuecomment-854428675
Super seeded by https://github.com/apache/solr/pull/159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
58 matches
Mail list logo
