jtibshirani commented on a change in pull request #166:
URL: https://github.com/apache/lucene/pull/166#discussion_r645698401
##########
File path:
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java
##########
@@ -38,17 +38,11 @@
// expose for testing.
public static long randSeed = DEFAULT_RAND_SEED;
- /* These "default" hyper-parameter settings are exposed (and non-final) to
enable performance
- * testing since the indexing API doesn't provide any control over them.
- */
-
// default max connections per node
public static final int DEFAULT_MAX_CONN = 16;
- public static String HNSW_MAX_CONN_ATTRIBUTE_KEY = "max_connections";
// default candidate list size
public static final int DEFAULT_BEAM_WIDTH = 16;
Review comment:
I also think we should bump the default. If you're okay with it, I'd
prefer to do it in a separate PR to keep this one a straight refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
