[ https://issues.apache.org/jira/browse/LUCENE-9944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357368#comment-17357368 ]
Michael McCandless commented on LUCENE-9944: -------------------------------------------- {quote}As for a back port, I don't think it's critical to get it out in the 8.9 release, and given how close that release seems, I wouldn't try to squeeze this in, especially given the bug found in randomized testing. I could work on back porting to branch_8x after 8.9 is finalized though. Does that sound right? {quote} Yeah +1 to do this after 8.9.0! In general if a change does not break backwards compatibility, we aggressively backport it to the current stable branch (8.x now). > Implement alternative drill sideways faceting with provided CollectorManager > ---------------------------------------------------------------------------- > > Key: LUCENE-9944 > URL: https://issues.apache.org/jira/browse/LUCENE-9944 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/facet > Affects Versions: main (9.0) > Reporter: Greg Miller > Priority: Minor > Fix For: main (9.0) > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Today, if a user of {{DrillSideways}} wants to provide their own > {{CollectorManager}} when invoking {{search}}, they get this alternate, > "concurrent" implementation that creates N copies of the provided > {{DrillDownQuery}} (where N is the number of drill-down dimensions) and runs > them all concurrently. This is a very different implementation than the one a > user would get if providing a {{Collector}} instead. Additionally, an > {{ExecutorService}} must be provided when constructing a {{DrillSideways}} > instance if the user wants to bring their own {{CollectorManager}} > (otherwise, they'll get an unfriendly NPE when calling {{search}}). > I propose adding an implementation to {{DrillSideways}} that will run the > "non-concurrent" algorithm in the case that a user wants to provide their own > {{CollectorManager}} but doesn't want to provide an {{ExecutorService}} (and > doesn't want the concurrent algorithm). -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org