[ https://issues.apache.org/jira/browse/LUCENE-9950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357589#comment-17357589 ]
Julie Tibshirani commented on LUCENE-9950: ------------------------------------------ I've noticed a few failures in the new {{TestStringValueFacetCounts}} class. I didn't have the chance to dig into them. This line reproduces reliably on {{main}}: {code} ./gradlew test --tests TestStringValueFacetCounts.testRandom -Dtests.seed=B6D7A1E1813518E3 -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=nus-SS -Dtests.timezone=Asia/Pyongyang -Dtests.asserts=true -Dtests.file.encoding=UTF-8 {code} > Support both single- and multi-value string fields in facet counting > (non-taxonomy based approaches) > ---------------------------------------------------------------------------------------------------- > > Key: LUCENE-9950 > URL: https://issues.apache.org/jira/browse/LUCENE-9950 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/facet > Affects Versions: main (9.0) > Reporter: Greg Miller > Priority: Minor > Fix For: main (9.0), 8.9 > > Time Spent: 3h > Remaining Estimate: 0h > > Users wanting to facet count string-based fields using a non-taxonomy-based > approach can use {{SortedSetDocValueFacetCounts}}, which accumulates facet > counts based on a {{SortedSetDocValues}} field. This requires the stored doc > values to be multi-valued (i.e., {{SORTED_SET}}), and doesn't work on > single-valued fields (i.e., SORTED). In contrast, if a user wants to facet > count on a stored numeric field, they can use {{LongValueFacetCounts}}, which > supports both single- and multi-valued fields (and in LUCENE-9948, we now > auto-detect instead of asking the user to specify). > Let's update {{SortedSetDocValueFacetCounts}} to also support, and > automatically detect single- and multi-value fields. Note that this is a > spin-off issue from LUCENE-9946, where [~rcmuir] points out that this can > essentially be a one-line change, but we may want to do some class renaming > at the same time. Also note that we should do this in > {{ConcurrentSortedSetDocValuesFacetCounts}} while we're at it. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org