[
https://issues.apache.org/jira/browse/SOLR-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253268#comment-17253268
]
Noble Paul edited comment on SOLR-15052 at 12/22/20, 4:46 AM:
-
[
https://issues.apache.org/jira/browse/SOLR-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253268#comment-17253268
]
Noble Paul edited comment on SOLR-15052 at 12/22/20, 4:32 AM:
-
[
https://issues.apache.org/jira/browse/SOLR-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253268#comment-17253268
]
Noble Paul edited comment on SOLR-15052 at 12/22/20, 4:30 AM:
-
[
https://issues.apache.org/jira/browse/SOLR-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253268#comment-17253268
]
Noble Paul commented on SOLR-15052:
---
{quote}This does mean that all replica state updat
noblepaul commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r547058780
##
File path:
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java
##
@@ -81,6 +81,7 @@
public class SolrCloudTestCase extend
noblepaul commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r547058593
##
File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java
##
@@ -1609,12 +1611,41 @@ public void publish(final CoreDescriptor cd, fin
noblepaul commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r547043177
##
File path:
solr/core/src/java/org/apache/solr/cloud/ShardLeaderElectionContextBase.java
##
@@ -161,9 +163,11 @@ void runLeaderProcess(boolean we
noblepaul commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r547042878
##
File path:
solr/solrj/src/java/org/apache/solr/common/cloud/PerReplicaStates.java
##
@@ -0,0 +1,587 @@
+/*
+ * Licensed to the Apache Software F
noblepaul commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r547042695
##
File path:
solr/core/src/java/org/apache/solr/cloud/ShardLeaderElectionContextBase.java
##
@@ -179,7 +183,16 @@ void runLeaderProcess(boolean we
[
https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253164#comment-17253164
]
Thomas Wöckinger edited comment on SOLR-14923 at 12/21/20, 11:20 PM:
--
[
https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253164#comment-17253164
]
Thomas Wöckinger commented on SOLR-14923:
-
[~dsmiley] I take a look at the PR, lo
dsmiley commented on pull request #2142:
URL: https://github.com/apache/lucene-solr/pull/2142#issuecomment-749223476
Please see #2159 which I think should super-cede this one. This PR was
useful in helping me see/understand the problems, so thank you!
dsmiley closed pull request #2142:
URL: https://github.com/apache/lucene-solr/pull/2142
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253144#comment-17253144
]
David Smiley commented on SOLR-14923:
-
Finally, here's the PR: https://github.com/apa
dsmiley opened a new pull request #2159:
URL: https://github.com/apache/lucene-solr/pull/2159
https://issues.apache.org/jira/browse/SOLR-14923
* UpdateLog.openRealtimeSearcher() was being called for every incoming
document when the schema had _nest_path_. It is now more limited to
dsmiley commented on pull request #2159:
URL: https://github.com/apache/lucene-solr/pull/2159#issuecomment-749216411
CC @thomaswoeckinger @moshebla
Tests pass, precommit passes.
@markrmiller FYI I observed that NestedShardedAtomicUpdateTest on your
ref-impl branch commented o
[
https://issues.apache.org/jira/browse/SOLR-15049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253081#comment-17253081
]
Jason Gerlowski commented on SOLR-15049:
I did a few performance tests this morni
[
https://issues.apache.org/jira/browse/SOLR-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253055#comment-17253055
]
ASF subversion and git services commented on SOLR-14608:
Commit 6
nknize commented on a change in pull request #2155:
URL: https://github.com/apache/lucene-solr/pull/2155#discussion_r546865243
##
File path: lucene/core/src/java/org/apache/lucene/document/LatLonPointQuery.java
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Founda
[
https://issues.apache.org/jira/browse/SOLR-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253023#comment-17253023
]
Bram Van Dam commented on SOLR-9864:
This is still the case on 7.7 and on master. I'm
[
https://issues.apache.org/jira/browse/SOLR-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bram Van Dam updated SOLR-9864:
---
Component/s: SolrJ
> SolrQuery.getCopy() doesn't copy sortClauses
> --
[
https://issues.apache.org/jira/browse/SOLR-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bram Van Dam updated SOLR-9864:
---
Affects Version/s: master (9.0)
7.7
> SolrQuery.getCopy() doesn't copy sortClau
[
https://issues.apache.org/jira/browse/SOLR-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bram Van Dam updated SOLR-9864:
---
Labels: patch-available (was: )
> SolrQuery.getCopy() doesn't copy sortClauses
>
Patrick Marty created LUCENE-9646:
-
Summary: Set BM25Similarity discountOverlaps through the
constructor
Key: LUCENE-9646
URL: https://issues.apache.org/jira/browse/LUCENE-9646
Project: Lucene - Core
msokolov commented on pull request #2157:
URL: https://github.com/apache/lucene-solr/pull/2157#issuecomment-749043883
I'll push today if there are no comments.
This is an automated message from the Apache Git Service.
To resp
murblanc commented on a change in pull request #2133:
URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r546779168
##
File path:
solr/core/src/test/org/apache/solr/cluster/placement/impl/PlacementPluginIntegrationTest.java
##
@@ -220,6 +231,66 @@ public void test
murblanc commented on a change in pull request #2133:
URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r546778721
##
File path:
solr/core/src/test/org/apache/solr/cluster/placement/impl/PlacementPluginIntegrationTest.java
##
@@ -220,6 +231,66 @@ public void test
murblanc commented on a change in pull request #2133:
URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r546776315
##
File path: solr/core/src/test/org/apache/solr/cluster/placement/Builders.java
##
@@ -48,7 +49,11 @@ public static CollectionBuilder newCollectionB
murblanc commented on a change in pull request #2133:
URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r546775011
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/impl/CollectionMetricsBuilder.java
##
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the A
murblanc commented on a change in pull request #2133:
URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r546766696
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/ShardMetrics.java
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Fou
[
https://issues.apache.org/jira/browse/LUCENE-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252914#comment-17252914
]
Michael McCandless commented on LUCENE-9624:
Ahh, thanks for the explanation
[
https://issues.apache.org/jira/browse/LUCENE-9638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252911#comment-17252911
]
Michael McCandless commented on LUCENE-9638:
Thanks [~sokolov]!
> TestVecto
sigram commented on a change in pull request #2133:
URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r546752593
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/ReplicaMetrics.java
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Fou
murblanc commented on a change in pull request #2133:
URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r546738344
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/AttributeValues.java
##
@@ -65,11 +65,16 @@
/**
* For the given node: metr
murblanc commented on a change in pull request #2133:
URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r546737245
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/AttributeValues.java
##
@@ -65,11 +65,16 @@
/**
* For the given node: metr
murblanc commented on a change in pull request #2133:
URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r546733523
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/ReplicaMetrics.java
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software F
murblanc commented on a change in pull request #2133:
URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r546685808
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/CollectionMetrics.java
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Softwar
sigram commented on a change in pull request #2133:
URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r546651221
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/ReplicaMetric.java
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Fou
sigram commented on a change in pull request #2133:
URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r546650524
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/AttributeValues.java
##
@@ -65,11 +65,16 @@
/**
* For the given node: metric
[
https://issues.apache.org/jira/browse/LUCENE-9645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera closed LUCENE-9645.
> Delete useless variable negativeDeltas in BKDReader$IndexTree
> ---
[
https://issues.apache.org/jira/browse/LUCENE-9645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera resolved LUCENE-9645.
--
Resolution: Invalid
> Delete useless variable negativeDeltas in BKDReader$IndexTree
> ---
kkewwei commented on pull request #2158:
URL: https://github.com/apache/lucene-solr/pull/2158#issuecomment-748886459
yes, you are right. Sorry for my mistake, splitDim has been changed.
This is an automated message from the A
[
https://issues.apache.org/jira/browse/LUCENE-9645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252739#comment-17252739
]
kkewwei edited comment on LUCENE-9645 at 12/21/20, 9:59 AM:
[
https://issues.apache.org/jira/browse/LUCENE-9645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252739#comment-17252739
]
kkewwei edited comment on LUCENE-9645 at 12/21/20, 9:58 AM:
iverase commented on pull request #2158:
URL: https://github.com/apache/lucene-solr/pull/2158#issuecomment-748885087
Thanks @kkewwei,
I am afraid this change is not correct and negativeDeltas is necessary for
tracking if the previous split for each dimension was done to the left of t
[
https://issues.apache.org/jira/browse/LUCENE-9645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252739#comment-17252739
]
kkewwei commented on LUCENE-9645:
-
sorry for my mistake, code is ok.
> Delete useless v
kkewwei closed pull request #2158:
URL: https://github.com/apache/lucene-solr/pull/2158
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252721#comment-17252721
]
Dawid Weiss commented on LUCENE-9570:
-
There is an issue with sources with multiple
kkewwei closed pull request #993:
URL: https://github.com/apache/lucene-solr/pull/993
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
iverase commented on pull request #2155:
URL: https://github.com/apache/lucene-solr/pull/2155#issuecomment-748852050
I updated the jira ticket with the motivation for this change. What I
disagree here is saying the points are not shapes, e.g you can index points
using LatLonShape. Points a
[
https://issues.apache.org/jira/browse/LUCENE-9641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252689#comment-17252689
]
Ignacio Vera commented on LUCENE-9641:
--
The rationale behind this change is to be a
51 matches
Mail list logo