murblanc commented on a change in pull request #2133:
URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r546737245
##########
File path:
solr/core/src/java/org/apache/solr/cluster/placement/AttributeValues.java
##########
@@ -65,11 +65,16 @@
/**
* For the given node: metric of specific name and registry
*/
- Optional<Double> getMetric(Node node, String metricName,
AttributeFetcher.NodeMetricRegistry registry);
+ Optional<Object> getMetric(Node node, String metricName,
AttributeFetcher.NodeMetricRegistry registry);
Review comment:
If `ReplicaMetrics` can be improved as suggested by a
[comment](https://github.com/apache/lucene-solr/pull/2133/files#r546733523)
there to make better use of `ReplicaMetric<T>` instances and not use generic
`Object` values, can we generalize the concept?
Either rename `ReplicaMetric` and have it define metrics for all types of
cluster entities (i.e. including nodes) or introduce a similar `NodeMetric<T>`
class that would be used here as well as in `AttributeFetcher`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
