[ 
https://issues.apache.org/jira/browse/LUCENE-9645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252739#comment-17252739
 ] 

kkewwei edited comment on LUCENE-9645 at 12/21/20, 9:59 AM:
------------------------------------------------------------

Sorry for my mistake, splitDim has changed. the code is ok. Please close it


was (Author: kkewwei):
Sorry for my mistake, splitDim has changed. the code is ok.

> Delete useless variable  negativeDeltas in BKDReader$IndexTree
> --------------------------------------------------------------
>
>                 Key: LUCENE-9645
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9645
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/other
>    Affects Versions: 8.6.2
>            Reporter: kkewwei
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In BKDReader$IndexTree, the private final variable negativeDeltas seems 
> useless. It will be only used in BKDReader.readNodeData(), we use 
> negativeDeltas[level * numIndexDims + splitDim] to check whether the current 
> nod is left or right, but it can be replaced by isLeft which is the function 
> parameter.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to