iverase commented on pull request #2158: URL: https://github.com/apache/lucene-solr/pull/2158#issuecomment-748885087
Thanks @kkewwei, I am afraid this change is not correct and negativeDeltas is necessary for tracking if the previous split for each dimension was done to the left of the tree. You can check the test errors by running the following: ``` ./gradlew test --tests "org.apache.lucene.util.bkd.TestBKD" ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
