[GitHub] [lucene-solr] dsmiley commented on pull request #2017: SOLR-14957: Add Prometheus Exporter to docker PATH. Fix classpath issues.

2020-10-24 Thread GitBox
dsmiley commented on pull request #2017: URL: https://github.com/apache/lucene-solr/pull/2017#issuecomment-716091259 +1 LGTM; I see you are putting SLF4J JARs on the classpath, so I assume that was the issue you encountered? What's in conf? Oh the configuration... yes I ran into this iss

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #2016: SOLR-14067 v2 Move Stateless Scripting Update Process to /contrib

2020-10-24 Thread GitBox
tflobbe commented on a change in pull request #2016: URL: https://github.com/apache/lucene-solr/pull/2016#discussion_r511515809 ## File path: solr/contrib/scripting-update-processor/src/java/org/apache/solr/update/processor/StatelessScriptUpdateProcessorFactory.java ## @@ -0,0

[jira] [Created] (SOLR-14963) Child "rows" param should apply per level

2020-10-24 Thread David Smiley (Jira)
David Smiley created SOLR-14963: --- Summary: Child "rows" param should apply per level Key: SOLR-14963 URL: https://issues.apache.org/jira/browse/SOLR-14963 Project: Solr Issue Type: Bug Se

[GitHub] [lucene-solr] ErickErickson opened a new pull request #2025: SOLR-14844: Upgrade Jetty to 9.4.32.v20200930 8x

2020-10-24 Thread GitBox
ErickErickson opened a new pull request #2025: URL: https://github.com/apache/lucene-solr/pull/2025 fixes the test failure by setting min compression in JettySolrRunner This is an automated message from the Apache Git Service

[GitHub] [lucene-solr] ErickErickson opened a new pull request #2024: SOLR-14844: Upgrade Jetty to 9.4.32.v20200930 master

2020-10-24 Thread GitBox
ErickErickson opened a new pull request #2024: URL: https://github.com/apache/lucene-solr/pull/2024 Fixes the checksum issue This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [lucene-solr] ErickErickson commented on pull request #2021: SOLR-14844: upgrade jetty to 9.4.32.v20200930

2020-10-24 Thread GitBox
ErickErickson commented on pull request #2021: URL: https://github.com/apache/lucene-solr/pull/2021#issuecomment-716047701 new one momentarily This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [lucene-solr] ErickErickson closed pull request #2003: SOLR-14844: Upgrade Jetty to 9.4.32.v20200930

2020-10-24 Thread GitBox
ErickErickson closed pull request #2003: URL: https://github.com/apache/lucene-solr/pull/2003 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene-solr] ErickErickson closed pull request #2021: SOLR-14844: upgrade jetty to 9.4.32.v20200930

2020-10-24 Thread GitBox
ErickErickson closed pull request #2021: URL: https://github.com/apache/lucene-solr/pull/2021 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (SOLR-14844) Upgrade Jetty to 9.4.32.v20200930

2020-10-24 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220201#comment-17220201 ] Erick Erickson commented on SOLR-14844: --- All the tests pass with just changing the

[GitHub] [lucene-solr] ErickErickson commented on pull request #2003: SOLR-14844: Upgrade Jetty to 9.4.32.v20200930

2020-10-24 Thread GitBox
ErickErickson commented on pull request #2003: URL: https://github.com/apache/lucene-solr/pull/2003#issuecomment-716047640 New one momentarily. This is an automated message from the Apache Git Service. To respond to the messa

[jira] [Commented] (SOLR-14942) Reduce leader election time on node shutdown

2020-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220133#comment-17220133 ] ASF subversion and git services commented on SOLR-14942: Commit b

[GitHub] [lucene-solr] dsmiley merged pull request #1993: .gitignore clean up

2020-10-24 Thread GitBox
dsmiley merged pull request #1993: URL: https://github.com/apache/lucene-solr/pull/1993 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-14067) Move StatelessScriptUpdateProcessor to a contrib

2020-10-24 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220124#comment-17220124 ] David Smiley commented on SOLR-14067: - RE package: That will happen in SOLR-14688 or

[jira] [Commented] (SOLR-14469) Removed deprecated code in solr/core (master only)

2020-10-24 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220120#comment-17220120 ] Erick Erickson commented on SOLR-14469: --- See Smiley's DeprecationLog class too? >

[jira] [Commented] (SOLR-14469) Removed deprecated code in solr/core (master only)

2020-10-24 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220116#comment-17220116 ] Erick Erickson commented on SOLR-14469: --- Who knows? Maybe I'll get to this as winte

[jira] [Commented] (SOLR-14844) Upgrade Jetty to 9.4.32.v20200930

2020-10-24 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220096#comment-17220096 ] Erick Erickson commented on SOLR-14844: --- [~samuelgmartinez] Why not just change the

[jira] [Commented] (SOLR-14945) Improve compressed HTTP responses handling in SolrJ

2020-10-24 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220095#comment-17220095 ] Erick Erickson commented on SOLR-14945: --- This is explained more fully in SOLR-14844

[GitHub] [lucene-solr] epugh commented on pull request #2016: SOLR-14067 v2 Move Stateless Scripting Update Process to /contrib

2020-10-24 Thread GitBox
epugh commented on pull request #2016: URL: https://github.com/apache/lucene-solr/pull/2016#issuecomment-715911331 @dweiss I'm hoping you can steer me in the right direction. I removed the `contrib/scripting-update-processor/src/java/org/apache/solr/update/processor/package-info.java` bec

[jira] [Comment Edited] (LUCENE-9322) Discussing a unified vectors format API

2020-10-24 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220065#comment-17220065 ] Michael Sokolov edited comment on LUCENE-9322 at 10/24/20, 12:47 PM: -

[jira] [Commented] (SOLR-14067) Move StatelessScriptUpdateProcessor to a contrib

2020-10-24 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220083#comment-17220083 ] David Eric Pugh commented on SOLR-14067: [~dsmiley] I added a notice to the `majo

[jira] [Commented] (SOLR-14067) Move StatelessScriptUpdateProcessor to a contrib

2020-10-24 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220082#comment-17220082 ] David Eric Pugh commented on SOLR-14067: Thanks [~tflobbe], I found that just hav

[jira] [Commented] (LUCENE-9581) Clarify discardCompoundToken behavior in the JapaneseTokenizer

2020-10-24 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220078#comment-17220078 ] Tomoko Uchida commented on LUCENE-9581: --- {quote}As we have discussed in LUCENE-912

[jira] [Commented] (LUCENE-9322) Discussing a unified vectors format API

2020-10-24 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220065#comment-17220065 ] Michael Sokolov commented on LUCENE-9322: - Ooh, a fun failure - ah I see it's be

[jira] [Commented] (SOLR-14942) Reduce leader election time on node shutdown

2020-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220064#comment-17220064 ] ASF subversion and git services commented on SOLR-14942: Commit 7

[GitHub] [lucene-solr] shalinmangar merged pull request #2004: SOLR-14942: Reduce leader election time on node shutdown

2020-10-24 Thread GitBox
shalinmangar merged pull request #2004: URL: https://github.com/apache/lucene-solr/pull/2004 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (LUCENE-9319) Clean up Sandbox project by retiring/delete functionality or move it to Lucene core

2020-10-24 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220042#comment-17220042 ] Tomoko Uchida commented on LUCENE-9319: --- I opened [https://github.com/apache/lucen

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta commented on a change in pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511374261 ## File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java ## @@ -38,9 +38,10 @@ */ public abstract class TopScoreDocC

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta commented on a change in pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511373874 ## File path: lucene/core/src/java/org/apache/lucene/search/TopDocsCollector.java ## @@ -35,7 +35,7 @@ /** This is used in case topDocs() is cal

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta commented on a change in pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511373437 ## File path: lucene/core/src/java/org/apache/lucene/search/TermScorer.java ## @@ -60,7 +60,8 @@ public int docID() { return postingsEnum.docID(

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta commented on a change in pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511373161 ## File path: lucene/core/src/java/org/apache/lucene/search/TermScorer.java ## @@ -35,7 +35,7 @@ /** * Construct a {@link TermScorer} that wil

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta commented on a change in pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511372816 ## File path: lucene/core/src/java/org/apache/lucene/search/TermScorer.java ## @@ -25,7 +25,7 @@ /** Expert: A Scorer for documents matching a Ter

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta commented on a change in pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511372528 ## File path: lucene/core/src/java/org/apache/lucene/search/SloppyPhraseMatcher.java ## @@ -81,7 +81,7 @@ private boolean positioned; private

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta commented on a change in pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511372160 ## File path: lucene/core/src/java/org/apache/lucene/search/SloppyPhraseMatcher.java ## @@ -53,7 +53,7 @@ * would get same score as "g f"~2, altho

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta commented on a change in pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511371777 ## File path: lucene/core/src/java/org/apache/lucene/search/PhraseWeight.java ## @@ -23,13 +23,15 @@ import org.apache.lucene.search.similarities.Si

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta commented on a change in pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511371410 ## File path: lucene/core/src/java/org/apache/lucene/search/PhraseQuery.java ## @@ -413,7 +415,7 @@ public boolean equals(Object obj) { * This i

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta commented on a change in pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511371028 ## File path: lucene/core/src/java/org/apache/lucene/search/PhraseQuery.java ## @@ -304,13 +304,15 @@ public void visit(QueryVisitor visitor) {

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta commented on a change in pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511370707 ## File path: lucene/core/src/java/org/apache/lucene/search/PhraseMatcher.java ## @@ -26,7 +26,7 @@ * relevant document, then call {@link #reset()}

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta commented on a change in pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511370101 ## File path: lucene/core/src/java/org/apache/lucene/search/Multiset.java ## @@ -29,13 +29,13 @@ * Iteration order is not specified. * @lucene.in

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta commented on a change in pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511369770 ## File path: lucene/core/src/java/org/apache/lucene/search/MultiPhraseQuery.java ## @@ -575,17 +575,17 @@ private void growArray() { } } -

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta commented on a change in pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511369392 ## File path: lucene/core/src/java/org/apache/lucene/search/MultiPhraseQuery.java ## @@ -410,7 +410,7 @@ private boolean termArraysEquals(Term[][] te

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta commented on a change in pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511368625 ## File path: lucene/core/src/java/org/apache/lucene/search/HitQueue.java ## @@ -19,7 +19,8 @@ import org.apache.lucene.util.PriorityQueue; -fin

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta commented on a change in pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511368688 ## File path: lucene/core/src/java/org/apache/lucene/search/HitQueue.java ## @@ -59,7 +60,7 @@ * @param prePopulate * specifies whet

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta commented on a change in pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511368151 ## File path: lucene/core/src/java/org/apache/lucene/search/ExactPhraseMatcher.java ## @@ -50,7 +51,8 @@ public PostingsAndPosition(PostingsEnum post

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta commented on a change in pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511367972 ## File path: lucene/core/src/java/org/apache/lucene/search/ExactPhraseMatcher.java ## @@ -33,7 +33,8 @@ import org.apache.lucene.search.similaritie

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta commented on a change in pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511367381 ## File path: lucene/core/src/java/org/apache/lucene/document/RangeFieldQuery.java ## @@ -228,7 +228,7 @@ boolean matches(byte[] queryPackedValue, by

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta commented on a change in pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511365628 ## File path: lucene/core/src/java/org/apache/lucene/document/RangeFieldQuery.java ## @@ -57,7 +57,7 @@ final int bytesPerDim; /** Used by {@

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta commented on a change in pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511364893 ## File path: lucene/core/src/java/org/apache/lucene/document/RangeFieldQuery.java ## @@ -41,7 +41,7 @@ /** * Query class for searching {@code Ran

[GitHub] [lucene-solr] mocobeta opened a new pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module

2020-10-24 Thread GitBox
mocobeta opened a new pull request #2023: URL: https://github.com/apache/lucene-solr/pull/2023 "sandbox" module shares package names o.a.l.codecs, o.a.l.document, and o.a.l.search. We have two choices to clean up this conflicts: - Move them under `o.a.l.sandbox` and relax classes/met

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1993: .gitignore clean up

2020-10-24 Thread GitBox
dweiss commented on a change in pull request #1993: URL: https://github.com/apache/lucene-solr/pull/1993#discussion_r511344950 ## File path: .gitignore ## @@ -1,43 +1,27 @@ -# . -/eclipse-build -/maven-build -/classes -build -/idea-build -dist -lib -test-lib -*~ -.#* -/build.pr

[jira] [Commented] (LUCENE-9322) Discussing a unified vectors format API

2020-10-24 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220027#comment-17220027 ] Tomoko Uchida commented on LUCENE-9322: --- I encountered a test failure in TestVecto