[
https://issues.apache.org/jira/browse/LUCENE-9319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220042#comment-17220042
]
Tomoko Uchida commented on LUCENE-9319:
---------------------------------------
I opened [https://github.com/apache/lucene-solr/pull/2023.]
In general, we have two options to resolve the split package issue for sandbox
module.
* Move them under {{o.a.l.sandbox}} (i.e., {{o.a.l.sandbox.codecs}},
{{o.a.l.sandbox.document}}, and {{o.a.l.sandbox.search}}) and relax
classes/methods visibility to public/protected to allow classes in sandbox
module access those (currently package-private) classes/methods.
* Move them to core module to keep package-private visibility in core module
as is.
Here I took the first option for all classes for the first step to resolve the
conflicts. But that may be a rather wild approach; some classes probably should
be moved to core (option 2).
> Clean up Sandbox project by retiring/delete functionality or move it to
> Lucene core
> -----------------------------------------------------------------------------------
>
> Key: LUCENE-9319
> URL: https://issues.apache.org/jira/browse/LUCENE-9319
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/other
> Affects Versions: master (9.0)
> Reporter: David Ryan
> Priority: Major
> Labels: build, features
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> To allow Lucene to be modularised with Java module system there are a few
> preparatory tasks to be completed prior to this being possible. These are
> detailed by Uwe on the mailing list here:
> [http://mail-archives.apache.org/mod_mbox/lucene-dev/202004.mbox/%3c0a5e01d60ff2$563f9c80$02bed580$@thetaphi.de%3e]
>
> The lucene-sandbox currently shares package names with lucene-core which is
> not allowed in the Java module system. There are two ways to deal with this.
> Either prefix all packages with "sandbox" or retire the lucene-sandbox all
> together. As per the email:
> {quote}Cleanup sandbox to prefix all classes there with “sandbox” package and
> where needed remove package-private access. If it’s needed for internal
> access, WTF: Just move the stuff to core! We have a new version 9.0, so
> either retire/delete Sandbox stuff or make it part of Lucene core.
> {quote}
> The suggested way forward is to move sandbox code to core.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
