mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511374261
##########
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##########
@@ -38,9 +38,10 @@
*/
public abstract class TopScoreDocCollector extends TopDocsCollector<ScoreDoc> {
- abstract static class ScorerLeafCollector implements LeafCollector {
+ /** Scorable leaf collector */
+ public abstract static class ScorerLeafCollector implements LeafCollector {
Review comment:
This is used in o.a.l.sandbox.search.LargeNumHitsTopDocsCollector.
##########
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##########
@@ -38,9 +38,10 @@
*/
public abstract class TopScoreDocCollector extends TopDocsCollector<ScoreDoc> {
- abstract static class ScorerLeafCollector implements LeafCollector {
+ /** Scorable leaf collector */
+ public abstract static class ScorerLeafCollector implements LeafCollector {
- Scorable scorer;
+ protected Scorable scorer;
Review comment:
Same above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
