dsmiley commented on pull request #2017: URL: https://github.com/apache/lucene-solr/pull/2017#issuecomment-716091259
+1 LGTM; I see you are putting SLF4J JARs on the classpath, so I assume that was the issue you encountered? What's in conf? Oh the configuration... yes I ran into this issue and I solved it by setting the CWD from Docker to prometheus-exporter's dir. Please be sure to Q/A both manual execution (i.e. as if from a distribution) and via Docker. I thought you might have also added the env var overrides while you were at it but maybe you want to do that on another issue? You could do it here; IMO it fits with the scope of making prometheus-exporter easier to use via Docker than is today (possible but some quirks). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
