[jira] [Created] (SOLR-14580) CloudSolrClient cannot be initialized using 'zkHosts' builder

2020-06-17 Thread Nikolay Ivanov (Jira)
Nikolay Ivanov created SOLR-14580: - Summary: CloudSolrClient cannot be initialized using 'zkHosts' builder Key: SOLR-14580 URL: https://issues.apache.org/jira/browse/SOLR-14580 Project: Solr

[GitHub] [lucene-solr] megancarey opened a new pull request #1592: SOLR-14579 First pass at dismantling Utils

2020-06-17 Thread GitBox
megancarey opened a new pull request #1592: URL: https://github.com/apache/lucene-solr/pull/1592 # Description Eliminating warnings due to static Functions in the Utils class within Solr. # Solution Removed a few Function variables from the Utils class which

[GitHub] [lucene-solr] dsmiley commented on pull request #1572: SOLR-14561 CoreAdminAPI's parameters instanceDir and dataDir are now validated

2020-06-17 Thread GitBox
dsmiley commented on pull request #1572: URL: https://github.com/apache/lucene-solr/pull/1572#issuecomment-645742371 @mkhludnev ? I recall you use Windows. This is an automated message from the Apache Git Service. To respond

[jira] [Updated] (SOLR-14575) Solr restore is failing when basic authentication is enabled

2020-06-17 Thread Yaswanth (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yaswanth updated SOLR-14575: Priority: Blocker (was: Major) > Solr restore is failing when basic authentication is enabled > --

[jira] [Commented] (LUCENE-9390) Kuromoji tokenizer discards tokens if they start with a punctuation character

2020-06-17 Thread Kazuaki Hiraga (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138948#comment-17138948 ] Kazuaki Hiraga commented on LUCENE-9390: Hello, I might have just remembered wh

[jira] [Commented] (SOLR-14567) Fix or suppress remaining warnings in solrj

2020-06-17 Thread Megan Carey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138944#comment-17138944 ] Megan Carey commented on SOLR-14567: No worries, I figured it was worth a shot to ask

[jira] [Updated] (SOLR-14579) Remove SolrJ 'Utils' generic map functions

2020-06-17 Thread Megan Carey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Megan Carey updated SOLR-14579: --- Summary: Remove SolrJ 'Utils' generic map functions (was: Remove SolrJ module 'Utils' generic map fu

[jira] [Created] (SOLR-14579) Remove SolrJ module 'Utils' generic map functions

2020-06-17 Thread Megan Carey (Jira)
Megan Carey created SOLR-14579: -- Summary: Remove SolrJ module 'Utils' generic map functions Key: SOLR-14579 URL: https://issues.apache.org/jira/browse/SOLR-14579 Project: Solr Issue Type: Improv

[jira] [Commented] (SOLR-14578) Confusing Name in the docs and Test of Auto Add Trigger

2020-06-17 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138939#comment-17138939 ] Marcus Eagan commented on SOLR-14578: - [https://github.com/apache/lucene-solr/pull/15

[GitHub] [lucene-solr] MarcusSorealheis opened a new pull request #1591: SOLR-14578: Update solrcloud-autoscaling-triggers.adoc and test

2020-06-17 Thread GitBox
MarcusSorealheis opened a new pull request #1591: URL: https://github.com/apache/lucene-solr/pull/1591 # Description fix action name in doc and test. # Solution Change the execute action to be `execute_plan` # Tests Fixes existing test

[jira] [Created] (SOLR-14578) Confusing Name in the docs and Test of Auto Add Trigger

2020-06-17 Thread Marcus Eagan (Jira)
Marcus Eagan created SOLR-14578: --- Summary: Confusing Name in the docs and Test of Auto Add Trigger Key: SOLR-14578 URL: https://issues.apache.org/jira/browse/SOLR-14578 Project: Solr Issue Type

[jira] [Updated] (SOLR-11973) Fail compilation on warnings

2020-06-17 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-11973: -- Summary: Fail compilation on warnings (was: Fail compilation on precommit warnings) > Fail co

[jira] [Commented] (SOLR-14523) Enhance gradle logging calls validation: eliminate getMessage()

2020-06-17 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138931#comment-17138931 ] Erick Erickson commented on SOLR-14523: --- [~asalamon74] Just making sure I'm not dro

[GitHub] [lucene-solr] gerlowskija commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-17 Thread GitBox
gerlowskija commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r441907028 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/CloudSolrStream.java ## @@ -491,6 +490,11 @@ public boolean equals(Objec

[jira] [Resolved] (SOLR-14532) Add iml file to gitignore

2020-06-17 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-14532. Fix Version/s: master (9.0) Resolution: Fixed Thanks for finding and fixing this And

[jira] [Assigned] (SOLR-14532) Add iml file to gitignore

2020-06-17 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski reassigned SOLR-14532: -- Assignee: Jason Gerlowski > Add iml file to gitignore > - > >

[jira] [Commented] (SOLR-14532) Add iml file to gitignore

2020-06-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138915#comment-17138915 ] ASF subversion and git services commented on SOLR-14532: Commit 0

[jira] [Resolved] (SOLR-14577) NPE in terms query parser when field is not provided

2020-06-17 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe resolved SOLR-14577. -- Fix Version/s: 8.6 master (9.0) Assi

[jira] [Commented] (SOLR-14577) NPE in terms query parser when field is not provided

2020-06-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138903#comment-17138903 ] ASF subversion and git services commented on SOLR-14577: Commit b

[jira] [Commented] (SOLR-14507) Option to allow location override if solr.hdfs.home isn't set in backup repo

2020-06-17 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138898#comment-17138898 ] Lucene/Solr QA commented on SOLR-14507: --- | (x) *{color:red}-1 overall{color}* | \\

[jira] [Commented] (SOLR-14577) NPE in terms query parser when field is not provided

2020-06-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138891#comment-17138891 ] ASF subversion and git services commented on SOLR-14577: Commit c

[GitHub] [lucene-solr] tflobbe merged pull request #1588: SOLR-14577: Return BAD REQUEST when field is missing in terms QP

2020-06-17 Thread GitBox
tflobbe merged pull request #1588: URL: https://github.com/apache/lucene-solr/pull/1588 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] janhoy commented on pull request #1572: SOLR-14561 CoreAdminAPI's parameters instanceDir and dataDir are now validated

2020-06-17 Thread GitBox
janhoy commented on pull request #1572: URL: https://github.com/apache/lucene-solr/pull/1572#issuecomment-645659284 I think this is approaching committable state. Appreciate if someone with a good Windows box would run the full test suite on Windows. But I think I'll anyway merge to master

[GitHub] [lucene-solr] s1monw commented on pull request #1552: LUCENE-8962: merge small segments on commit

2020-06-17 Thread GitBox
s1monw commented on pull request #1552: URL: https://github.com/apache/lucene-solr/pull/1552#issuecomment-645658854 @msokolov @mikemccand @msfroh I merged https://github.com/apache/lucene-solr/pull/1585 and updated this PR to use it. I also went ahead and removed the IndexWriterEvents inte

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1572: SOLR-14561 CoreAdminAPI's parameters instanceDir and dataDir are now validated

2020-06-17 Thread GitBox
dsmiley commented on a change in pull request #1572: URL: https://github.com/apache/lucene-solr/pull/1572#discussion_r441858120 ## File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java ## @@ -1259,6 +1277,28 @@ public SolrCore create(String coreName, Path insta

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1572: SOLR-14561 CoreAdminAPI's parameters instanceDir and dataDir are now validated

2020-06-17 Thread GitBox
janhoy commented on a change in pull request #1572: URL: https://github.com/apache/lucene-solr/pull/1572#discussion_r441858025 ## File path: solr/core/src/java/org/apache/solr/core/SolrPaths.java ## @@ -128,4 +130,35 @@ private static void logOnceInfo(String key, String msg) {

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1572: SOLR-14561 CoreAdminAPI's parameters instanceDir and dataDir are now validated

2020-06-17 Thread GitBox
janhoy commented on a change in pull request #1572: URL: https://github.com/apache/lucene-solr/pull/1572#discussion_r441856227 ## File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java ## @@ -1259,6 +1277,28 @@ public SolrCore create(String coreName, Path instan

[GitHub] [lucene-solr] janhoy commented on pull request #1572: SOLR-14561 CoreAdminAPI's parameters instanceDir and dataDir are now validated

2020-06-17 Thread GitBox
janhoy commented on pull request #1572: URL: https://github.com/apache/lucene-solr/pull/1572#issuecomment-645645529 All tests now passing on macOS and hopefully Windows (running tests now in a slow VirtualBox). This is an au

[jira] [Commented] (SOLR-14391) Remove getDocSet's manual doc collection logic; remove ScoreFilter

2020-06-17 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138858#comment-17138858 ] David Smiley commented on SOLR-14391: - [~shalin] as 8.6 approaches; is this here a ma

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1572: SOLR-14561 CoreAdminAPI's parameters instanceDir and dataDir are now validated

2020-06-17 Thread GitBox
janhoy commented on a change in pull request #1572: URL: https://github.com/apache/lucene-solr/pull/1572#discussion_r441854963 ## File path: solr/core/src/java/org/apache/solr/core/SolrPaths.java ## @@ -128,4 +130,33 @@ private static void logOnceInfo(String key, String msg) {

[GitHub] [lucene-solr] s1monw opened a new pull request #1590: LUCENE-9408: Ensure OneMerge#mergeFinished is only called once

2020-06-17 Thread GitBox
s1monw opened a new pull request #1590: URL: https://github.com/apache/lucene-solr/pull/1590 in the case of an exception it's possible that some OneMerge instances will be closed multiple times. This commit ensures that mergeFinished is really just called once instead of multiple times

[jira] [Commented] (SOLR-14574) Fix or suppress warnings in solr/core/src/test

2020-06-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138857#comment-17138857 ] ASF subversion and git services commented on SOLR-14574: Commit 1

[jira] [Commented] (SOLR-14574) Fix or suppress warnings in solr/core/src/test

2020-06-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138856#comment-17138856 ] ASF subversion and git services commented on SOLR-14574: Commit b

[jira] [Commented] (LUCENE-9408) OneMerge#mergeFinish is called multiple times

2020-06-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138847#comment-17138847 ] ASF subversion and git services commented on LUCENE-9408: - Commi

[jira] [Commented] (LUCENE-9408) OneMerge#mergeFinish is called multiple times

2020-06-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138844#comment-17138844 ] ASF subversion and git services commented on LUCENE-9408: - Commi

[jira] [Created] (LUCENE-9408) OneMerge#mergeFinish is called multiple times

2020-06-17 Thread Simon Willnauer (Jira)
Simon Willnauer created LUCENE-9408: --- Summary: OneMerge#mergeFinish is called multiple times Key: LUCENE-9408 URL: https://issues.apache.org/jira/browse/LUCENE-9408 Project: Lucene - Core I

[GitHub] [lucene-solr] mrsoong opened a new pull request #1589: SOLR-13195: added check for missing shards param in SearchHandler

2020-06-17 Thread GitBox
mrsoong opened a new pull request #1589: URL: https://github.com/apache/lucene-solr/pull/1589 # Description The distributedProcess methods of the search pipeline never checks to see if a request has a shards parameter, eventhough a shards param is required if SOLR is not

[jira] [Commented] (SOLR-14567) Fix or suppress remaining warnings in solrj

2020-06-17 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138836#comment-17138836 ] Erick Erickson commented on SOLR-14567: --- [~megancarey] At this point, I'm not fixin

[jira] [Commented] (LUCENE-8962) Can we merge small segments during refresh, for faster searching?

2020-06-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138827#comment-17138827 ] ASF subversion and git services commented on LUCENE-8962: - Commi

[jira] [Commented] (LUCENE-8962) Can we merge small segments during refresh, for faster searching?

2020-06-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138826#comment-17138826 ] ASF subversion and git services commented on LUCENE-8962: - Commi

[jira] [Commented] (LUCENE-8962) Can we merge small segments during refresh, for faster searching?

2020-06-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138820#comment-17138820 ] ASF subversion and git services commented on LUCENE-8962: - Commi

[jira] [Commented] (LUCENE-8962) Can we merge small segments during refresh, for faster searching?

2020-06-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138821#comment-17138821 ] ASF subversion and git services commented on LUCENE-8962: - Commi

[GitHub] [lucene-solr] s1monw merged pull request #1585: LUCENE-8962: Allow waiting for all merges in a merge spec

2020-06-17 Thread GitBox
s1monw merged pull request #1585: URL: https://github.com/apache/lucene-solr/pull/1585 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1541: RegExp - add case insensitive matching option

2020-06-17 Thread GitBox
jimczi commented on a change in pull request #1541: URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r441813998 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java ## @@ -743,6 +792,30 @@ private Automaton toAutomatonInternal(Map auto

[jira] [Commented] (LUCENE-9328) SortingGroupHead to reuse DocValues

2020-06-17 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138772#comment-17138772 ] Mikhail Khludnev commented on LUCENE-9328: -- Recently, the following wrong state

[jira] [Commented] (SOLR-14567) Fix or suppress remaining warnings in solrj

2020-06-17 Thread Megan Carey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138751#comment-17138751 ] Megan Carey commented on SOLR-14567: [~erickerickson] - is there any chance you're co

[jira] [Commented] (LUCENE-8574) ExpressionFunctionValues should cache per-hit value

2020-06-17 Thread Haoyu Zhai (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138710#comment-17138710 ] Haoyu Zhai commented on LUCENE-8574: Ah, yes will use boolean instead of NaN. I'm ju

[jira] [Commented] (LUCENE-9322) Discussing a unified vectors format API

2020-06-17 Thread Varun Thacker (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138707#comment-17138707 ] Varun Thacker commented on LUCENE-9322: --- JDK    {code:java} openjdk version "1.8.

[GitHub] [lucene-solr] tflobbe opened a new pull request #1588: SOLR-14577: Return BAD REQUEST when field is missing in terms QP

2020-06-17 Thread GitBox
tflobbe opened a new pull request #1588: URL: https://github.com/apache/lucene-solr/pull/1588 It will currently throw a NPE, resulting in a server error. This is an automated message from the Apache Git Service. To respond to

[jira] [Updated] (SOLR-14507) Option to allow location override if solr.hdfs.home isn't set in backup repo

2020-06-17 Thread Haley Reeve (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haley Reeve updated SOLR-14507: --- Attachment: SOLR-14507-2.patch Status: Patch Available (was: Patch Available) > Option to al

[jira] [Created] (SOLR-14577) NPE in terms query parser when field is not provided

2020-06-17 Thread Tomas Eduardo Fernandez Lobbe (Jira)
Tomas Eduardo Fernandez Lobbe created SOLR-14577: Summary: NPE in terms query parser when field is not provided Key: SOLR-14577 URL: https://issues.apache.org/jira/browse/SOLR-14577 Pro

[jira] [Commented] (SOLR-14507) Option to allow location override if solr.hdfs.home isn't set in backup repo

2020-06-17 Thread Haley Reeve (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138636#comment-17138636 ] Haley Reeve commented on SOLR-14507: I've talked with [~krisden] about the approach,

[jira] [Updated] (SOLR-14507) Option to allow location override if solr.hdfs.home isn't set in backup repo

2020-06-17 Thread Haley Reeve (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haley Reeve updated SOLR-14507: --- Description: The Solr backup/restore API has an optional parameter for specifying the directory to b

[jira] [Updated] (SOLR-14507) Option to allow location override if solr.hdfs.home isn't set in backup repo

2020-06-17 Thread Haley Reeve (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haley Reeve updated SOLR-14507: --- Summary: Option to allow location override if solr.hdfs.home isn't set in backup repo (was: Option t

[GitHub] [lucene-solr] johtani commented on pull request #1577: LUCENE-9390: JapaneseTokenizer discards token that is all punctuation characters only

2020-06-17 Thread GitBox
johtani commented on pull request #1577: URL: https://github.com/apache/lucene-solr/pull/1577#issuecomment-645467080 I added NBest test case. And also I changed registerNode. However, there is no difference between changing it or not changing it... Am I missing something test case?

[GitHub] [lucene-solr] johtani commented on a change in pull request #1577: LUCENE-9390: JapaneseTokenizer discards token that is all punctuation characters only

2020-06-17 Thread GitBox
johtani commented on a change in pull request #1577: URL: https://github.com/apache/lucene-solr/pull/1577#discussion_r441647603 ## File path: lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseTokenizer.java ## @@ -1917,4 +1917,15 @@ private static boolean

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1543: LUCENE-9378: Disable compression on binary values whose length is less than 32.

2020-06-17 Thread GitBox
mikemccand commented on a change in pull request #1543: URL: https://github.com/apache/lucene-solr/pull/1543#discussion_r441635457 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java ## @@ -762,6 +764,97 @@ public BytesRef binary

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1543: LUCENE-9378: Disable compression on binary values whose length is less than 32.

2020-06-17 Thread GitBox
mikemccand commented on a change in pull request #1543: URL: https://github.com/apache/lucene-solr/pull/1543#discussion_r441634757 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java ## @@ -404,32 +406,51 @@ private void flushDat

[jira] [Commented] (SOLR-14572) Ref Guide doesn't cover all SearchComponents on the Search Components page

2020-06-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138535#comment-17138535 ] ASF subversion and git services commented on SOLR-14572: Commit 2

[GitHub] [lucene-solr] epugh merged pull request #1581: SOLR-14572 document missing SearchComponents

2020-06-17 Thread GitBox
epugh merged pull request #1581: URL: https://github.com/apache/lucene-solr/pull/1581 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Commented] (SOLR-5894) Speed up high-cardinality facets with sparse counters

2020-06-17 Thread Toke Eskildsen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138482#comment-17138482 ] Toke Eskildsen commented on SOLR-5894: -- Caching of term counts has been shown by SOL

[GitHub] [lucene-solr] s1monw closed pull request #1576: Alternative approach to LUCENE-8962

2020-06-17 Thread GitBox
s1monw closed pull request #1576: URL: https://github.com/apache/lucene-solr/pull/1576 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] s1monw commented on pull request #1576: Alternative approach to LUCENE-8962

2020-06-17 Thread GitBox
s1monw commented on pull request #1576: URL: https://github.com/apache/lucene-solr/pull/1576#issuecomment-645405813 superseded by #1585 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [lucene-solr] s1monw commented on pull request #1585: LUCENE-8962: Allow waiting for all merges in a merge spec

2020-06-17 Thread GitBox
s1monw commented on pull request #1585: URL: https://github.com/apache/lucene-solr/pull/1585#issuecomment-645403443 @mikemccand @msokolov @msfroh @dsmiley I pushed a new commit to address your comments. thanks you! This is a

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1585: LUCENE-8962: Allow waiting for all merges in a merge spec

2020-06-17 Thread GitBox
s1monw commented on a change in pull request #1585: URL: https://github.com/apache/lucene-solr/pull/1585#discussion_r441581487 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -4289,7 +4287,7 @@ private synchronized void mergeFinish(MergePolicy

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1585: LUCENE-8962: Allow waiting for all merges in a merge spec

2020-06-17 Thread GitBox
s1monw commented on a change in pull request #1585: URL: https://github.com/apache/lucene-solr/pull/1585#discussion_r441575828 ## File path: lucene/core/src/java/org/apache/lucene/index/MergePolicy.java ## @@ -196,6 +200,7 @@ final void setMergeThread(Thread owner) { *

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1585: LUCENE-8962: Allow waiting for all merges in a merge spec

2020-06-17 Thread GitBox
mikemccand commented on a change in pull request #1585: URL: https://github.com/apache/lucene-solr/pull/1585#discussion_r441559509 ## File path: lucene/core/src/java/org/apache/lucene/index/MergePolicy.java ## @@ -196,6 +200,7 @@ final void setMergeThread(Thread owner) { *

[GitHub] [lucene-solr] epugh commented on a change in pull request #1581: SOLR-14572 document missing SearchComponents

2020-06-17 Thread GitBox
epugh commented on a change in pull request #1581: URL: https://github.com/apache/lucene-solr/pull/1581#discussion_r441528031 ## File path: solr/solr-ref-guide/src/requesthandlers-and-searchcomponents-in-solrconfig.adoc ## @@ -169,3 +169,14 @@ Many of the other useful componen

[jira] [Commented] (SOLR-14532) Add iml file to gitignore

2020-06-17 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138390#comment-17138390 ] Jason Gerlowski commented on SOLR-14532: Sure, will take a look this afternoon.

[GitHub] [lucene-solr] danmfox commented on a change in pull request #1514: SOLR-13749: Change cross-collection join query syntax to {!join method=crossCollection ...}

2020-06-17 Thread GitBox
danmfox commented on a change in pull request #1514: URL: https://github.com/apache/lucene-solr/pull/1514#discussion_r441494859 ## File path: solr/core/src/java/org/apache/solr/search/JoinQParserPlugin.java ## @@ -160,23 +176,40 @@ JoinParams parseJoin(QParser qparser) throws S

[jira] [Commented] (SOLR-14532) Add iml file to gitignore

2020-06-17 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138379#comment-17138379 ] Andras Salamon commented on SOLR-14532: --- Uploaded a new patch which also contains t

[jira] [Updated] (SOLR-14532) Add iml file to gitignore

2020-06-17 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Salamon updated SOLR-14532: -- Attachment: SOLR-14532.patch > Add iml file to gitignore > - > >

[GitHub] [lucene-solr] someoneknown closed pull request #1587: Branch 8 5

2020-06-17 Thread GitBox
someoneknown closed pull request #1587: URL: https://github.com/apache/lucene-solr/pull/1587 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene-solr] someoneknown opened a new pull request #1587: Branch 8 5

2020-06-17 Thread GitBox
someoneknown opened a new pull request #1587: URL: https://github.com/apache/lucene-solr/pull/1587 # Description Please provide a short description of the changes you're making with this pull request. # Solution Please provide a short description of the appr

[jira] [Commented] (LUCENE-8574) ExpressionFunctionValues should cache per-hit value

2020-06-17 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138277#comment-17138277 ] Robert Muir commented on LUCENE-8574: - please, lets keep the boolean and not bring N

[GitHub] [lucene-solr] janhoy commented on pull request #1572: SOLR-14561 CoreAdminAPI's parameters instanceDir and dataDir are now validated

2020-06-17 Thread GitBox
janhoy commented on pull request #1572: URL: https://github.com/apache/lucene-solr/pull/1572#issuecomment-645245313 The tests still don't pass on Windows, and I have found the reason. Will push a few more changes on friday.

[jira] [Commented] (LUCENE-9359) SegmentInfos.readCommit should verify checksums in case of error

2020-06-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138186#comment-17138186 ] ASF subversion and git services commented on LUCENE-9359: - Commi

[jira] [Commented] (LUCENE-9359) SegmentInfos.readCommit should verify checksums in case of error

2020-06-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138185#comment-17138185 ] ASF subversion and git services commented on LUCENE-9359: - Commi