s1monw commented on a change in pull request #1585:
URL: https://github.com/apache/lucene-solr/pull/1585#discussion_r441581487
##########
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##########
@@ -4289,7 +4287,7 @@ private synchronized void
mergeFinish(MergePolicy.OneMerge merge) {
@SuppressWarnings("try")
private synchronized void closeMergeReaders(MergePolicy.OneMerge merge,
boolean suppressExceptions) throws IOException {
final boolean drop = suppressExceptions == false;
- try (Closeable finalizer = merge::mergeFinished) {
+ try (Closeable finalizer = () ->
merge.mergeFinished(suppressExceptions==false)) {
Review comment:
done
##########
File path: lucene/core/src/java/org/apache/lucene/index/MergePolicy.java
##########
@@ -399,6 +427,23 @@ public String segString(Directory dir) {
}
return b.toString();
}
+
+ /**
+ * Waits if necessary for at most the given time for all merges.
+ */
+ boolean await(long timeout, TimeUnit unit) {
+ try {
+ CompletableFuture<Void> future =
CompletableFuture.allOf(merges.stream()
+ .map(m -> m.completable).collect(Collectors.toList()).toArray(new
CompletableFuture<?>[0]));
+ future.get(timeout, unit);
+ return true;
+ } catch (InterruptedException e) {
+ Thread.interrupted();
Review comment:
done
##########
File path: lucene/core/src/java/org/apache/lucene/index/MergePolicy.java
##########
@@ -399,6 +427,23 @@ public String segString(Directory dir) {
}
return b.toString();
}
+
+ /**
+ * Waits if necessary for at most the given time for all merges.
+ */
+ boolean await(long timeout, TimeUnit unit) {
+ try {
+ CompletableFuture<Void> future =
CompletableFuture.allOf(merges.stream()
Review comment:
done thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
