janhoy commented on a change in pull request #1572:
URL: https://github.com/apache/lucene-solr/pull/1572#discussion_r441856227
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -1259,6 +1277,28 @@ public SolrCore create(String coreName, Path
instancePath, Map<String, String> p
}
}
+ /**
+ * Checks that the given path is relative to SOLR_HOME, SOLR_DATA_HOME,
coreRootDirectory or one of the paths
+ * specified in solr.xml's allowPaths element. Delegates to {@link
SolrPaths#assertPathAllowed(Path, Set)}
+ * @param pathToAssert path to check
+ * @throws SolrException if path is outside allowed paths
+ */
+ public void assertPathAllowed(Path pathToAssert) throws SolrException {
+ SolrPaths.assertPathAllowed(pathToAssert, allowPaths);
+ }
+
+ /**
+ * <p>Return the file system paths that should be allowed for various API
requests.
Review comment:
@dsmiley see JavaDoc. I was hoping to keep this method private. Don't we
have a special annotation that will allow access from test scope even if the
method is not public?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
