[
https://issues.apache.org/jira/browse/SOLR-14567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138836#comment-17138836
]
Erick Erickson commented on SOLR-14567:
---------------------------------------
[~megancarey] At this point, I'm not fixing much of anything, just adding a
zillion SuppressWarnings. When I started this there were over 8,000
unsuppressed warnings in the code, far to many to actually fix. Some trivial
ones I _am_ fixing, things like adding the diamond operator to code like:
{code:java}
List<String> blah = new ArrayList(); {code}
but that's about as deep as I'm going at this point.
My hope is to get the warnings suppressed, then start failing compilations when
new code generates warnings so people either have to explicitly suppress them
or find a better way. I expect that process to be ongoing forever, but at least
there'll be a chance to stop getting worse. And that'll expose things like
NEW_HASHMAP_FUN...
As for NEW_HASHMAP_FUN itself, I confess I haven't looked at it at all. If
you'd like to raise a Jira about taking it out that would be fine. I won't be
getting to that kind of work in the foreseeable future, so someone would need
to volunteer to do the actual surgery, although I'd be happy to push it to the
code base.
> Fix or suppress remaining warnings in solrj
> -------------------------------------------
>
> Key: SOLR-14567
> URL: https://issues.apache.org/jira/browse/SOLR-14567
> Project: Solr
> Issue Type: Sub-task
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
> Fix For: 8.6
>
>
> This is another place where the number of warnings per directory is getting
> too small to do individually, so I'll do them all in a bunch.
> Note: this will exclude autoscaling.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
