[jira] [Commented] (SOLR-14541) Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-08 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128905#comment-17128905 ] Noble Paul commented on SOLR-14541: --- all the classes in the autoscaling packages are sa

[jira] [Commented] (SOLR-8392) SolrParam.get(String) returns String and shouldn't be used in other instanceof checks

2020-06-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128878#comment-17128878 ] David Smiley commented on SOLR-8392: bq. It looks like we use raw types somewhere to s

[jira] [Commented] (LUCENE-9395) ConstantValuesSource creates more than one DoubleValues unnecessarily

2020-06-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128876#comment-17128876 ] David Smiley commented on LUCENE-9395: -- Hello! {{org.apache.lucene.search.DoubleVa

[jira] [Commented] (LUCENE-9395) ConstantValuesSource creates more than one DoubleValues unnecessarily

2020-06-08 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128849#comment-17128849 ] Lucene/Solr QA commented on LUCENE-9395: | (x) *{color:red}-1 overall{color}* |

[jira] [Commented] (LUCENE-9392) Change the visibility of o.a.l.f.FacetsConfig.DELIM_CHAR to public

2020-06-08 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128822#comment-17128822 ] Lucene/Solr QA commented on LUCENE-9392: | (x) *{color:red}-1 overall{color}* |

[jira] [Updated] (LUCENE-9395) ConstantValuesSource creates more than one DoubleValues unnecessarily

2020-06-08 Thread Tony Xu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tony Xu updated LUCENE-9395: Status: Patch Available (was: Open) > ConstantValuesSource creates more than one DoubleValues unnecessari

[jira] [Commented] (LUCENE-9395) ConstantValuesSource creates more than one DoubleValues unnecessarily

2020-06-08 Thread Tony Xu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128723#comment-17128723 ] Tony Xu commented on LUCENE-9395: - simple patch added for the eager initialization appro

[jira] [Updated] (LUCENE-9395) ConstantValuesSource creates more than one DoubleValues unnecessarily

2020-06-08 Thread Tony Xu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tony Xu updated LUCENE-9395: Attachment: LUCENE-9395.patch > ConstantValuesSource creates more than one DoubleValues unnecessarily > -

[jira] [Commented] (SOLR-14545) Fix or suppress warnings in apache/solr/update

2020-06-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128720#comment-17128720 ] ASF subversion and git services commented on SOLR-14545: Commit 9

[jira] [Resolved] (SOLR-14545) Fix or suppress warnings in apache/solr/update

2020-06-08 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-14545. --- Fix Version/s: 8.6 Resolution: Fixed > Fix or suppress warnings in apache/solr/update

[jira] [Commented] (SOLR-14545) Fix or suppress warnings in apache/solr/update

2020-06-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128718#comment-17128718 ] ASF subversion and git services commented on SOLR-14545: Commit 4

[jira] [Updated] (LUCENE-9392) Change the visibility of o.a.l.f.FacetsConfig.DELIM_CHAR to public

2020-06-08 Thread Ankur (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankur updated LUCENE-9392: -- Attachment: (was: LUCENE-9392.patch) > Change the visibility of o.a.l.f.FacetsConfig.DELIM_CHAR to public

[jira] [Updated] (LUCENE-9392) Change the visibility of o.a.l.f.FacetsConfig.DELIM_CHAR to public

2020-06-08 Thread Ankur (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankur updated LUCENE-9392: -- Attachment: LUCENE-9392.patch Lucene Fields: New,Patch Available (was: New) Status: Patch Av

[jira] [Commented] (LUCENE-9395) ConstantValuesSource creates more than one DoubleValues unnecessarily

2020-06-08 Thread Tony Xu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128699#comment-17128699 ] Tony Xu commented on LUCENE-9395: - I believe the eager initialization would work for mos

[jira] [Updated] (LUCENE-9395) ConstantValuesSource creates more than one DoubleValues unnecessarily

2020-06-08 Thread Tony Xu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tony Xu updated LUCENE-9395: Description: At my day job, we use ConstantValuesSource to represent default values or a constant query-l

[jira] [Updated] (LUCENE-9395) ConstantValuesSource creates more than one DoubleValues unnecessarily

2020-06-08 Thread Tony Xu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tony Xu updated LUCENE-9395: Description: At day job, we use ConstantValuesSource to represent default values or a constant query-leve

[jira] [Created] (LUCENE-9395) ConstantValuesSource creates DoubleValues unnecessarily

2020-06-08 Thread Tony Xu (Jira)
Tony Xu created LUCENE-9395: --- Summary: ConstantValuesSource creates DoubleValues unnecessarily Key: LUCENE-9395 URL: https://issues.apache.org/jira/browse/LUCENE-9395 Project: Lucene - Core Issue

[jira] [Updated] (LUCENE-9395) ConstantValuesSource creates more than one DoubleValues unnecessarily

2020-06-08 Thread Tony Xu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tony Xu updated LUCENE-9395: Summary: ConstantValuesSource creates more than one DoubleValues unnecessarily (was: ConstantValuesSourc

[jira] [Commented] (SOLR-14383) Fix indexing-nested-documents.adoc XML/JSON examples to be accurate, consistent, and clear

2020-06-08 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128682#comment-17128682 ] Chris M. Hostetter commented on SOLR-14383: --- i was recently reminded of this Ji

[jira] [Commented] (LUCENE-9392) Change the visibility of o.a.l.f.FacetsConfig.DELIM_CHAR to public

2020-06-08 Thread Ankur (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128678#comment-17128678 ] Ankur commented on LUCENE-9392: --- Attached a patch with a fix that raises the visibility of

[jira] [Commented] (LUCENE-9392) Change the visibility of o.a.l.f.FacetsConfig.DELIM_CHAR to public

2020-06-08 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128677#comment-17128677 ] Michael McCandless commented on LUCENE-9392: Thanks [~goankur] – could you p

[jira] [Updated] (LUCENE-9392) Change the visibility of o.a.l.f.FacetsConfig.DELIM_CHAR to public

2020-06-08 Thread Ankur (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankur updated LUCENE-9392: -- Status: Patch Available (was: Open) > Change the visibility of o.a.l.f.FacetsConfig.DELIM_CHAR to public > -

[jira] [Updated] (LUCENE-9392) Change the visibility of o.a.l.f.FacetsConfig.DELIM_CHAR to public

2020-06-08 Thread Ankur (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankur updated LUCENE-9392: -- Attachment: LUCENE-9392.patch > Change the visibility of o.a.l.f.FacetsConfig.DELIM_CHAR to public >

[jira] [Comment Edited] (SOLR-14546) OverseerTaskProcessor can process messages out of order

2020-06-08 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128157#comment-17128157 ] Ilan Ginzburg edited comment on SOLR-14546 at 6/8/20, 9:01 PM:

[jira] [Commented] (SOLR-8392) SolrParam.get(String) returns String and shouldn't be used in other instanceof checks

2020-06-08 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128617#comment-17128617 ] Erick Erickson commented on SOLR-8392: -- Kudos for tackling this. This kind of thing i

[jira] [Commented] (SOLR-13132) Improve JSON "terms" facet performance when sorted by relatedness

2020-06-08 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128463#comment-17128463 ] Michael Gibney commented on SOLR-13132: --- Regarding: a6b1c60e61563535d7ba67c17d74f2b

[jira] [Created] (SOLR-14548) Address warning: static member should be qualified by type name

2020-06-08 Thread Mike Drob (Jira)
Mike Drob created SOLR-14548: Summary: Address warning: static member should be qualified by type name Key: SOLR-14548 URL: https://issues.apache.org/jira/browse/SOLR-14548 Project: Solr Issue T

[jira] [Assigned] (SOLR-14548) Address warning: static member should be qualified by type name

2020-06-08 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob reassigned SOLR-14548: Assignee: Mike Drob > Address warning: static member should be qualified by type name > --

[jira] [Assigned] (SOLR-14537) Improve performance of ExportWriter

2020-06-08 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki reassigned SOLR-14537: --- Assignee: Andrzej Bialecki > Improve performance of ExportWriter > -

[jira] [Commented] (LUCENE-9394) Fix or suppress compile-time warnings

2020-06-08 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128368#comment-17128368 ] Erick Erickson commented on LUCENE-9394: I'm not dealing with deprecations at pr

[jira] [Commented] (LUCENE-9394) Fix or suppress compile-time warnings

2020-06-08 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128361#comment-17128361 ] Michael Sokolov commented on LUCENE-9394: - Looking at the warnings in Lucene cod

[jira] [Resolved] (SOLR-14470) Add streaming expressions to /export handler

2020-06-08 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-14470. - Resolution: Fixed > Add streaming expressions to /export handler > --

[jira] [Updated] (SOLR-14470) Add streaming expressions to /export handler

2020-06-08 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-14470: Fix Version/s: 8.6 > Add streaming expressions to /export handler > ---

[jira] [Commented] (SOLR-14470) Add streaming expressions to /export handler

2020-06-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128347#comment-17128347 ] ASF subversion and git services commented on SOLR-14470: Commit 1

[jira] [Created] (LUCENE-9394) Fix or suppress compile-time warnings

2020-06-08 Thread Michael Sokolov (Jira)
Michael Sokolov created LUCENE-9394: --- Summary: Fix or suppress compile-time warnings Key: LUCENE-9394 URL: https://issues.apache.org/jira/browse/LUCENE-9394 Project: Lucene - Core Issue Typ

[jira] [Commented] (SOLR-14470) Add streaming expressions to /export handler

2020-06-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128322#comment-17128322 ] ASF subversion and git services commented on SOLR-14470: Commit 3

[jira] [Created] (SOLR-14547) Fix or suppress warnings in solr/client/solrj/io/stream

2020-06-08 Thread Erick Erickson (Jira)
Erick Erickson created SOLR-14547: - Summary: Fix or suppress warnings in solr/client/solrj/io/stream Key: SOLR-14547 URL: https://issues.apache.org/jira/browse/SOLR-14547 Project: Solr Issue

[jira] [Commented] (SOLR-14524) Harden MultiThreadedOCPTest

2020-06-08 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128270#comment-17128270 ] Erick Erickson commented on SOLR-14524: --- Oh my. This could account multiple test is

[jira] [Updated] (SOLR-14541) Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-08 Thread Erik Hatcher (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Hatcher updated SOLR-14541: Summary: Ensure classes that implement equals implement hashCode or suppress warnings (was: Insure

[jira] [Commented] (SOLR-14546) OverseerTaskProcessor can process messages out of order

2020-06-08 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128157#comment-17128157 ] Ilan Ginzburg commented on SOLR-14546: -- I might understand a few things that appeare

[jira] [Commented] (SOLR-14347) Autoscaling placement wrong when concurrent replica placements are calculated

2020-06-08 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128135#comment-17128135 ] Ilan Ginzburg commented on SOLR-14347: -- [~ab] do you think you'll be able to have a

[jira] [Updated] (SOLR-14546) OverseerTaskProcessor can process messages out of order

2020-06-08 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ilan Ginzburg updated SOLR-14546: - Description: *Summary:*  Collection API and ConfigSet API messages can be processed out of order

[jira] [Updated] (SOLR-14546) OverseerTaskProcessor can process messages out of order

2020-06-08 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ilan Ginzburg updated SOLR-14546: - Description: *Summary:*  Collection API and ConfigSet API messages can be processed out of order

[jira] [Commented] (SOLR-14524) Harden MultiThreadedOCPTest

2020-06-08 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128122#comment-17128122 ] Ilan Ginzburg commented on SOLR-14524: -- I've created SOLR-14546. There is a possibl

[jira] [Created] (SOLR-14546) OverseerTaskProcessor can process messages out of order

2020-06-08 Thread Ilan Ginzburg (Jira)
Ilan Ginzburg created SOLR-14546: Summary: OverseerTaskProcessor can process messages out of order Key: SOLR-14546 URL: https://issues.apache.org/jira/browse/SOLR-14546 Project: Solr Issue Ty

[jira] [Resolved] (SOLR-9679) Exception when removing zk node /security.json

2020-06-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-9679. --- Resolution: Fixed Test failure was a timing issue. We immediately fired a search after removing secur

[jira] [Commented] (SOLR-9679) Exception when removing zk node /security.json

2020-06-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128026#comment-17128026 ] ASF subversion and git services commented on SOLR-9679: --- Commit 3e53

[jira] [Commented] (SOLR-9679) Exception when removing zk node /security.json

2020-06-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128027#comment-17128027 ] ASF subversion and git services commented on SOLR-9679: --- Commit 0035

[jira] [Reopened] (SOLR-9679) Exception when removing zk node /security.json

2020-06-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reopened SOLR-9679: --- Re-opening to investigate test failure > Exception when removing zk node /security.json > ---

[GitHub] [lucene-solr] iverase commented on a change in pull request #1475: LUCENE-9148: Move the BKD index to its own file.

2020-06-08 Thread GitBox
iverase commented on a change in pull request #1475: URL: https://github.com/apache/lucene-solr/pull/1475#discussion_r436514171 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java ## @@ -627,20 +638,20 @@ assert valueInOrder(valueCount + leafCount,

[GitHub] [lucene-solr] iverase commented on a change in pull request #1475: LUCENE-9148: Move the BKD index to its own file.

2020-06-08 Thread GitBox
iverase commented on a change in pull request #1475: URL: https://github.com/apache/lucene-solr/pull/1475#discussion_r436513642 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene86/Lucene86PointsWriter.java ## @@ -0,0 +1,262 @@ +/* + * Licensed to the Apache So