[ 
https://issues.apache.org/jira/browse/LUCENE-9394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128368#comment-17128368
 ] 

Erick Erickson commented on LUCENE-9394:
----------------------------------------

I'm not dealing with deprecations at present ;) That's on my list for after 
this first pass where I'm concentrating on everything else. The deprecations 
will take lots more thought. There's been some discussion at SOLR-13138

Meanwhile, the Gradle build explicitly does _not_ list them individually, just 
a comment on recompiling if you really want to see them. It's an open question 
whether we _should_ fail on deprecations, most likely "only selected ones" 
since we have back-compat promises. My idea here is to go through the 
deprecations and fix the ones in master only that were deprecated before 8.0 
and annotate the rest. I'd also like to enforce that every deprecation message 
tells us both what version it was deprecated in and what to use instead. But 
that's all for the future.

Deprecations will be a whole 'nother discussion. My straw-man proposal is that, 
for anything deprecated prior to 8.0 we should "do something", where 
"something" is one of
 * remove it and use the replacement
 * if it's a case of changing the visibility, say making it private, then make 
it private and remove the deprecation annotation
 * ???

The end goal here is that for version X, there are no deprecation usages in the 
code that were deprecated as of X-1. Whether that's achievable or not will be 
"interesting". This may be one of those things that's not worth the effort...

 

 

 

 

> Fix or suppress compile-time warnings
> -------------------------------------
>
>                 Key: LUCENE-9394
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9394
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael Sokolov
>            Priority: Major
>
> This is a spinoff from [~erickerickson]'s efforts over in  SOLR-10778 
> The goal is a warning-free compilation, followed by enforcement of build 
> failure on warnings, with the idea of suppressing innocuous warnings to the 
> extent that the remaining warnings be treated as build failure.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to