iverase commented on a change in pull request #1475:
URL: https://github.com/apache/lucene-solr/pull/1475#discussion_r436514171
##########
File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java
##########
@@ -627,20 +638,20 @@ assert valueInOrder(valueCount + leafCount,
assert (lastDocID = docID) >= 0; // only assign when asserts are enabled
}
- public long finish() throws IOException {
+ public Runnable finish() throws IOException {
if (leafCount > 0) {
writeLeafBlock(leafCardinality);
leafCardinality = 0;
leafCount = 0;
}
if (valueCount == 0) {
- return -1;
+ return null;
}
pointCount = valueCount;
- long indexFP = out.getFilePointer();
+ long indexFP = indexOut.getFilePointer();
Review comment:
Not used any more?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
