[jira] [Commented] (LUCENE-9355) missing releases from testbackwardscompatibility

2020-05-01 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097799#comment-17097799 ] Noble Paul commented on LUCENE-9355: How do you see this error? [~janhoy] any inputs

[GitHub] [lucene-solr] mocobeta commented on pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-01 Thread GitBox
mocobeta commented on pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#issuecomment-622650749 I am not sure if it's worth here, "render-javadoc.gradle" has a utility method to convert project path into output doc folder path: https://github.com/apache/lucene-solr/bl

[GitHub] [lucene-solr] mocobeta commented on pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-01 Thread GitBox
mocobeta commented on pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#issuecomment-622650279 I was not aware of that this task depends on projects' relative paths. To me, before proceeding it we need to manage to reach a consensus about the destination (output) dir

[jira] [Updated] (LUCENE-9354) Refresh French stop words to remove homonyms

2020-05-01 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9354: Fix Version/s: trunk > Refresh French stop words to remove homonyms >

[jira] [Resolved] (LUCENE-9354) Refresh French stop words to remove homonyms

2020-05-01 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9354. - Resolution: Fixed Thanks [~philippe@camellia] for submitting these improvements to snowball and

[jira] [Assigned] (LUCENE-9354) Refresh French stop words to remove homonyms

2020-05-01 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir reassigned LUCENE-9354: --- Assignee: Robert Muir > Refresh French stop words to remove homonyms >

[jira] [Commented] (LUCENE-9354) Refresh French stop words to remove homonyms

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097770#comment-17097770 ] ASF subversion and git services commented on LUCENE-9354: - Commi

[jira] [Commented] (LUCENE-9354) Refresh French stop words to remove homonyms

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097771#comment-17097771 ] ASF subversion and git services commented on LUCENE-9354: - Commi

[jira] [Commented] (LUCENE-9354) Refresh French stop words to remove homonyms

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097772#comment-17097772 ] ASF subversion and git services commented on LUCENE-9354: - Commi

[jira] [Comment Edited] (LUCENE-9321) Port documentation task to gradle

2020-05-01 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097754#comment-17097754 ] Tomoko Uchida edited comment on LUCENE-9321 at 5/2/20, 12:16 AM: -

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-01 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097754#comment-17097754 ] Tomoko Uchida commented on LUCENE-9321: --- As to precommit / javadoc linting, at the

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-01 Thread GitBox
uschindler commented on a change in pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#discussion_r418783252 ## File path: gradle/documentation/documentation.gradle ## @@ -34,4 +36,11 @@ configure(subprojects.findAll { it.path == ':lucene' || it.path == '

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-01 Thread GitBox
uschindler commented on a change in pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#discussion_r418783353 ## File path: gradle/documentation/markdown.gradle ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-01 Thread GitBox
uschindler commented on a change in pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#discussion_r418783252 ## File path: gradle/documentation/documentation.gradle ## @@ -34,4 +36,11 @@ configure(subprojects.findAll { it.path == ':lucene' || it.path == '

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
MarcusSorealheis commented on a change in pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r418779981 ## File path: solr/core/src/java/org/apache/solr/servlet/LoadAdminUiServlet.java ## @@ -24,29 +31,26 @@ import org.apache.solr.core.CoreCont

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
MarcusSorealheis commented on a change in pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r418779755 ## File path: solr/core/src/java/org/apache/solr/servlet/LoadAdminUiServlet.java ## @@ -24,29 +31,26 @@ import org.apache.solr.core.CoreCont

[GitHub] [lucene-solr] janhoy commented on a change in pull request #341: SOLR-12131: ExternalRoleRuleBasedAuthorizationPlugin

2020-05-01 Thread GitBox
janhoy commented on a change in pull request #341: URL: https://github.com/apache/lucene-solr/pull/341#discussion_r418774258 ## File path: solr/solr-ref-guide/src/rule-based-authorization-plugin.adoc ## @@ -64,6 +66,34 @@ There are several things defined in this example: <5> T

[GitHub] [lucene-solr] uschindler edited a comment on pull request #1479: LUCENE-9278: Improved options file creation

2020-05-01 Thread GitBox
uschindler edited a comment on pull request #1479: URL: https://github.com/apache/lucene-solr/pull/1479#issuecomment-622603848 Example options file like created on my computer: ``` -overview 'C:\\Users\\Uwe Schindler\\Projects\\lucene\\trunk-lusolr1\\lucene\\core\\src\\java\\overv

[GitHub] [lucene-solr] uschindler edited a comment on pull request #1479: LUCENE-9278: Improved options file creation

2020-05-01 Thread GitBox
uschindler edited a comment on pull request #1479: URL: https://github.com/apache/lucene-solr/pull/1479#issuecomment-622603848 Example options file like created on my computer: ``` -overview 'C:\\Users\\Uwe Schindler\\Projects\\lucene\\trunk-lusolr1\\lucene\\core\\src\\java\\overv

[jira] [Commented] (SOLR-13289) Support for BlockMax WAND

2020-05-01 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097729#comment-17097729 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-13289: -- Sounds good.

[GitHub] [lucene-solr] uschindler commented on pull request #1479: LUCENE-9278: Improved options file creation

2020-05-01 Thread GitBox
uschindler commented on pull request #1479: URL: https://github.com/apache/lucene-solr/pull/1479#issuecomment-622603848 Example options file like created on my computer: ``` -overview 'C:\\Users\\Uwe Schindler\\Projects\\lucene\\trunk-lusolr1\\lucene\\core\\src\\java\\overview.htm

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1456: SOLR-13289: Support for BlockMax WAND

2020-05-01 Thread GitBox
tflobbe commented on a change in pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r418772556 ## File path: solr/core/src/java/org/apache/solr/response/JSONWriter.java ## @@ -132,11 +133,16 @@ public void writeSolrDocument(String name, SolrDocu

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097726#comment-17097726 ] Uwe Schindler commented on LUCENE-9278: --- Here is a new PR: https://github.com/apac

[jira] [Commented] (SOLR-13132) Improve JSON "terms" facet performance when sorted by relatedness

2020-05-01 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097725#comment-17097725 ] Chris M. Hostetter commented on SOLR-13132: --- {quote}... If you don't think it's

[GitHub] [lucene-solr] uschindler opened a new pull request #1479: LUCENE-9278: Improved options file creation

2020-05-01 Thread GitBox
uschindler opened a new pull request #1479: URL: https://github.com/apache/lucene-solr/pull/1479 Improved version of the options file creator in the renderJavadocs task: All parameters are escaped automatically, arguments don't need to be strings (they are converted during building options

[GitHub] [lucene-solr] janhoy commented on pull request #341: SOLR-12131: ExternalRoleRuleBasedAuthorizationPlugin

2020-05-01 Thread GitBox
janhoy commented on pull request #341: URL: https://github.com/apache/lucene-solr/pull/341#issuecomment-622592651 > Wait, what happened to the ref guide changes? Hmm, will try to get them back This is an automated mess

[GitHub] [lucene-solr] madrob commented on a change in pull request #341: SOLR-12131: ExternalRoleRuleBasedAuthorizationPlugin

2020-05-01 Thread GitBox
madrob commented on a change in pull request #341: URL: https://github.com/apache/lucene-solr/pull/341#discussion_r418758313 ## File path: solr/core/src/test/org/apache/solr/security/PrincipalWithUserRoles.java ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1456: SOLR-13289: Support for BlockMax WAND

2020-05-01 Thread GitBox
tflobbe commented on a change in pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r418756851 ## File path: solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java ## @@ -401,6 +403,14 @@ public void process(ResponseBuilder rb

[GitHub] [lucene-solr] anshumg commented on a change in pull request #1456: SOLR-13289: Support for BlockMax WAND

2020-05-01 Thread GitBox
anshumg commented on a change in pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r418678327 ## File path: solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java ## @@ -401,6 +403,14 @@ public void process(ResponseBuilder rb

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1456: SOLR-13289: Support for BlockMax WAND

2020-05-01 Thread GitBox
tflobbe commented on a change in pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r418752582 ## File path: solr/core/src/java/org/apache/solr/search/QueryResultKey.java ## @@ -65,6 +70,7 @@ public QueryResultKey(Query query, List filters, Sort

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1456: SOLR-13289: Support for BlockMax WAND

2020-05-01 Thread GitBox
tflobbe commented on a change in pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r418750165 ## File path: solr/core/src/java/org/apache/solr/search/MaxScoreCollector.java ## @@ -37,9 +37,7 @@ public float getMaxScore() { @Override pub

[jira] [Commented] (SOLR-13289) Support for BlockMax WAND

2020-05-01 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097689#comment-17097689 ] David Smiley commented on SOLR-13289: - Yeah; lets just go with a simple-to-understand

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1456: SOLR-13289: Support for BlockMax WAND

2020-05-01 Thread GitBox
tflobbe commented on a change in pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r418749058 ## File path: solr/core/src/java/org/apache/solr/response/JSONWriter.java ## @@ -132,11 +133,16 @@ public void writeSolrDocument(String name, SolrDocu

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1456: SOLR-13289: Support for BlockMax WAND

2020-05-01 Thread GitBox
tflobbe commented on a change in pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r418748102 ## File path: solr/core/src/java/org/apache/solr/response/GeoJSONResponseWriter.java ## @@ -292,11 +293,18 @@ else if(geo instanceof WriteableGeoJSON

[jira] [Commented] (SOLR-14454) support for UTF-8 (string) types with DocValuesType.BINARY

2020-05-01 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097683#comment-17097683 ] Michael Gibney commented on SOLR-14454: --- [PR #1478|https://github.com/apache/lucene

[GitHub] [lucene-solr] madrob commented on a change in pull request #1456: SOLR-13289: Support for BlockMax WAND

2020-05-01 Thread GitBox
madrob commented on a change in pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r418739528 ## File path: solr/core/src/java/org/apache/solr/response/GeoJSONResponseWriter.java ## @@ -292,11 +293,18 @@ else if(geo instanceof WriteableGeoJSON)

[GitHub] [lucene-solr] magibney opened a new pull request #1478: SOLR-14454: support for UTF-8 (string) types with DocValuesType.BINARY

2020-05-01 Thread GitBox
magibney opened a new pull request #1478: URL: https://github.com/apache/lucene-solr/pull/1478 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Created] (SOLR-14454) support for UTF-8 (string) types with DocValuesType.BINARY

2020-05-01 Thread Michael Gibney (Jira)
Michael Gibney created SOLR-14454: - Summary: support for UTF-8 (string) types with DocValuesType.BINARY Key: SOLR-14454 URL: https://issues.apache.org/jira/browse/SOLR-14454 Project: Solr Iss

[jira] [Commented] (SOLR-13289) Support for BlockMax WAND

2020-05-01 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097678#comment-17097678 ] Mike Drob commented on SOLR-13289: -- Based on my understanding, I favor the boolean appro

[jira] [Commented] (SOLR-10814) Solr RuleBasedAuthorization config doesn't work seamlessly with kerberos authentication

2020-05-01 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097668#comment-17097668 ] Mike Drob commented on SOLR-10814: -- [~hgadre] - do you have any interest in picking this

[jira] [Created] (LUCENE-9355) missing releases from testbackwardscompatibility

2020-05-01 Thread Mike Drob (Jira)
Mike Drob created LUCENE-9355: - Summary: missing releases from testbackwardscompatibility Key: LUCENE-9355 URL: https://issues.apache.org/jira/browse/LUCENE-9355 Project: Lucene - Core Issue Type

[GitHub] [lucene-solr] janhoy commented on a change in pull request #341: SOLR-12131: ExternalRoleRuleBasedAuthorizationPlugin

2020-05-01 Thread GitBox
janhoy commented on a change in pull request #341: URL: https://github.com/apache/lucene-solr/pull/341#discussion_r418725066 ## File path: solr/core/src/java/org/apache/solr/security/RuleBasedAuthorizationPluginBase.java ## @@ -0,0 +1,270 @@ +/* + * Licensed to the Apache Soft

[jira] [Commented] (SOLR-13132) Improve JSON "terms" facet performance when sorted by relatedness

2020-05-01 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097660#comment-17097660 ] Michael Gibney commented on SOLR-13132: --- I was worrying about the order of sort key

[GitHub] [lucene-solr] janhoy commented on a change in pull request #341: SOLR-12131: ExternalRoleRuleBasedAuthorizationPlugin

2020-05-01 Thread GitBox
janhoy commented on a change in pull request #341: URL: https://github.com/apache/lucene-solr/pull/341#discussion_r418722327 ## File path: solr/core/src/java/org/apache/solr/security/PrincipalWithUserRoles.java ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [lucene-solr] janhoy commented on a change in pull request #341: SOLR-12131: ExternalRoleRuleBasedAuthorizationPlugin

2020-05-01 Thread GitBox
janhoy commented on a change in pull request #341: URL: https://github.com/apache/lucene-solr/pull/341#discussion_r418721727 ## File path: solr/core/src/java/org/apache/solr/security/PrincipalWithUserRoles.java ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [lucene-solr] madrob commented on a change in pull request #1371: SOLR-14333: print readable version of CollapsedPostFilter query

2020-05-01 Thread GitBox
madrob commented on a change in pull request #1371: URL: https://github.com/apache/lucene-solr/pull/1371#discussion_r418718546 ## File path: solr/core/src/java/org/apache/solr/search/CollapsingQParserPlugin.java ## @@ -128,6 +128,28 @@ field collapsing (with ngroups) when the

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097638#comment-17097638 ] Uwe Schindler commented on LUCENE-9278: --- Sorry map won't work, but similar data st

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097637#comment-17097637 ] Uwe Schindler commented on LUCENE-9278: --- bq. We can build the options file with th

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097635#comment-17097635 ] Uwe Schindler commented on LUCENE-9278: --- The standard doclet issue is the typical

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097628#comment-17097628 ] Dawid Weiss commented on LUCENE-9278: - Gradle javadoc task sucks in many ways... And

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097619#comment-17097619 ] Uwe Schindler commented on LUCENE-9278: --- I have to look it up. The source code of

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
MarcusSorealheis commented on a change in pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r418689669 ## File path: solr/core/src/java/org/apache/solr/servlet/LoadAdminUiServlet.java ## @@ -24,29 +31,26 @@ import org.apache.solr.core.CoreCont

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097610#comment-17097610 ] Uwe Schindler commented on LUCENE-9278: --- IMHO to improve this, we should build the

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097605#comment-17097605 ] Uwe Schindler commented on LUCENE-9278: --- Exactly! See my comment, too. > Make jav

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097606#comment-17097606 ] Dawid Weiss commented on LUCENE-9278: - bq. The issue is already solved, for backgrou

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097602#comment-17097602 ] Dawid Weiss commented on LUCENE-9278: - Answering myself: it can be a regular Windows

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097599#comment-17097599 ] Uwe Schindler commented on LUCENE-9278: --- The issue is already solved, for backgrou

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097594#comment-17097594 ] Dawid Weiss commented on LUCENE-9278: - I'm on Windows and backslashes work(ed) just

[jira] [Commented] (SOLR-14430) Authorization plugins should check roles from request

2020-05-01 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097593#comment-17097593 ] Jan Høydahl commented on SOLR-14430: I’m not currently working on this feature, so fe

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097586#comment-17097586 ] Dawid Weiss commented on LUCENE-9321: - bq. So why are you arguing to have the javado

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
MarcusSorealheis commented on a change in pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r418677843 ## File path: solr/bin/solr.cmd ## @@ -1288,6 +1295,7 @@ REM '-OmitStackTraceInFastThrow' ensures stack traces in errors, REM users who don

[jira] [Resolved] (SOLR-11936) maven urls should use https

2020-05-01 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-11936. -- Resolution: Duplicate > maven urls should use https > --- > > K

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
MarcusSorealheis commented on a change in pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r418671239 ## File path: solr/bin/solr ## @@ -2097,6 +2097,14 @@ else SECURITY_MANAGER_OPTS=() fi +# Enable ADMIN UI by default, and give the opti

[jira] [Comment Edited] (LUCENE-9321) Port documentation task to gradle

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097573#comment-17097573 ] Uwe Schindler edited comment on LUCENE-9321 at 5/1/20, 6:21 PM: --

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097573#comment-17097573 ] Uwe Schindler commented on LUCENE-9321: --- Sorry I still disagree with this: - On Wi

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-01 Thread GitBox
dweiss commented on a change in pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#discussion_r418669624 ## File path: gradle/documentation/markdown.gradle ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097569#comment-17097569 ] Dawid Weiss commented on LUCENE-9321: - I this should be done this way: the task that

[jira] [Commented] (SOLR-14440) Provide Certificate Authentication Plugin

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097568#comment-17097568 ] ASF subversion and git services commented on SOLR-14440: Commit 2

[jira] [Commented] (SOLR-14440) Provide Certificate Authentication Plugin

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097564#comment-17097564 ] ASF subversion and git services commented on SOLR-14440: Commit a

[jira] [Commented] (SOLR-14440) Provide Certificate Authentication Plugin

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097562#comment-17097562 ] ASF subversion and git services commented on SOLR-14440: Commit 3

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097551#comment-17097551 ] Uwe Schindler commented on LUCENE-9321: --- I cant proceed with the index.html/index.

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097550#comment-17097550 ] Uwe Schindler commented on LUCENE-9321: --- Hi, yes please. Could you still have a lo

[jira] [Assigned] (SOLR-14440) Provide Certificate Authentication Plugin

2020-05-01 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob reassigned SOLR-14440: Assignee: Mike Drob > Provide Certificate Authentication Plugin >

[jira] [Commented] (SOLR-14440) Provide Certificate Authentication Plugin

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097547#comment-17097547 ] ASF subversion and git services commented on SOLR-14440: Commit 7

[jira] [Resolved] (SOLR-14440) Provide Certificate Authentication Plugin

2020-05-01 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-14440. -- Fix Version/s: master (9.0) Resolution: Fixed > Provide Certificate Authentication Plugin >

[GitHub] [lucene-solr] uschindler commented on pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-01 Thread GitBox
uschindler commented on pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#issuecomment-622489584 For now I have no idea how to handle the last task, so I left it as nocommit. @mocobeta: any ideas how to get the relative path and the title of all projects below lucene

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
MarcusSorealheis commented on a change in pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r418646100 ## File path: solr/bin/solr ## @@ -2097,6 +2097,14 @@ else SECURITY_MANAGER_OPTS=() fi +# Enable ADMIN UI by default, and give the opti

[GitHub] [lucene-solr] madrob commented on a change in pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
madrob commented on a change in pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r418644915 ## File path: solr/bin/solr ## @@ -2097,6 +2097,14 @@ else SECURITY_MANAGER_OPTS=() fi +# Enable ADMIN UI by default, and give the option for use

[GitHub] [lucene-solr] madrob commented on a change in pull request #1467: LUCENE-9350: Don't hold references to large automata on FuzzyQuery

2020-05-01 Thread GitBox
madrob commented on a change in pull request #1467: URL: https://github.com/apache/lucene-solr/pull/1467#discussion_r418642710 ## File path: lucene/core/src/java/org/apache/lucene/search/FuzzyTermsEnum.java ## @@ -88,43 +89,44 @@ * @throws IOException if there is a low-leve

[jira] [Resolved] (SOLR-10415) Within solr-core, debug/trace level logging should use parameterized log messages

2020-05-01 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-10415. --- Fix Version/s: 8.6 Resolution: Fixed All the logging calls are either 1> parameterized

[jira] [Commented] (SOLR-14430) Authorization plugins should check roles from request

2020-05-01 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097524#comment-17097524 ] Mike Drob commented on SOLR-14430: -- I think that's definitely movement in the right dire

[jira] [Resolved] (SOLR-11884) find/fix inefficiencies in our use of logging

2020-05-01 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-11884. --- Fix Version/s: 7.4 Resolution: Fixed The specific problem with %C was fixed in Solr 7.

[jira] [Resolved] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

2020-05-01 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved LUCENE-7788. Fix Version/s: 8.6 Resolution: Fixed These checks are now wired in to gradle, both

[GitHub] [lucene-solr] madrob commented on a change in pull request #341: SOLR-12131: ExternalRoleRuleBasedAuthorizationPlugin

2020-05-01 Thread GitBox
madrob commented on a change in pull request #341: URL: https://github.com/apache/lucene-solr/pull/341#discussion_r418632788 ## File path: solr/core/src/java/org/apache/solr/security/PrincipalWithUserRoles.java ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Founda

[jira] [Commented] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097518#comment-17097518 ] ASF subversion and git services commented on LUCENE-7788: - Commi

[jira] [Commented] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097517#comment-17097517 ] ASF subversion and git services commented on LUCENE-7788: - Commi

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-01 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097513#comment-17097513 ] Tomoko Uchida commented on LUCENE-9321: --- I left a comment about javadocs destinati

[jira] [Commented] (SOLR-13289) Support for BlockMax WAND

2020-05-01 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097507#comment-17097507 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-13289: -- bq. It seems

[GitHub] [lucene-solr] madrob commented on a change in pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-05-01 Thread GitBox
madrob commented on a change in pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r418628204 ## File path: solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java ## @@ -54,6 +53,10 @@ import org.apache.solr.util.tracing.Gl

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
MarcusSorealheis commented on a change in pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r418630121 ## File path: solr/bin/solr ## @@ -2097,6 +2097,14 @@ else SECURITY_MANAGER_OPTS=() fi +# Enable ADMIN UI by default, and give the opti

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
MarcusSorealheis commented on a change in pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r418629568 ## File path: solr/core/src/java/org/apache/solr/servlet/LoadAdminUiServlet.java ## @@ -15,6 +15,13 @@ * limitations under the License. *

[GitHub] [lucene-solr] madrob commented on a change in pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-05-01 Thread GitBox
madrob commented on a change in pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r418627559 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java ## @@ -66,4 +80,132 @@ public LBHttp2SolrClient(Http2SolrCl

[GitHub] [lucene-solr] madrob commented on a change in pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
madrob commented on a change in pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r418622731 ## File path: solr/bin/solr.cmd ## @@ -1288,6 +1295,7 @@ REM '-OmitStackTraceInFastThrow' ensures stack traces in errors, REM users who don't care ab

[jira] [Resolved] (SOLR-14452) "classloading deadlock" issue with DocSet/SortedIntDocSet

2020-05-01 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter resolved SOLR-14452. --- Resolution: Invalid Gah, yes -- i initially found this on a PR branch and ment to dou

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097491#comment-17097491 ] Tomoko Uchida commented on LUCENE-9278: --- Thank you for fixing it. I tested the tas

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097488#comment-17097488 ] Uwe Schindler commented on LUCENE-9321: --- I started with markdown and copying of st

[GitHub] [lucene-solr] uschindler opened a new pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-01 Thread GitBox
uschindler opened a new pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477 This PR handles the markdown specific parts of the Lucene/Solr documentation: - copy static assets (unfortunetely those are not yet unified between borth projects) - convert .md files

[jira] [Resolved] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-9278. --- Resolution: Fixed I merged the change. When running "gradle javadoc" my problem is now that

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097463#comment-17097463 ] ASF subversion and git services commented on LUCENE-9278: - Commi

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097456#comment-17097456 ] Uwe Schindler commented on LUCENE-9278: --- Here is the PR, I will commit it in a mom

  1   2   >