[
https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097637#comment-17097637
]
Uwe Schindler commented on LUCENE-9278:
---------------------------------------
bq. We can build the options file with their API but I think what Tomoko did is
much more straightforward than trying to grasp what gradle folks do. And file
name escaping is really not such a biggie (hey, you did it in no time).
I found the option building just hard to read an error prone. I am sure that
anybody who adds a new option may break it again.
So my proposal would be to use a map with option name as key and a string as
value. Then you can just put all options on the map (options without argument
could use null or empty string as value).
At the end where the current list is serialized by joining with newlines, I
would just serialize the map, escaping all values. I will make a simple PR.
> Make javadoc folder structure follow Gradle project path
> --------------------------------------------------------
>
> Key: LUCENE-9278
> URL: https://issues.apache.org/jira/browse/LUCENE-9278
> Project: Lucene - Core
> Issue Type: Task
> Components: general/build
> Reporter: Tomoko Uchida
> Assignee: Tomoko Uchida
> Priority: Major
> Fix For: master (9.0)
>
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
> Current javadoc folder structure is derived from Ant project name. e.g.:
> [https://lucene.apache.org/core/8_4_1/analyzers-icu/index.html]
> [https://lucene.apache.org/solr/8_4_1/solr-solrj/index.html]
> For Gradle build, it should also follow gradle project structure (path)
> instead of ant one, to keep things simple to manage [1]. Hence, it will look
> like this:
> [https://lucene.apache.org/core/9_0_0/analysis/icu/index.html]
> [https://lucene.apache.org/solr/9_0_0/solr/solrj/index.html]
> [1] The change was suggested at the conversation between Dawid Weiss and I on
> a github pr: [https://github.com/apache/lucene-solr/pull/1304]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
