madrob commented on a change in pull request #1471:
URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r418644915
##########
File path: solr/bin/solr
##########
@@ -2097,6 +2097,14 @@ else
SECURITY_MANAGER_OPTS=()
fi
+# Enable ADMIN UI by default, and give the option for users to disable it
+if [ "$SOLR_ADMIN_UI_DISABLED" == "true" ]; then
+ SOLR_ADMIN_UI="-DdisableAdminUI=true"
+ echo -e "ADMIN UI Disabled"
+else
+ SOLR_ADMIN_UI="-DdisableAdminUI=false"
Review comment:
So if I set `SOLR_ADMIN_UI_DISABLED=true` in my `solr.in.sh`, then it
sets `SOLR_ADMIN_UI="-DdisableAdminUI=true"` here, and then... does nothing?
Because the `SOLR_ADMIN_UI` variable is never read. What am I missing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
