[jira] [Commented] (LUCENE-9215) replace checkJavaDocs.py with doclet

2020-02-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034206#comment-17034206 ] Dawid Weiss commented on LUCENE-9215: - I think eventually we should leverage the obj

[GitHub] [lucene-solr] atris commented on issue #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-02-10 Thread GitBox
atris commented on issue #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1214#issuecomment-584514132 @jpountz Updated, please see and let me know your thoughts ---

[GitHub] [lucene-solr] atris commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-02-10 Thread GitBox
atris commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1214#discussion_r377481946 ## File path: lucene/core/src/java/org/apache/lucene/search/QueueSizeBasedExecutionContr

[jira] [Commented] (LUCENE-9209) fix javadocs to be html5, enable doclint html checks, remove jtidy

2020-02-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034202#comment-17034202 ] Dawid Weiss commented on LUCENE-9209: - Thank Robert, looks great. > fix javadocs to

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-10 Thread GitBox
dweiss commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#discussion_r377479333 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/createLevAutomata.py ##

[jira] [Commented] (LUCENE-9201) Port documentation-lint task to Gradle build

2020-02-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034199#comment-17034199 ] Dawid Weiss commented on LUCENE-9201: - bq. we would need a special task to collect a

[jira] [Updated] (SOLR-14194) Allow Highlighting to work for indexes with uniqueKey that is not stored

2020-02-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-14194: Fix Version/s: 8.5 Resolution: Fixed Status: Resolved (was: Patch Available) I f

[jira] [Commented] (SOLR-14194) Allow Highlighting to work for indexes with uniqueKey that is not stored

2020-02-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034188#comment-17034188 ] ASF subversion and git services commented on SOLR-14194: Commit 8

[jira] [Commented] (SOLR-14194) Allow Highlighting to work for indexes with uniqueKey that is not stored

2020-02-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034183#comment-17034183 ] ASF subversion and git services commented on SOLR-14194: Commit 9

[GitHub] [lucene-solr] iverase commented on a change in pull request #1249: LUCENE-9217: Add validation to XYGeometries

2020-02-10 Thread GitBox
iverase commented on a change in pull request #1249: LUCENE-9217: Add validation to XYGeometries URL: https://github.com/apache/lucene-solr/pull/1249#discussion_r377470379 ## File path: lucene/core/src/java/org/apache/lucene/geo/XYRectangle.java ## @@ -29,12 +31,16 @@

[GitHub] [lucene-solr] iverase opened a new pull request #1249: LUCENE-9217: Add validation to XYGeometries

2020-02-10 Thread GitBox
iverase opened a new pull request #1249: LUCENE-9217: Add validation to XYGeometries URL: https://github.com/apache/lucene-solr/pull/1249 This PR adds validation for XYGeometries, in particular checking for non-valid values like NaN, INF and -INF.

[jira] [Created] (LUCENE-9217) Add validation for XYGeometries

2020-02-10 Thread Ignacio Vera (Jira)
Ignacio Vera created LUCENE-9217: Summary: Add validation for XYGeometries Key: LUCENE-9217 URL: https://issues.apache.org/jira/browse/LUCENE-9217 Project: Lucene - Core Issue Type: Improveme

[GitHub] [lucene-solr] dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader

2020-02-10 Thread GitBox
dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#issuecomment-584496996 I think this PR is ready for review @madrob since there are a lot of changes even without introducing SRL subclasses. --

[jira] [Commented] (LUCENE-9201) Port documentation-lint task to Gradle build

2020-02-10 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034152#comment-17034152 ] Tomoko Uchida commented on LUCENE-9201: --- Or, we would need a special task to colle

[jira] [Comment Edited] (LUCENE-9201) Port documentation-lint task to Gradle build

2020-02-10 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034121#comment-17034121 ] Tomoko Uchida edited comment on LUCENE-9201 at 2/11/20 4:43 AM: --

[jira] [Commented] (LUCENE-9201) Port documentation-lint task to Gradle build

2020-02-10 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034121#comment-17034121 ] Tomoko Uchida commented on LUCENE-9201: --- One small thing about the equivalent "ant

[jira] [Resolved] (SOLR-14247) IndexSizeTriggerMixedBoundsTest does a lot of sleeping

2020-02-10 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-14247. -- Fix Version/s: master (9.0) Assignee: Mike Drob Resolution: Fixed Thanks for the additi

[jira] [Commented] (SOLR-14247) IndexSizeTriggerMixedBoundsTest does a lot of sleeping

2020-02-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034104#comment-17034104 ] ASF subversion and git services commented on SOLR-14247: Commit 7

[GitHub] [lucene-solr] madrob merged pull request #1244: SOLR-14247 Remove unneeded sleeps

2020-02-10 Thread GitBox
madrob merged pull request #1244: SOLR-14247 Remove unneeded sleeps URL: https://github.com/apache/lucene-solr/pull/1244 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [lucene-solr] madrob commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-10 Thread GitBox
madrob commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#discussion_r377429993 ## File path: gradle/generation/util.gradle ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Ap

[jira] [Reopened] (SOLR-14245) Validate Replica / ReplicaInfo on creation

2020-02-10 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter reopened SOLR-14245: --- we're seeing a spike in (reproducible) jenkins failures for ReplicaListTransformerTest.t

[jira] [Comment Edited] (SOLR-14254) Index backcompat break between 8.3.1 and 8.4.1

2020-02-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034015#comment-17034015 ] David Smiley edited comment on SOLR-14254 at 2/10/20 11:35 PM:

[GitHub] [lucene-solr] ErickErickson commented on issue #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-10 Thread GitBox
ErickErickson commented on issue #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#issuecomment-584409136 I made the changes Mike mentioned, but I won't create another PR for a bit to give others a chance to look ---

[jira] [Commented] (SOLR-14254) Index backcompat break between 8.3.1 and 8.4.1

2020-02-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034015#comment-17034015 ] David Smiley commented on SOLR-14254: - CC [~jpountz] I think Hossman has a point that

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-10 Thread GitBox
ErickErickson commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#discussion_r377376693 ## File path: gradle/generation/util.gradle ## @@ -0,0 +1,107 @@ +/* + * Licensed to

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-10 Thread GitBox
ErickErickson commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#discussion_r377374590 ## File path: gradle/generation/util.gradle ## @@ -0,0 +1,107 @@ +/* + * Licensed to

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-10 Thread GitBox
ErickErickson commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#discussion_r377369604 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/createLevAutomata.py ###

[jira] [Comment Edited] (SOLR-14254) Index backcompat break between 8.3.1 and 8.4.1

2020-02-10 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033993#comment-17033993 ] Cassandra Targett edited comment on SOLR-14254 at 2/10/20 10:57 PM: ---

[jira] [Commented] (SOLR-14254) Index backcompat break between 8.3.1 and 8.4.1

2020-02-10 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033998#comment-17033998 ] Chris M. Hostetter commented on SOLR-14254: --- {quote}LUCENE-9116 is for 8.5, so

[jira] [Commented] (SOLR-14254) Index backcompat break between 8.3.1 and 8.4.1

2020-02-10 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033993#comment-17033993 ] Cassandra Targett commented on SOLR-14254: -- [~dsmiley], do you have a recommenda

[jira] [Commented] (SOLR-14254) Index backcompat break between 8.3.1 and 8.4.1

2020-02-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033989#comment-17033989 ] David Smiley commented on SOLR-14254: - FST50 has a back-compat break but there is no

[jira] [Commented] (SOLR-14254) Index backcompat break between 8.3.1 and 8.4.1

2020-02-10 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033973#comment-17033973 ] Chris M. Hostetter commented on SOLR-14254: --- I think the problem here is that {

[GitHub] [lucene-solr] madrob commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-10 Thread GitBox
madrob commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#discussion_r377327836 ## File path: gradle/generation/util.gradle ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Ap

[GitHub] [lucene-solr] madrob commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-10 Thread GitBox
madrob commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#discussion_r377332813 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/createLevAutomata.py ##

[GitHub] [lucene-solr] madrob commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-10 Thread GitBox
madrob commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#discussion_r377327334 ## File path: gradle/generation/util.gradle ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Ap

[jira] [Created] (SOLR-14254) Index backcompat break between 8.3.1 and 8.4.1

2020-02-10 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-14254: -- Summary: Index backcompat break between 8.3.1 and 8.4.1 Key: SOLR-14254 URL: https://issues.apache.org/jira/browse/SOLR-14254 Project: Solr Issue Type: I

[jira] [Updated] (SOLR-14254) Index backcompat break between 8.3.1 and 8.4.1

2020-02-10 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-14254: --- Description: I believe I found a backcompat break between 8.4.1 and 8.3.1. I encountered thi

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1238: SOLR-14240: Clean up znodes after shard deletion is invoked

2020-02-10 Thread GitBox
HoustonPutman commented on a change in pull request #1238: SOLR-14240: Clean up znodes after shard deletion is invoked URL: https://github.com/apache/lucene-solr/pull/1238#discussion_r377325559 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/DeleteShardCmd.ja

[jira] [Commented] (LUCENE-9215) replace checkJavaDocs.py with doclet

2020-02-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033944#comment-17033944 ] Robert Muir commented on LUCENE-9215: - It may be a while before I get to spend time

[jira] [Resolved] (LUCENE-9209) fix javadocs to be html5, enable doclint html checks, remove jtidy

2020-02-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9209. - Fix Version/s: master (9.0) Resolution: Fixed > fix javadocs to be html5, enable doclint

[jira] [Commented] (LUCENE-9201) Port documentation-lint task to Gradle build

2020-02-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033936#comment-17033936 ] Robert Muir commented on LUCENE-9201: - maybe we should try to get the PR in and iter

[jira] [Created] (SOLR-14253) Remove Sleeps from OverseerCollectionMessageHandler

2020-02-10 Thread Mike Drob (Jira)
Mike Drob created SOLR-14253: Summary: Remove Sleeps from OverseerCollectionMessageHandler Key: SOLR-14253 URL: https://issues.apache.org/jira/browse/SOLR-14253 Project: Solr Issue Type: Bug

[jira] [Commented] (SOLR-13579) Create resource management API

2020-02-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033914#comment-17033914 ] David Smiley commented on SOLR-13579: - [~ab] Do you think the design here will play n

[jira] [Resolved] (LUCENE-9149) Increase data dimension limit in BKD

2020-02-10 Thread Nick Knize (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Knize resolved LUCENE-9149. Resolution: Implemented > Increase data dimension limit in BKD > -

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-10 Thread GitBox
dsmiley commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r377238017 ## File path: lucene/core/src/java/org/apache/lucene/util/graph/GraphTokenStreamFiniteStrings.java ## @@ -124,6

[GitHub] [lucene-solr] andywebb1975 commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE

2020-02-10 Thread GitBox
andywebb1975 commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#discussion_r377223058 ## File path: solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java ## @@ -9

[jira] [Updated] (SOLR-14252) NullPointerException in AggregateMetric

2020-02-10 Thread Andy Webb (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Webb updated SOLR-14252: - Description: The {{getMax}} and {{getMin}} methods in [AggregateMetric|https://github.com/apache/lucene-

[jira] [Commented] (SOLR-13390) Provide Query Elevation Component by default

2020-02-10 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033703#comment-17033703 ] Jason Gerlowski commented on SOLR-13390: Sounds reasonable to me. +1 QEC is used

[jira] [Commented] (SOLR-13996) Refactor HttpShardHandler#prepDistributed() into smaller pieces

2020-02-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033687#comment-17033687 ] ASF subversion and git services commented on SOLR-13996: Commit 7

[jira] [Commented] (SOLR-13996) Refactor HttpShardHandler#prepDistributed() into smaller pieces

2020-02-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033686#comment-17033686 ] ASF subversion and git services commented on SOLR-13996: Commit 7

[jira] [Commented] (SOLR-14209) Upgrade JQuery to 3.4.1

2020-02-10 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033674#comment-17033674 ] Kevin Risden commented on SOLR-14209: - Thanks [~mkhl]! Sorry didn't think about the J

[jira] [Commented] (SOLR-14249) Krb5HttpClientBuilder should not buffer requests

2020-02-10 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033670#comment-17033670 ] Kevin Risden commented on SOLR-14249: - Yea SOLR-13270 is definitely relevant. > Krb5

[jira] [Updated] (SOLR-14243) ant clean-jars should not delete gradle-wrapper.jar

2020-02-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-14243: --- Priority: Trivial (was: Major) > ant clean-jars should not delete gradle-wrapper.jar > -

[jira] [Commented] (SOLR-14243) ant clean-jars should not delete gradle-wrapper.jar

2020-02-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033668#comment-17033668 ] ASF subversion and git services commented on SOLR-14243: Commit b

[jira] [Assigned] (SOLR-14243) ant clean-jars should not delete gradle-wrapper.jar

2020-02-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reassigned SOLR-14243: -- Assignee: Dawid Weiss > ant clean-jars should not delete gradle-wrapper.jar >

[jira] [Updated] (SOLR-14243) ant clean-jars should not delete gradle-wrapper.jar

2020-02-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-14243: --- Resolution: Fixed Status: Resolved (was: Patch Available) Thank you! > ant clean-jars shoul

[jira] [Commented] (LUCENE-9201) Port documentation-lint task to Gradle build

2020-02-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033658#comment-17033658 ] Dawid Weiss commented on LUCENE-9201: - Gradle's built-in javadoc task is indeed pret

[jira] [Commented] (SOLR-13996) Refactor HttpShardHandler#prepDistributed() into smaller pieces

2020-02-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033638#comment-17033638 ] ASF subversion and git services commented on SOLR-13996: Commit c

[jira] [Commented] (SOLR-13996) Refactor HttpShardHandler#prepDistributed() into smaller pieces

2020-02-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033639#comment-17033639 ] ASF subversion and git services commented on SOLR-13996: Commit c

[GitHub] [lucene-solr] shalinmangar merged pull request #1220: SOLR-13996: Refactor HttpShardHandler.prepDistributed method

2020-02-10 Thread GitBox
shalinmangar merged pull request #1220: SOLR-13996: Refactor HttpShardHandler.prepDistributed method URL: https://github.com/apache/lucene-solr/pull/1220 This is an automated message from the Apache Git Service. To respond t

[jira] [Commented] (LUCENE-9196) look into adding -XX:ActiveProcessorCount=1 to parallel build jvms

2020-02-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033612#comment-17033612 ] Dawid Weiss commented on LUCENE-9196: - Maybe I'm being overprotective here but it'll

[GitHub] [lucene-solr] ErickErickson opened a new pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-10 Thread GitBox
ErickErickson opened a new pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248 This adds the generation targets for util/packed and util/automaton. For whatever reason my local Python doesn't do anything weir

[GitHub] [lucene-solr] ErickErickson closed pull request #1241: Gradle util

2020-02-10 Thread GitBox
ErickErickson closed pull request #1241: Gradle util URL: https://github.com/apache/lucene-solr/pull/1241 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [lucene-solr] ErickErickson commented on issue #1241: Gradle util

2020-02-10 Thread GitBox
ErickErickson commented on issue #1241: Gradle util URL: https://github.com/apache/lucene-solr/pull/1241#issuecomment-584119269 Didn't link appropriately, I wondered why nobody replied. This is an automated message from the A

[jira] [Commented] (LUCENE-9188) Add jacoco code coverage support to gradle build

2020-02-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033554#comment-17033554 ] Robert Muir commented on LUCENE-9188: - We have to pass the last one precisely for th

[jira] [Comment Edited] (LUCENE-9188) Add jacoco code coverage support to gradle build

2020-02-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033549#comment-17033549 ] Dawid Weiss edited comment on LUCENE-9188 at 2/10/20 12:17 PM: ---

[jira] [Commented] (LUCENE-9188) Add jacoco code coverage support to gradle build

2020-02-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033549#comment-17033549 ] Dawid Weiss commented on LUCENE-9188: - I'm not really familiar with jacoco - I can i

[jira] [Commented] (LUCENE-9196) look into adding -XX:ActiveProcessorCount=1 to parallel build jvms

2020-02-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033543#comment-17033543 ] Robert Muir commented on LUCENE-9196: - I think the idea here is that jenkins will pa

[jira] [Commented] (LUCENE-9196) look into adding -XX:ActiveProcessorCount=1 to parallel build jvms

2020-02-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033538#comment-17033538 ] Dawid Weiss commented on LUCENE-9196: - I agree we could fine-tune the defaults bette

[GitHub] [lucene-solr] andywebb1975 commented on issue #1247: SOLR-14252 use double rather than Double to avoid NPE

2020-02-10 Thread GitBox
andywebb1975 commented on issue #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#issuecomment-584087529 The PR really just changes an exception to a warning - it may be papering over another issue. I'm going to try changing `

[jira] [Updated] (SOLR-14252) NullPointerException in AggregateMetric

2020-02-10 Thread Andy Webb (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Webb updated SOLR-14252: - Description: The {{getMax}} and {{getMin}} methods in [AggregateMetric|https://github.com/apache/lucene-

[jira] [Updated] (SOLR-14252) NullPointerException in AggregateMetric

2020-02-10 Thread Andy Webb (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Webb updated SOLR-14252: - Description: The {{getMax}} and {{getMin}} methods in [AggregateMetric|https://github.com/apache/lucene-

[jira] [Updated] (SOLR-14252) NullPointerException in AggregateMetric

2020-02-10 Thread Andy Webb (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Webb updated SOLR-14252: - Description: The {{getMax}} and {{getMin}} methods in [AggregateMetric|https://github.com/apache/lucene-

[GitHub] [lucene-solr] andywebb1975 opened a new pull request #1247: SOLR-14252 use double rather than Double to avoid NPE

2020-02-10 Thread GitBox
andywebb1975 opened a new pull request #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247 # Description The getMax and getMin methods in AggregateMetric can throw an NPE if non-Number values are present in values, when i

[jira] [Created] (SOLR-14252) NullPointerException in AggregateMetric

2020-02-10 Thread Andy Webb (Jira)
Andy Webb created SOLR-14252: Summary: NullPointerException in AggregateMetric Key: SOLR-14252 URL: https://issues.apache.org/jira/browse/SOLR-14252 Project: Solr Issue Type: Bug Security L

[jira] [Updated] (SOLR-14251) Shard Split on HDFS

2020-02-10 Thread Johannes Brucher (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johannes Brucher updated SOLR-14251: Description: Shard Split on HDFS Index will evaluate local disc space instead of HDFS space

[jira] [Commented] (LUCENE-9216) TestDoubleValuesSource#testSortMissingExplicit failure

2020-02-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033499#comment-17033499 ] ASF subversion and git services commented on LUCENE-9216: - Commi

[jira] [Resolved] (LUCENE-9216) TestDoubleValuesSource#testSortMissingExplicit failure

2020-02-10 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera resolved LUCENE-9216. -- Fix Version/s: 8.5 Assignee: Ignacio Vera Resolution: Fixed > TestDoubleValues

[jira] [Commented] (LUCENE-9216) TestDoubleValuesSource#testSortMissingExplicit failure

2020-02-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033498#comment-17033498 ] ASF subversion and git services commented on LUCENE-9216: - Commi

[GitHub] [lucene-solr] iverase merged pull request #1246: LUCENE-9216: Make sure we index LEAST_DOUBLE_VALUE

2020-02-10 Thread GitBox
iverase merged pull request #1246: LUCENE-9216: Make sure we index LEAST_DOUBLE_VALUE URL: https://github.com/apache/lucene-solr/pull/1246 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Created] (SOLR-14251) Shard Split on HDFS

2020-02-10 Thread Johannes Brucher (Jira)
Johannes Brucher created SOLR-14251: --- Summary: Shard Split on HDFS Key: SOLR-14251 URL: https://issues.apache.org/jira/browse/SOLR-14251 Project: Solr Issue Type: Bug Security Level:

[GitHub] [lucene-solr] alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost

2020-02-10 Thread GitBox
alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#issuecomment-584059142 Latest comments have been addressed, let me know if there's anything else needed here :) --

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-10 Thread GitBox
alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376982361 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/boost/DelimitedBoostTokenFilter.java

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-10 Thread GitBox
alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376980226 ## File path: lucene/core/src/java/org/apache/lucene/util/QueryBuilder.java ## @@ -63,6 +66,25 @@

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-10 Thread GitBox
alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376980226 ## File path: lucene/core/src/java/org/apache/lucene/util/QueryBuilder.java ## @@ -63,6 +66,25 @@

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-10 Thread GitBox
alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376978767 ## File path: lucene/core/src/java/org/apache/lucene/util/graph/GraphTokenStreamFiniteStrings.java #

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-10 Thread GitBox
alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376974784 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/boost/package-info.java ##

[GitHub] [lucene-solr] s1monw commented on issue #1215: LUCENE-9164: Ignore ACE on tragic event if IW is closed

2020-02-10 Thread GitBox
s1monw commented on issue #1215: LUCENE-9164: Ignore ACE on tragic event if IW is closed URL: https://github.com/apache/lucene-solr/pull/1215#issuecomment-584038675 I will start working on some refactorings to streamline this. ---

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-10 Thread GitBox
romseygeek commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376937485 ## File path: lucene/core/src/java/org/apache/lucene/util/QueryBuilder.java ## @@ -63,6 +66,25 @@ protecte

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-10 Thread GitBox
romseygeek commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376936277 ## File path: lucene/core/src/java/org/apache/lucene/util/graph/GraphTokenStreamFiniteStrings.java ## @@ -12

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-10 Thread GitBox
romseygeek commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376935901 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/boost/package-info.java ## @@ -0,0

[GitHub] [lucene-solr] iverase opened a new pull request #1246: LUCENE-9216: Make sure we index LEAST_DOUBLE_VALUE

2020-02-10 Thread GitBox
iverase opened a new pull request #1246: LUCENE-9216: Make sure we index LEAST_DOUBLE_VALUE URL: https://github.com/apache/lucene-solr/pull/1246 Trivial test fix This is an automated message from the Apache Git Service. To re

[jira] [Created] (LUCENE-9216) TestDoubleValuesSource#testSortMissingExplicit failure

2020-02-10 Thread Ignacio Vera (Jira)
Ignacio Vera created LUCENE-9216: Summary: TestDoubleValuesSource#testSortMissingExplicit failure Key: LUCENE-9216 URL: https://issues.apache.org/jira/browse/LUCENE-9216 Project: Lucene - Core

[jira] [Updated] (LUCENE-9136) Introduce IVFFlat to Lucene for ANN similarity search

2020-02-10 Thread Xin-Chun Zhang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xin-Chun Zhang updated LUCENE-9136: --- Description: Representation learning (RL) has been an established discipline in the machine